Skip to contentSkip to conversation

package/openrc: enable support when libselinux is selected

PATCH New unixmania at gmail.com 2 participants 2 messages Apr 16, 2020 – Apr 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/openrc: enable support when libselinux is selected

From: Adam Duskett <[email protected]>

OpenRC suports SELinux, so there is no reason to forcibly disable it.

Notice this only allows OpenRC to perform the initial policy load and set the enforcing mode. In order really use SELinux it's also necessary to select refpolicy, which provides a policy, and policycoreutils, which provides restorecon and other SELinux utilities.

---
Tested on QEMU, with ext4fs, selecting refpolicy and policycoreutils. Only disabled and permissive modes were used, since the enforcing mode currently does not work. See the help text in

package/refpolicy/Config.in for additional details.
---
CC: "Yann E. MORIN" <[email protected]>
---
Changes v1->v2:
- Improve the commit message, as suggested by Yann E. MORIN
- Explain which tests were performed

---
 package/openrc/openrc.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
package/openrc/openrc.mk +7 -1
index 6057451bfe..97536dad37 100644
@@ -18,7 +18,6 @@ OPENRC_MAKE_OPTS = \
 	LIBNAME=lib \
 	LIBEXECDIR=/usr/libexec/rc \
 	MKPKGCONFIG=no \
-	MKSELINUX=no \
 	MKSYSVINIT=yes \
 	BRANDING="Buildroot $(BR2_VERSION_FULL)" \
 	CC=$(TARGET_CC)
@@ -29,6 +28,13 @@ else
 OPENRC_MAKE_OPTS += MKSTATICLIBS=yes
 endif
 
+ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
+OPENRC_MAKE_OPTS += MKSELINUX=yes
+OPENRC_DEPENDENCIES += libselinux
+else
+OPENRC_MAKE_OPTS += MKSELINUX=no
+endif
+
 define OPENRC_BUILD_CMDS
 	$(MAKE) $(OPENRC_MAKE_OPTS) -C $(@D)
 endef
Signature · 1 line
2.18.2
#1 lore raw

PATCH v2 1/1 package/openrc: enable support when libselinux is selected

Quoted 9 lines · On Thu, 16 Apr 2020 00:21:37 -0300 unixmania at gmail.com wrote:

From: Adam Duskett <[email protected]>

OpenRC suports SELinux, so there is no reason to forcibly disable it.

Notice this only allows OpenRC to perform the initial policy load and set the enforcing mode. In order really use SELinux it's also necessary to select refpolicy, which provides a policy, and policycoreutils, which provides restorecon and other SELinux utilities.

Quoted 7 lines

---
Tested on QEMU, with ext4fs, selecting refpolicy and policycoreutils. Only disabled and permissive modes were used, since the enforcing mode currently does not work. See the help text in

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com