arm64: dts: rockchip: add bus-width properties to mmc nodes for rk3328.dtsi
Subsystems (2)
PATCH 1/3 arm64: dts: rockchip: add bus-width properties to mmc nodes for rk3328.dtsi
'bus-width' and pinctrl containing the bus-pins
should be in the same file, so add them to
all mmc nodes in 'rk3328.dtsi'.
--- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328.dtsi +3 -0
@@ -861,6 +861,7 @@ clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled";
@@ -873,6 +874,7 @@ clocks = <&cru HCLK_SDIO>, <&cru SCLK_SDIO>, <&cru SCLK_SDIO_DRV>, <&cru SCLK_SDIO_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled";
@@ -885,6 +887,7 @@ clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <8>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled";
Signature · 1 line
2.11.0
PATCH 2/3 arm64: dts: rockchip: add bus-width properties to mmc nodes for rk3368.dtsi
'bus-width' and pinctrl containing the bus-pins
should be in the same file, so add them to
all mmc nodes in 'rk3368.dtsi'.
--- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 3 +++ 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/rockchip/rk3368.dtsi +3 -0
@@ -210,6 +210,7 @@ clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; resets = <&cru SRST_MMC0>;
@@ -224,6 +225,7 @@ clocks = <&cru HCLK_SDIO0>, <&cru SCLK_SDIO0>, <&cru SCLK_SDIO0_DRV>, <&cru SCLK_SDIO0_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; resets = <&cru SRST_SDIO0>;
@@ -238,6 +240,7 @@ clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <8>; fifo-depth = <0x100>; interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>; resets = <&cru SRST_EMMC>;
Signature · 1 line
2.11.0
PATCH 3/3 arm64: dts: rockchip: add bus-width properties to mmc nodes for rk3399.dtsi
In reply to Johan Jonker'bus-width' and pinctrl containing the bus-pins
should be in the same file, so add them to
all mmc nodes in 'rk3399.dtsi'.
--- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399.dtsi +2 -0
@@ -299,6 +299,7 @@ clocks = <&cru HCLK_SDIO>, <&cru SCLK_SDIO>, <&cru SCLK_SDIO_DRV>, <&cru SCLK_SDIO_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; power-domains = <&power RK3399_PD_SDIOAUDIO>; resets = <&cru SRST_SDIO0>;
@@ -317,6 +318,7 @@ clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; power-domains = <&power RK3399_PD_SD>; resets = <&cru SRST_SDMMC>;
Signature · 1 line
2.11.0
Quoted 4 lines · Johan Jonker
'bus-width' and pinctrl containing the bus-pins
should be in the same file, so add them to
all mmc nodes in 'rk3328.dtsi'.
Nope. First of all, pinctrl usage is with pinctrl-N properties, not the pinctrl device, and there are no defaults set for any of the mmc nodes. Second, these are board design specific. For example, boards are free to use just 4 bits for the eMMC if they so desire. So this should be in each board dts file. If a board is missing this property, fix the board.
This applies to all three patches in the series.
ChenYu
Quoted 41 lines
Signed-off-by Johan Jonker <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 3 +++ 1 file changed, 3 insertions(+)arch/arm64/boot/dts/rockchip/rk3328.dtsi +3
-1@@ -861,6 +861,7 @@ clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled";@@ -873,6 +874,7 @@ clocks = <&cru HCLK_SDIO>, <&cru SCLK_SDIO>, <&cru SCLK_SDIO_DRV>, <&cru SCLK_SDIO_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled";@@ -885,6 +887,7 @@ clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <8>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled"; --2.11.0
_______________________________________________
linux-arm-kernel mailing list linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Heiko Stübner
maintainerHi ChenYu,
Am Dienstag, 21. April 2020, 05:48:52 CEST schrieb Chen-Yu Tsai:
Quoted 11 lines · Johan Jonker
Quoted 4 lines
'bus-width' and pinctrl containing the bus-pins
should be in the same file, so add them to
all mmc nodes in 'rk3328.dtsi'.Nope. First of all, pinctrl usage is with pinctrl-N properties, not the pinctrl device, and there are no defaults set for any of the mmc nodes. Second, these are board design specific. For example, boards are free to use just 4 bits for the eMMC if they so desire. So this should be in each board dts file. If a board is missing this property, fix the board.
you are correct that the pinctrl entries are missing from the patches, bus-width and pinctrl should be defined in the same file each time, but for the whole idea I tend to disagree.
So far every board with a Rockchip socs follows Rockchip's reference design for a lot of parts - for example I only see sdmmc nodes with bus-width=4 etc.
So the basic idea is to have default pinctrl settings for the settings everybody uses predefined ... if a board comes along that needs different settings it is free to redefine that.
Heiko
Quoted 47 lines
This applies to all three patches in the series.
ChenYu
Quoted 41 lines
Signed-off-by Johan Jonker <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 3 +++ 1 file changed, 3 insertions(+)arch/arm64/boot/dts/rockchip/rk3328.dtsi +3
-1@@ -861,6 +861,7 @@ clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled";@@ -873,6 +874,7 @@ clocks = <&cru HCLK_SDIO>, <&cru SCLK_SDIO>, <&cru SCLK_SDIO_DRV>, <&cru SCLK_SDIO_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <4>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled";@@ -885,6 +887,7 @@ clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; + bus-width = <8>; fifo-depth = <0x100>; max-frequency = <150000000>; status = "disabled"; --2.11.0
_______________________________________________
linux-arm-kernel mailing list linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 20 lines · Heiko Stübner
Hi ChenYu,
Am Dienstag, 21. April 2020, 05:48:52 CEST schrieb Chen-Yu Tsai:
Quoted 11 lines · Johan Jonker
Quoted 4 lines
'bus-width' and pinctrl containing the bus-pins
should be in the same file, so add them to
all mmc nodes in 'rk3328.dtsi'.Nope. First of all, pinctrl usage is with pinctrl-N properties, not the pinctrl device, and there are no defaults set for any of the mmc nodes. Second, these are board design specific. For example, boards are free to use just 4 bits for the eMMC if they so desire. So this should be in each board dts file. If a board is missing this property, fix the board.
you are correct that the pinctrl entries are missing from the patches, bus-width and pinctrl should be defined in the same file each time, but for the whole idea I tend to disagree.
Quoted 7 lines
So far every board with a Rockchip socs follows Rockchip's reference design for a lot of parts - for example I only see sdmmc nodes with bus-width=4 etc.
So the basic idea is to have default pinctrl settings for the settings everybody uses predefined ... if a board comes along that needs different settings it is free to redefine that.
I think having a default is a great idea. :)
ChenYu
Heiko Stübner
maintainerAm Dienstag, 21. April 2020, 10:29:49 CEST schrieb Chen-Yu Tsai:
Quoted 25 lines · Heiko Stübner
Quoted 24 lines
Hi ChenYu,
Am Dienstag, 21. April 2020, 05:48:52 CEST schrieb Chen-Yu Tsai:
Quoted 11 lines · Johan Jonker
Quoted 4 lines
'bus-width' and pinctrl containing the bus-pins
should be in the same file, so add them to
all mmc nodes in 'rk3328.dtsi'.Nope. First of all, pinctrl usage is with pinctrl-N properties, not the pinctrl device, and there are no defaults set for any of the mmc nodes. Second, these are board design specific. For example, boards are free to use just 4 bits for the eMMC if they so desire. So this should be in each board dts file. If a board is missing this property, fix the board.
you are correct that the pinctrl entries are missing from the patches, bus-width and pinctrl should be defined in the same file each time, but for the whole idea I tend to disagree.
So far every board with a Rockchip socs follows Rockchip's reference design for a lot of parts - for example I only see sdmmc nodes with bus-width=4 etc.
Quoted 5 lines
Quoted 3 lines
So the basic idea is to have default pinctrl settings for the settings everybody uses predefined ... if a board comes along that needs different settings it is free to redefine that.
I think having a default is a great idea. :)
especially for controllers that only ever use the same settings anyway.