cobalt: allow to compile without __USE_LARGEFILE64
PATCH 1/1 cobalt: allow to compile without __USE_LARGEFILE64
A header uses the off64_t which is only conditionally available, causing compile failures.
The macro might be necessary to compile cobalt libraries, but should not be needed for software depending on them.
--- include/cobalt/sys/mman.h | 2 ++ 1 file changed, 2 insertions(+)
include/cobalt/sys/mman.h +2 -0
@@ -31,8 +31,10 @@ extern "C" { COBALT_DECL(void *, mmap(void *addr, size_t length, int prot, int flags,int fd,off_t offset)); +#ifdef __USE_LARGEFILE64 COBALT_DECL(void *, mmap64(void *addr, size_t length, int prot, int flags,int fd,off64_t offset)); +#endif #ifdef __cplusplus }
Quoted 15 lines · Norbert Lange via Xenomai
A header uses the
off64_twhich is only conditionally available, causing compile failures.
The macro might be necessary to compile cobalt libraries, but should not be needed for software depending on them.Signed-off-by Norbert Lange <[email protected]>--- include/cobalt/sys/mman.h | 2 ++ 1 file changed, 2 insertions(+)include/cobalt/sys/mman.h +0
-0
include/cobalt/sys/mman.h extern "C" { · line 34
Quoted 4 lines
include/cobalt/sys/mman.h +1
-0@@ -31,8 +31,10 @@ extern "C" { COBALT_DECL(void *, mmap(void *addr, size_t length, int prot, int flags,int fd,off_t offset)); +#ifdef __USE_LARGEFILE64
Good catch, but I think this should be _LARGEFILE64_SOURCE instead.
Jan
Quoted 7 lines
include/cobalt/sys/mman.h +1
-0COBALT_DECL(void *, mmap64(void *addr, size_t length, int prot, int flags,int fd,off64_t offset)); +#endif #ifdef __cplusplus }
Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
True, rolled a v2 after reading up a bit.
The new check was ultimately copied over from musl, should suit some additional cases.
(I guess I wasn't running into it till now, as I mostly use _GNU_SOURCE)
Norbert
Am Fr., 17. Apr. 2020 um 08:10 Uhr schrieb Jan Kiszka <[email protected]>:
Quoted 37 lines · Norbert Lange via Xenomai
Quoted 15 lines
A header uses the
off64_twhich is only conditionally available, causing compile failures.
The macro might be necessary to compile cobalt libraries, but should not be needed for software depending on them.Signed-off-by Norbert Lange <[email protected]>--- include/cobalt/sys/mman.h | 2 ++ 1 file changed, 2 insertions(+)include/cobalt/sys/mman.h +0
-0include/cobalt/sys/mman.h extern "C" { · line 34
Quoted 4 lines
include/cobalt/sys/mman.h +1
-0@@ -31,8 +31,10 @@ extern "C" { COBALT_DECL(void *, mmap(void *addr, size_t length, int prot, int flags,int fd,off_t offset)); +#ifdef __USE_LARGEFILE64Good catch, but I think this should be
_LARGEFILE64_SOURCEinstead.Jan
include/cobalt/sys/mman.h extern "C" { · line 40
Quoted 7 lines
include/cobalt/sys/mman.h +1
-0COBALT_DECL(void *, mmap64(void *addr, size_t length, int prot, int flags,int fd,off64_t offset)); +#endif #ifdef __cplusplus }--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux