kcsan: Use GFP_ATOMIC under spin lock
Subsystems (2)
PATCH 1/1 kcsan: Use GFP_ATOMIC under spin lock
A spin lock is taken here so we should use GFP_ATOMIC.
Signed-off-by Wei Yongjun <[email protected]>
--- kernel/kcsan/debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/kcsan/debugfs.c +2 -2
@@ -230,7 +230,7 @@ static ssize_t insert_report_filterlist(const char *func)/* initial allocation */ report_filterlist.addrs =kmalloc_array (report_filterlist.size, -sizeof (unsigned long ),GFP_KERNEL ); +sizeof (unsigned long ),GFP_ATOMIC );if (report_filterlist.addrs ==NULL ) { ret = -ENOMEM ; goto out;
@@ -240,7 +240,7 @@ static ssize_t insert_report_filterlist(const char *func)size_t new_size = report_filterlist.size *2 ;unsigned long *new_addrs =krealloc (report_filterlist.addrs, - new_size *sizeof (unsigned long ),GFP_KERNEL ); + new_size *sizeof (unsigned long ),GFP_ATOMIC );if (new_addrs ==NULL ) {/* leave filterlist itself untouched */
Quoted 4 lines · Wei Yongjun
A spin lock is taken here so we should use
GFP_ATOMIC.Signed-off-by Wei Yongjun <[email protected]>
Good catch, thank you!
Reviewed-by Marco Elver <[email protected]>
Quoted 29 lines
--- kernel/kcsan/debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/kcsan/debugfs.c +2
-2@@ -230,7 +230,7 @@ static ssize_t insert_report_filterlist(const char *func)/* initial allocation */ report_filterlist.addrs >kmalloc_array (report_filterlist.size, -sizeof (unsigned long ),GFP_KERNEL ); +sizeof (unsigned long ),GFP_ATOMIC );if (report_filterlist.addrs =NULL ) { ret = -ENOMEM ; goto out;@@ -240,7 +240,7 @@ static ssize_t insert_report_filterlist(const char *func)size_t new_size = report_filterlist.size *2 ; unsigned long *new_addrs > krealloc(report_filterlist.addrs, - new_size * sizeof(unsigned long), GFP_KERNEL); + new_size * sizeof(unsigned long), GFP_ATOMIC);if (new_addrs =NULL ) {/* leave filterlist itself untouched */
Paul E. McKenney
AppliedQuoted 9 lines · Marco Elver
Quoted 4 lines · Wei Yongjun
A spin lock is taken here so we should use
GFP_ATOMIC.Signed-off-by Wei Yongjun <[email protected]>Good catch, thank you!
Reviewed-by Marco Elver <[email protected]>
Queued and pushed, thank you both!
Thanx, Paul
Quoted 29 lines
Quoted 29 lines
--- kernel/kcsan/debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/kcsan/debugfs.c +2
-2@@ -230,7 +230,7 @@ static ssize_t insert_report_filterlist(const char *func)/* initial allocation */ report_filterlist.addrs > > kmalloc_array(report_filterlist.size, -sizeof (unsigned long ),GFP_KERNEL ); +sizeof (unsigned long ),GFP_ATOMIC );if (report_filterlist.addrs =NULL ) { ret = -ENOMEM ; goto out;@@ -240,7 +240,7 @@ static ssize_t insert_report_filterlist(const char *func)size_t new_size = report_filterlist.size *2 ; unsigned long *new_addrs > > krealloc(report_filterlist.addrs, - new_size * sizeof(unsigned long), GFP_KERNEL); + new_size * sizeof(unsigned long), GFP_ATOMIC);if (new_addrs =NULL ) {/* leave filterlist itself untouched */