Skip to contentSkip to conversation

leds: tlc591xxt: hide error on EPROBE_DEFER

PATCH Applied Tomi Valkeinen 3 participants 3 messages Apr 17, 2020 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: tlc591xxt: hide error on EPROBE_DEFER

If devm_led_classdev_register_ext() fails with EPROBE_DEFER, we get:

tlc591xx 0-0040: couldn't register LED (null)

Only print the error if the error is something else than EPROBE_DEFER.

---
 drivers/leds/leds-tlc591xx.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/leds/leds-tlc591xx.c +3 -2
index a8911ebd30e5..0929f1275814 100644
@@ -214,8 +214,9 @@ tlc591xx_probe(struct i2c_client *client,
 		err = devm_led_classdev_register_ext(dev, &led->ldev,
 						     &init_data);
 		if (err < 0) {
-			dev_err(dev, "couldn't register LED %s\n",
-				led->ldev.name);
+			if (err != -EPROBE_DEFER)
+				dev_err(dev, "couldn't register LED %s\n",
+					led->ldev.name);
 			return err;
 		}
 	}
Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Reviewed-by on v1 1/1
#1 lore raw

Tomi

Quoted 17 lines · Tomi Valkeinen

If devm_led_classdev_register_ext() fails with EPROBE_DEFER, we get:

tlc591xx 0-0040: couldn't register LED (null)

Only print the error if the error is something else than EPROBE_DEFER.

---
  drivers/leds/leds-tlc591xx.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/leds/leds-tlc591xx.c +0 -0
index a8911ebd30e5..0929f1275814 100644
@@ -214,8 +214,9 @@ tlc591xx_probe(struct i2c_client *client,
  		err = devm_led_classdev_register_ext(dev, &led->ldev,

drivers/leds/leds-tlc591xx.c tlc591xx_probe(struct i2c_client *client, · line 222

Quoted 10 lines
drivers/leds/leds-tlc591xx.c +3 -2
  						     &init_data);
  		if (err < 0) {
-			dev_err(dev, "couldn't register LED %s\n",
-				led->ldev.name);
+			if (err != -EPROBE_DEFER)
+				dev_err(dev, "couldn't register LED %s\n",
+					led->ldev.name);
  			return err;
  		}
  	}
Applied
#2 lore raw
Quoted 5 lines · Dan Murphy

Tomi

Quoted 2 lines · Tomi Valkeinen

If devm_led_classdev_register_ext() fails with EPROBE_DEFER, we get:

Quoted 7 lines
Quoted 5 lines

tlc591xx 0-0040: couldn't register LED (null)

Only print the error if the error is something else than EPROBE_DEFER.

Thanks, applied.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html