tcp: cache line align MAX_TCP_HEADER
Subsystems (3)
PATCH 1/1 tcp: cache line align MAX_TCP_HEADER
TCP stack is dumb in how it cooks its output packets.
Depending on MAX_HEADER value, we might chose a bad ending point for the headers.
If we align the end of TCP headers to cache line boundary, we make sure to always use the smallest number of cache lines, which always help.
--- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/tcp.h +1 -1
@@ -51,7 +51,7 @@ extern struct inet_hashinfo tcp_hashinfo;extern struct percpu_counter tcp_orphan_count;void tcp_time_wait (struct sock *sk,int state,int timeo); -#define MAX_TCP_HEADER (128 + MAX_HEADER) +#define MAX_TCP_HEADER L1_CACHE_ALIGN(128 + MAX_HEADER)#define MAX_TCP_OPTION_SPACE 40#define TCP_MIN_SND_MSS 48#define TCP_MIN_GSO_SIZE (TCP_MIN_SND_MSS - MAX_TCP_OPTION_SPACE)
Signature · 1 line
2.26.1.301.g55bc3eb7cb9-goog
Quoted 6 lines · Eric Dumazet
TCP stack is dumb in how it cooks its output packets.
Depending on
MAX_HEADERvalue, we might chose a bad ending point for the headers.
Quoted 6 lines
If we align the end of TCP headers to cache line boundary, we make sure to always use the smallest number of cache lines, which always help.
Signed-off-by Eric Dumazet <[email protected]>Cc Soheil Hassas Yeganeh <[email protected]>
Very nice! Thank you!
Quoted 20 lines
--- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/net/tcp.h +1
-2@@ -51,7 +51,7 @@ extern struct inet_hashinfo tcp_hashinfo;extern struct percpu_counter tcp_orphan_count;void tcp_time_wait (struct sock *sk,int state,int timeo); -#define MAX_TCP_HEADER (128 + MAX_HEADER) +#define MAX_TCP_HEADER L1_CACHE_ALIGN(128 + MAX_HEADER)#define MAX_TCP_OPTION_SPACE 40#define TCP_MIN_SND_MSS 48#define TCP_MIN_GSO_SIZE (TCP_MIN_SND_MSS - MAX_TCP_OPTION_SPACE) --2.26.1.301.g55bc3eb7cb9-goog
From: Eric Dumazet <[email protected]>
Date: Fri, 17 Apr 2020 07:10:23 -0700
Quoted 10 lines
TCP stack is dumb in how it cooks its output packets.
Depending on
MAX_HEADERvalue, we might chose a bad ending point for the headers.If we align the end of TCP headers to cache line boundary, we make sure to always use the smallest number of cache lines, which always help.
Signed-off-by Eric Dumazet <[email protected]>
Applied, thanks Eric.