Skip to contentSkip to conversation

mm/memory: add refcount for special mapping page in copy_one_pte()

PATCH In review [email protected] 3 participants 7 messages Apr 17, 2020 – Apr 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/memory: add refcount for special mapping page in copy_one_pte()

From: chenqiwu <[email protected]>

If we get a special mapping page like device mapping page or zero page when copy_one_pte, it's necessary add the page refcount count.

---
 mm/memory.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/memory.c +2 -1
index f703fe8..a57975a 100644
@@ -802,8 +802,9 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr,
 		get_page(page);
 		page_dup_rmap(page, false);
 		rss[mm_counter(page)]++;
-	} else if (pte_devmap(pte)) {
+	} else if (pte_devmap(pte) || is_zero_pfn(pte_pfn(pte))) {
 		page = pte_page(pte);
+		get_page(page);
 	}
 
 out_set_pte:
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · On Fri 17-04-20 18:31:54, [email protected] wrote:

From: chenqiwu <[email protected]>

If we get a special mapping page like device mapping page or zero page when copy_one_pte, it's necessary add the page refcount count.

From the changelog it is not clear what is the actual problem and how the patch address it. Please be more verbose.

Quoted 23 lines
---
 mm/memory.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/memory.c +2 -1
index f703fe8..a57975a 100644
@@ -802,8 +802,9 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr,
 		get_page(page);
 		page_dup_rmap(page, false);
 		rss[mm_counter(page)]++;
-	} else if (pte_devmap(pte)) {
+	} else if (pte_devmap(pte) || is_zero_pfn(pte_pfn(pte))) {
 		page = pte_page(pte);
+		get_page(page);
 	}
 
 out_set_pte:
Signature · 1 line
1.9.1
Signature · 2 lines
Michal Hocko
SUSE Labs
author
#2 lore raw
Quoted 9 lines · Michal Hocko
Quoted 4 lines · On Fri 17-04-20 18:31:54, [email protected] wrote:

From: chenqiwu <[email protected]>

If we get a special mapping page like device mapping page or zero page when copy_one_pte, it's necessary add the page refcount count.

From the changelog it is not clear what is the actual problem and how the patch address it. Please be more verbose.

I don't find any actual problem, but I think there should be addressed to update the page refcount for special mappings include devmap and zero page instead of doing nothing else, since we copy the pte from one task to the other.

#3 lore raw
Quoted 7 lines · chenqiwu
Quoted 6 lines · Michal Hocko
Quoted 4 lines · On Fri 17-04-20 18:31:54, [email protected] wrote:

From: chenqiwu <[email protected]>

If we get a special mapping page like device mapping page or zero page when copy_one_pte, it's necessary add the page refcount count.

Quoted 7 lines
Quoted 3 lines

From the changelog it is not clear what is the actual problem and how the patch address it. Please be more verbose.

I don't find any actual problem, but I think there should be addressed to update the page refcount for special mappings include devmap and zero page instead of doing nothing else, since we copy the pte from one task to the other.

But the zero page is special. It's never freed. So unless we're seeing a refcount problem with the zero page, I would suggest that your patch is eventually going to overflow the refcount on the zero page.

#4 lore raw
In reply to chenqiwu
Quoted 7 lines · chenqiwu
Quoted 6 lines · Michal Hocko
Quoted 4 lines · On Fri 17-04-20 18:31:54, [email protected] wrote:

From: chenqiwu <[email protected]>

If we get a special mapping page like device mapping page or zero page when copy_one_pte, it's necessary add the page refcount count.

Quoted 7 lines
Quoted 3 lines

From the changelog it is not clear what is the actual problem and how the patch address it. Please be more verbose.

I don't find any actual problem, but I think there should be addressed to update the page refcount for special mappings include devmap and zero page instead of doing nothing else, since we copy the pte from one task to the other.

As Matthew pointed out, zero pages are special. Just check how vm_normal_page returns NULL (the same is the case for pte_devmap). This means, among other things that zap_pte_range which is called during munmap will only clear the pte but it doesn't operate on those pages so there is no put_page for your get_page here.

I do realize that this might be a subtle details that might be confusing. On the other hand trying to formulate the specific problem and add an explanation of the fix in the changelog could have revealed this. It is really trivial to generate mappings backed by zero pages and if the reference count was not handled properly then it would blow up pretty quickly.

Signature · 2 lines
Michal Hocko
SUSE Labs
author
#5 lore raw
Quoted 22 lines · Michal Hocko
Quoted 7 lines · chenqiwu
Quoted 6 lines · Michal Hocko
Quoted 4 lines · On Fri 17-04-20 18:31:54, [email protected] wrote:

From: chenqiwu <[email protected]>

If we get a special mapping page like device mapping page or zero page when copy_one_pte, it's necessary add the page refcount count.

Quoted 7 lines
Quoted 3 lines

From the changelog it is not clear what is the actual problem and how the patch address it. Please be more verbose.

I don't find any actual problem, but I think there should be addressed to update the page refcount for special mappings include devmap and zero page instead of doing nothing else, since we copy the pte from one task to the other.

As Matthew pointed out, zero pages are special. Just check how vm_normal_page returns NULL (the same is the case for pte_devmap). This means, among other things that zap_pte_range which is called during munmap will only clear the pte but it doesn't operate on those pages so there is no put_page for your get_page here.

Quoted 7 lines

I do realize that this might be a subtle details that might be confusing. On the other hand trying to formulate the specific problem and add an explanation of the fix in the changelog could have revealed this. It is really trivial to generate mappings backed by zero pages and if the reference count was not handled properly then it would blow up pretty quickly.

I agree. But I can't see where to put the normal page refcount back in zap_pte_range(), is there an imbalnace between copy_one_pte() and zap_pte_range()?

BTW, I think the else if condition can be removed since we don't need to operate devmap pages.

#6 lore raw
Quoted 30 lines · chenqiwu
Quoted 22 lines · Michal Hocko
Quoted 7 lines · chenqiwu
Quoted 6 lines · Michal Hocko
Quoted 4 lines · On Fri 17-04-20 18:31:54, [email protected] wrote:

From: chenqiwu <[email protected]>

If we get a special mapping page like device mapping page or zero page when copy_one_pte, it's necessary add the page refcount count.

Quoted 7 lines
Quoted 3 lines

From the changelog it is not clear what is the actual problem and how the patch address it. Please be more verbose.

I don't find any actual problem, but I think there should be addressed to update the page refcount for special mappings include devmap and zero page instead of doing nothing else, since we copy the pte from one task to the other.

As Matthew pointed out, zero pages are special. Just check how vm_normal_page returns NULL (the same is the case for pte_devmap). This means, among other things that zap_pte_range which is called during munmap will only clear the pte but it doesn't operate on those pages so there is no put_page for your get_page here.

Quoted 7 lines

I do realize that this might be a subtle details that might be confusing. On the other hand trying to formulate the specific problem and add an explanation of the fix in the changelog could have revealed this. It is really trivial to generate mappings backed by zero pages and if the reference count was not handled properly then it would blow up pretty quickly.

Quoted 3 lines

I agree. But I can't see where to put the normal page refcount back in zap_pte_range(), is there an imbalnace between copy_one_pte() and zap_pte_range()?

No, there is no imbalance. The reference counter handling is very well hidden. Each page gets tracked by __tlb_remove_page and later handled tlb_flush_mmu. That all is done to optimize tlb flushing which is necessary when pages are freed.

Signature · 2 lines
Michal Hocko
SUSE Labs