Skip to contentSkip to conversation

drm/gma500: remove unused variable 'hdmi_ids'

PATCH Applied YueHaibing 2 participants 2 messages Apr 17, 2020

Subsystems (3)
lore
Share & tools
lore

YueHaibing

author
#0 lore raw

PATCH 1/1 drm/gma500: remove unused variable 'hdmi_ids'

drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=]

 static const struct pci_device_id hdmi_ids[] = {
                                   ^~~~~~~~

It is never used, remove it.

---
 drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/gma500/oaktrail_hdmi.c +0 -5
index b25086f252ae..a097a59a9eae 100644
@@ -663,11 +663,6 @@ void oaktrail_hdmi_init(struct drm_device *dev,
 	kfree(gma_encoder);
 }
 
-static const struct pci_device_id hdmi_ids[] = {
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x080d) },
-	{ 0 }
-};
-
 void oaktrail_hdmi_setup(struct drm_device *dev)
 {
 	struct drm_psb_private *dev_priv = dev->dev_private;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · YueHaibing

drivers/gpu/drm/gma500/oaktrail_hdmi.c:676:35: warning: ‘hdmi_ids’ defined but not used [-Wunused-const-variable=]

 static const struct pci_device_id hdmi_ids[] = {
                                   ^~~~~~~~

It is never used, remove it.

Queued for 5.8, thanks for your patch.
-Daniel

Quoted 24 lines
---
 drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/gma500/oaktrail_hdmi.c +0 -5
index b25086f252ae..a097a59a9eae 100644
@@ -663,11 +663,6 @@ void oaktrail_hdmi_init(struct drm_device *dev,
 	kfree(gma_encoder);
 }
 
-static const struct pci_device_id hdmi_ids[] = {
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x080d) },
-	{ 0 }
-};
-
 void oaktrail_hdmi_setup(struct drm_device *dev)
 {
 	struct drm_psb_private *dev_priv = dev->dev_private;
Signature · 1 line
2.17.1
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch