Add nouveau-crc tests

PATCH Superseded Lyude 2 participants 9 messages Apr 17, 2020 – Apr 19, 2020

Subsystems (2)

Library code Arm/Amlogic Meson SoC support

lore

Share & tools

lore

Lyude

author

2020-04-17 19:49 UTC #0 lore raw

v2 cover Add nouveau-crc tests

From: Lyude Paul <[email protected]>

Nouveau has finally gotten CRC support, hooray! Well, it's under review at least:

https://patchwork.freedesktop.org/series/74804/
(it has a cover letter, but nouveau's mailing list configuration has blocked the email so I'm waiting for a moderator to fix that)

So, this series adds the relevant tests for it since nvidia's CRC implementation has some rather interesting design choices that needed to be worked around.

Changes since v1:
* fix documentation errors Petri pointed out
* Fix documentation for igt_require_fd()
* Fix copyright year in tests/nouveau_crc.c

Lyude Paul (5):
lib/igt_core: Fix igt_assert_fd() documentation
lib/igt_core: Add igt_require_fd()
lib/igt_debugfs: Add igt_debugfs_pipe_dir()
lib/igt_kms: Hook up connector dithering prop
tests: Add nouveau-crc tests

 lib/drmtest.c       |  10 ++
 lib/drmtest.h       |   2 +
 lib/igt_core.h      |  16 +-
 lib/igt_debugfs.c   |  29 ++++
 lib/igt_debugfs.h   |   1 +
 lib/igt_kms.c       |   6 +
 lib/igt_kms.h       |   1 +
 tests/meson.build   |   1 +
 tests/nouveau_crc.c | 396 ++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 460 insertions(+), 2 deletions(-)
 create mode 100644 tests/nouveau_crc.c

Signature · 6 lines

2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Lyude

author

2020-04-17 19:49 UTC #1 lore raw

PATCH v2 1/5 lib/igt_core: Fix igt_assert_fd() documentation

From: Lyude Paul <[email protected]>

As Petri Latvala pointed out, some of the documentation in this macro is mistakenly copied from the other igt_assert*() macros. Let's fix that.

Signed-off-by Lyude Paul <[email protected]>

---
 lib/igt_core.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

lib/igt_core.h +2 -2

index b97fa2fa..3f69b072 100644
@@ -966,8 +966,8 @@ void igt_describe_f(const char *fmt, ...);
  *
  * Fails (sub-) test if the given file descriptor is invalid.
  *
- * Like igt_assert(), but displays the values being compared on failure instead
- * of simply printing the stringified expression.
+ * Like igt_assert(), but displays the stringified identifier that was supposed
+ * to contain a valid fd on failure.
  */
 #define igt_assert_fd(fd) \
 	igt_assert_f(fd >= 0, "file descriptor " #fd " failed\n");

Signature · 6 lines

2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Lyude

author

2020-04-17 19:49 UTC #2 lore raw

PATCH v2 2/5 lib/igt_core: Add igt_require_fd()

In reply to Lyude

From: Lyude Paul <[email protected]>

Like igt_assert_fd(), but using igt_require() instead

Changes since v1:
* Fix documentation error in igt_require_fd() - Petri Latvala

Signed-off-by Lyude Paul <[email protected]>

---
 lib/igt_core.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

lib/igt_core.h +12 -0

index 3f69b072..8f68b2dd 100644
@@ -1021,6 +1021,18 @@ void igt_describe_f(const char *fmt, ...);
 	else igt_debug("Test requirement passed: %s\n", #expr); \
 } while (0)
 
+/**
+ * igt_require_fd:
+ * @fd: file descriptor
+ *
+ * Skips (sub-) test if the given file descriptor is invalid.
+ *
+ * Like igt_require(), but displays the stringified identifier that was supposed
+ * to contain a valid fd on failure.
+ */
+#define igt_require_fd(fd) \
+	igt_require_f(fd >= 0, "file descriptor " #fd " failed\n");
+
 /**
  * igt_skip_on_f:
  * @expr: condition to test

Signature · 6 lines

2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Lyude

author

2020-04-17 19:49 UTC #3 lore raw

PATCH v2 3/5 lib/igt_debugfs: Add igt_debugfs_pipe_dir()

In reply to Lyude

From: Lyude Paul <[email protected]>

Like igt_debugfs_connector_dir(), but for pipes instead.

Signed-off-by Lyude Paul <[email protected]>

---
 lib/igt_debugfs.c | 29 +++++++++++++++++++++++++++++
 lib/igt_debugfs.h |  1 +
 2 files changed, 30 insertions(+)

lib/igt_debugfs.c +29 -0

index bf6be552..3c3b11e1 100644
@@ -260,6 +260,35 @@ int igt_debugfs_connector_dir(int device, char *conn_name, int mode)
 	return ret;
 }
 
+/**
+ * igt_debugfs_pipe_dir:
+ * @device: fd of the device
+ * @pipe: index of pipe
+ * @mode: mode bits as used by open()
+ *
+ * This opens the debugfs directory corresponding to the pipe index on the
+ * device for use with igt_sysfs_get() and related functions.
+ *
+ * Returns:
+ * The directory fd, or -1 on failure.
+ */
+int igt_debugfs_pipe_dir(int device, int pipe, int mode)
+{
+	char buf[128];
+	int dir, ret;
+
+	dir = igt_debugfs_dir(device);
+	if (dir < 0)
+		return dir;
+
+	snprintf(buf, sizeof(buf), "crtc-%d", pipe);
+	ret = openat(dir, buf, mode);
+
+	close(dir);
+
+	return ret;
+}
+
 /**
  * igt_debugfs_open:
  * @filename: name of the debugfs node to open

lib/igt_debugfs.h +1 -0

index 7d1a6175..15741a40 100644
@@ -36,6 +36,7 @@ char *igt_debugfs_path(int device, char *path, int pathlen);
 
 int igt_debugfs_dir(int device);
 int igt_debugfs_connector_dir(int device, char *conn_name, int mode);
+int igt_debugfs_pipe_dir(int device, int pipe, int mode);
 
 int igt_debugfs_open(int fd, const char *filename, int mode);
 void __igt_debugfs_read(int fd, const char *filename, char *buf, int size);

Signature · 6 lines

2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Lyude

author

2020-04-17 19:50 UTC #4 lore raw

PATCH v2 4/5 lib/igt_kms: Hook up connector dithering prop

In reply to Lyude

From: Lyude Paul <[email protected]>

Nvidia display hardware provides a set of flexible dithering options for CRTCs. This dithering is actually noticeable in the CRC output for all available tap points, and can be seen as CRC values for identical frames cycling between either 2 or 4 values repeatedly (each one of these values is a different dithering phase applied to the source output). Of course, this is very likely to break tests using CRC readback since we don't expect the CRC to change if the source content hasn't changed.

So, hook up support for configuring the dithering property and reset it to off from igt_display_reset() when applicable.

Signed-off-by Lyude Paul <[email protected]>

---
 lib/igt_kms.c | 6 ++++++
 lib/igt_kms.h | 1 +
 2 files changed, 7 insertions(+)

lib/igt_kms.c +6 -0

index e9621e7e..d45adfaf 100644
@@ -421,6 +421,7 @@ const char * const igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
 	[IGT_CONNECTOR_LINK_STATUS] = "link-status",
 	[IGT_CONNECTOR_MAX_BPC] = "max bpc",
 	[IGT_CONNECTOR_HDR_OUTPUT_METADATA] = "HDR_OUTPUT_METADATA",
+	[IGT_CONNECTOR_DITHERING_MODE] = "dithering mode",
 };
 
 /*

@@ -1802,6 +1803,10 @@ static void igt_output_reset(igt_output_t *output)
 	if (igt_output_has_prop(output, IGT_CONNECTOR_HDR_OUTPUT_METADATA))
 		igt_output_set_prop_value(output,
 					  IGT_CONNECTOR_HDR_OUTPUT_METADATA, 0);
+
+	if (igt_output_has_prop(output, IGT_CONNECTOR_DITHERING_MODE))
+		igt_output_set_prop_enum(output, IGT_CONNECTOR_DITHERING_MODE,
+					 "off");
 }
 
 /**

@@ -1816,6 +1821,7 @@ static void igt_output_reset(igt_output_t *output)
  * - %IGT_CONNECTOR_BROADCAST_RGB (if applicable)
  *   %IGT_CONNECTOR_CONTENT_PROTECTION (if applicable)
  *   %IGT_CONNECTOR_HDR_OUTPUT_METADATA (if applicable)
+ * - %IGT_CONNECTOR_DITHERING_MODE (if applicable)
  * - igt_output_override_mode() to default.
  *
  * For pipes:

lib/igt_kms.h +1 -0

index adca59ac..4899e765 100644
@@ -127,6 +127,7 @@ enum igt_atomic_connector_properties {
        IGT_CONNECTOR_LINK_STATUS,
        IGT_CONNECTOR_MAX_BPC,
        IGT_CONNECTOR_HDR_OUTPUT_METADATA,
+       IGT_CONNECTOR_DITHERING_MODE,
        IGT_NUM_CONNECTOR_PROPS
 };

Signature · 6 lines

2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Lyude

author

2020-04-17 19:49 UTC #5 lore raw

PATCH v2 5/5 tests: Add nouveau-crc tests

In reply to Lyude

From: Lyude Paul <[email protected]>

We're finally getting CRC support in nouveau, so let's start testing this in igt as well! While the normal CRC capture tests are nice, there's a number of Nvidia-specific hardware characteristics that we need to test as well.

The most important one is known as a "notifier context flip". Basically, Nvidia GPUs store generated CRCs in an allocated memory region, referred to as the notifier context, that the driver programs itself. Strangely, this region can only hold a limited number of CRC entries, and once it runs out of available entries the hardware simply sets an overrun bit and stops writing any new CRC entries.

Since igt-gpu-tools doesn't really have an expectation of only being able to grab a limited number of CRCs, we work around this in nouveau by allocating two separate CRC notifier regions each time we start capturing CRCs, and then flip between them whenever we get close to filling our currently programmed notifier context. While this keeps the number of CRC entries we lose to an absolute minimum, we are guaranteed to lose exactly one CRC entry between context flips. Thus, we add some tests to ensure that nouveau handles these flips correctly (pipe-[A-F]-ctx-flip-detection), and that igt itself is also able to handle them correctly (pipe-[A-F]-ctx-flip-skip-current-frame). Since these tests use a debugfs interface to manually control the notifier context flip threshold, we also add one test to ensure that any flip thresholds we set are cleared after a single CRC capture (ctx-flip-threshold-reset-after-capture).

In addition, we also add some simple tests to test Nvidia-specific CRC sources.

Changes since v1:
* Fix copyright year in nouveau_crc.c

Signed-off-by Lyude Paul <[email protected]>

---
 lib/drmtest.c       |  10 ++
 lib/drmtest.h       |   2 +
 tests/meson.build   |   1 +
 tests/nouveau_crc.c | 396 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 409 insertions(+)
 create mode 100644 tests/nouveau_crc.c

lib/drmtest.c +10 -0

index 1fc39925..53c01754 100644
@@ -112,6 +112,11 @@ bool is_i915_device(int fd)
 	return __is_device(fd, "i915");
 }
 
+bool is_nouveau_device(int fd)
+{
+	return __is_device(fd, "nouveau");
+}
+
 bool is_vc4_device(int fd)
 {
 	return __is_device(fd, "vc4");

@@ -537,6 +542,11 @@ void igt_require_intel(int fd)
 	igt_require(is_i915_device(fd) && has_known_intel_chipset(fd));
 }
 
+void igt_require_nouveau(int fd)
+{
+	igt_require(is_nouveau_device(fd));
+}
+
 void igt_require_vc4(int fd)
 {
 	igt_require(is_vc4_device(fd));

lib/drmtest.h +2 -0

index 632c616b..4937e9d2 100644
@@ -97,10 +97,12 @@ void gem_quiescent_gpu(int fd);
 
 void igt_require_amdgpu(int fd);
 void igt_require_intel(int fd);
+void igt_require_nouveau(int fd);
 void igt_require_vc4(int fd);
 
 bool is_amdgpu_device(int fd);
 bool is_i915_device(int fd);
+bool is_nouveau_device(int fd);
 bool is_vc4_device(int fd);
 
 /**

tests/meson.build +1 -0

index 0bdcfbe4..39f1362e 100644
@@ -71,6 +71,7 @@ test_progs = [
 	'kms_vblank',
 	'kms_vrr',
 	'meta_test',
+	'nouveau_crc',
 	'panfrost_get_param',
 	'panfrost_gem_new',
 	'panfrost_prime',

tests/nouveau_crc.c new file +396 -0

396 lines not on this page · raw message

Signature · 6 lines

2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-04-17 20:10 UTC #6 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for Add nouveau-crc tests (rev2)

In reply to Lyude

== Series Details ==

Series: Add nouveau-crc tests (rev2)
URL : https://patchwork.freedesktop.org/series/74811/
State : warning

== Summary ==

Did not get list of undocumented tests for this run, something is wrong!

Other than that, pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/133782 for the overview.

build:tests-debian-meson-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2327546):
/usr/bin/aarch64-linux-gnu-gcc -Itests/59830eb@@nouveau_crc@exe -Itests -I../tests -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/aarch64-linux-gnu -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include/libdrm/nouveau -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ 'tests/59830eb@@nouveau_crc@exe/nouveau_crc.c.o' -MF 'tests/59830eb@@nouveau_crc@exe/nouveau_crc.c.o.d' -o 'tests/59830eb@@nouveau_crc@exe/nouveau_crc.c.o' -c ../tests/nouveau_crc.c ../tests/nouveau_crc.c: In function ‘__real_main304’:
../tests/nouveau_crc.c:344:50: error: ‘O_DIRECTORY’ undeclared (first use in this function)

      dir = igt_debugfs_pipe_dir(data.drm_fd, pipe, O_DIRECTORY);
                                                    ^~~~~~~~~~~
  ../tests/nouveau_crc.c:344:50: note: each undeclared identifier is reported only once for each function it appears in
  ../tests/nouveau_crc.c:346:22: error: implicit declaration of function ‘openat’; did you mean ‘popen’? [-Werror=implicit-function-declaration]
      data.nv_crc_dir = openat(dir, "nv_crc", O_DIRECTORY);
                        ^~~~~~
                        popen

../tests/nouveau_crc.c:346:22: warning: nested extern declaration of ‘openat’ [-Wnested-externs]
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.
section_end:1587153730:build_script
section_start:1587153730:after_script
section_end:1587153731:after_script section_start:1587153731:upload_artifacts_on_failure section_end:1587153733:upload_artifacts_on_failure
ERROR: Job failed: exit code 1

build:tests-debian-meson-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2327545):
/usr/bin/arm-linux-gnueabihf-gcc -Itests/59830eb@@nouveau_crc@exe -Itests -I../tests -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/arm-linux-gnueabihf -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include/libdrm/nouveau -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -pthread -MD -MQ 'tests/59830eb@@nouveau_crc@exe/nouveau_crc.c.o' -MF 'tests/59830eb@@nouveau_crc@exe/nouveau_crc.c.o.d' -o 'tests/59830eb@@nouveau_crc@exe/nouveau_crc.c.o' -c ../tests/nouveau_crc.c ../tests/nouveau_crc.c: In function ‘__real_main304’:
../tests/nouveau_crc.c:344:50: error: ‘O_DIRECTORY’ undeclared (first use in this function)

      dir = igt_debugfs_pipe_dir(data.drm_fd, pipe, O_DIRECTORY);
                                                    ^~~~~~~~~~~
  ../tests/nouveau_crc.c:344:50: note: each undeclared identifier is reported only once for each function it appears in
  ../tests/nouveau_crc.c:346:22: error: implicit declaration of function ‘openat’; did you mean ‘popen’? [-Werror=implicit-function-declaration]
      data.nv_crc_dir = openat(dir, "nv_crc", O_DIRECTORY);
                        ^~~~~~
                        popen

../tests/nouveau_crc.c:346:22: warning: nested extern declaration of ‘openat’ [-Wnested-externs]
cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.
section_end:1587153707:build_script
section_start:1587153707:after_script
section_end:1587153708:after_script section_start:1587153708:upload_artifacts_on_failure section_end:1587153710:upload_artifacts_on_failure
ERROR: Job failed: exit code 1

build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/2327547):
../tests/nouveau_crc.c: In function ‘__real_main304’:
../tests/nouveau_crc.c:344:50: error: ‘O_DIRECTORY’ undeclared (first use in this function)

      dir = igt_debugfs_pipe_dir(data.drm_fd, pipe, O_DIRECTORY);
                                                    ^~~~~~~~~~~
  ../tests/nouveau_crc.c:344:50: note: each undeclared identifier is reported only once for each function it appears in
  ../tests/nouveau_crc.c:346:22: error: implicit declaration of function ‘openat’ [-Werror=implicit-function-declaration]
      data.nv_crc_dir = openat(dir, "nv_crc", O_DIRECTORY);
                        ^~~~~~
  ../tests/nouveau_crc.c:346:4: warning: nested extern declaration of ‘openat’ [-Wnested-externs]
      data.nv_crc_dir = openat(dir, "nv_crc", O_DIRECTORY);
      ^~~~

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1587153735:build_script section_start:1587153735:after_script section_end:1587153737:after_script section_start:1587153737:upload_artifacts_on_failure section_end:1587153738:upload_artifacts_on_failure
ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/133782
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-04-17 20:28 UTC #7 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Add nouveau-crc tests (rev2)

In reply to Lyude

== Series Details ==

Series: Add nouveau-crc tests (rev2)
URL : https://patchwork.freedesktop.org/series/74811/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8319 -> IGTPW_4484
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/index.html

Known issues
------------

Here are the changes found in IGTPW_4484 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][1] -> [INCOMPLETE][2] ([i915#151])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/fi-skl-lmem/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/fi-skl-lmem/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-icl-y: [PASS][3] -> [INCOMPLETE][4] ([i915#1580])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/fi-icl-y/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/fi-icl-y/igt@i915_selftest@[email protected]

[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580

Participating hosts (51 -> 46)
------------------------------

Additional (1): fi-kbl-7560u
Missing (6): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5599 -> IGTPW_4484

CI-20190529: 20190529
CI_DRM_8319: 18043327e8a9cba095bca9f80cdc70900a51f92c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4484: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/index.html
IGT_5599: cdb07101dda33e2fcb0f4c2aa199c47159d88f35 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Testlist changes ==

+igt@nouveau_crc@ctx-flip-threshold-reset-after-capture +igt@nouveau_crc@pipe-a-ctx-flip-detection +igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame +igt@nouveau_crc@pipe-a-source-outp-complete +igt@nouveau_crc@pipe-a-source-outp-inactive +igt@nouveau_crc@pipe-a-source-rg +igt@nouveau_crc@pipe-b-ctx-flip-detection +igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame +igt@nouveau_crc@pipe-b-source-outp-complete +igt@nouveau_crc@pipe-b-source-outp-inactive +igt@nouveau_crc@pipe-b-source-rg +igt@nouveau_crc@pipe-c-ctx-flip-detection +igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame +igt@nouveau_crc@pipe-c-source-outp-complete +igt@nouveau_crc@pipe-c-source-outp-inactive +igt@nouveau_crc@pipe-c-source-rg +igt@nouveau_crc@pipe-d-ctx-flip-detection +igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame +igt@nouveau_crc@pipe-d-source-outp-complete +igt@nouveau_crc@pipe-d-source-outp-inactive +igt@nouveau_crc@pipe-d-source-rg +igt@nouveau_crc@pipe-e-ctx-flip-detection +igt@nouveau_crc@pipe-e-ctx-flip-skip-current-frame +igt@nouveau_crc@pipe-e-source-outp-complete +igt@nouveau_crc@pipe-e-source-outp-inactive +igt@nouveau_crc@pipe-e-source-rg +igt@nouveau_crc@pipe-f-ctx-flip-detection +igt@nouveau_crc@pipe-f-ctx-flip-skip-current-frame +igt@nouveau_crc@pipe-f-source-outp-complete +igt@nouveau_crc@pipe-f-source-outp-inactive +igt@nouveau_crc@pipe-f-source-rg

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-04-19 08:19 UTC #8 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for Add nouveau-crc tests (rev2)

In reply to Lyude

== Series Details ==

Series: Add nouveau-crc tests (rev2)
URL : https://patchwork.freedesktop.org/series/74811/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8319_full -> IGTPW_4484_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4484_full:

### IGT changes ###

#### Possible regressions ####

* {igt@nouveau_crc@pipe-a-source-rg} (NEW):
- shard-iclb: NOTRUN -> [SKIP][1] +15 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb6/igt@[email protected]

* {igt@nouveau_crc@pipe-d-ctx-flip-detection} (NEW):
- shard-tglb: NOTRUN -> [SKIP][2] +20 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-tglb1/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_8319_full and IGTPW_4484_full:

### New IGT tests (21) ###

* igt@nouveau_crc@ctx-flip-threshold-reset-after-capture:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-a-ctx-flip-detection:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-a-source-outp-complete:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-a-source-outp-inactive:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-a-source-rg:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-b-source-outp-complete:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-b-source-outp-inactive:
- Statuses : 5 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-b-source-rg:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-c-ctx-flip-detection:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-c-source-outp-complete:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-c-source-outp-inactive:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-c-source-rg:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-d-source-outp-complete:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-d-source-outp-inactive:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@nouveau_crc@pipe-d-source-rg:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in IGTPW_4484_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-iclb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb6/igt@[email protected]

* igt@i915_suspend@forcewake:
- shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl6/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-hsw: [PASS][15] -> [DMESG-WARN][16] ([i915#128])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-hsw6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-hsw1/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#52] / [i915#54]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-glk4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-glk9/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl1/igt@[email protected]
- shard-apl: [PASS][21] -> [FAIL][22] ([i915#52] / [i915#54] / [i915#95])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl7/igt@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][23] -> [SKIP][24] ([i915#433])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-tglb8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-tglb6/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl7/igt@[email protected]

* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- shard-apl: [PASS][27] -> [FAIL][28] ([i915#1559] / [i915#95])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl8/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl7/igt@[email protected]
- shard-kbl: [PASS][29] -> [FAIL][30] ([i915#1559] / [i915#93] / [i915#95])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl7/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb4/igt@kms_psr@psr2_cursor_render.html

* igt@kms_setmode@basic:
- shard-kbl: [PASS][33] -> [FAIL][34] ([i915#31])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl1/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@in-flight-suspend:
- shard-kbl: [INCOMPLETE][35] ([i915#155]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl1/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-tglb: [INCOMPLETE][37] ([i915#456]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-tglb5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-tglb8/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][39] ([i915#716]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-glk6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-glk4/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][41] ([i915#454]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-iclb2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb8/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-snb: [FAIL][43] ([i915#1066]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-snb2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-snb2/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-kbl: [TIMEOUT][45] ([i915#1288]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl6/igt@[email protected]
- shard-apl: [TIMEOUT][47] ([i915#1288]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-apl: [FAIL][49] ([i915#54] / [i915#95]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-kbl: [FAIL][51] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][52] +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl3/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
- shard-apl: [FAIL][53] ([i915#54]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl2/igt@[email protected]
- shard-kbl: [FAIL][55] ([i915#54]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl6/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-glk: [FAIL][59] ([i915#52] / [i915#54]) -> [PASS][60] +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-glk5/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-glk5/igt@[email protected]

* {igt@kms_flip@flip-vs-suspend@c-dp1}:
- shard-kbl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl4/igt@kms_flip@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-apl: [FAIL][63] ([i915#95]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl6/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-hsw: [SKIP][67] ([fdo#109271]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-hsw1/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-hsw6/igt@[email protected]
- shard-glk: [SKIP][69] ([fdo#109271]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-glk1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-glk2/igt@[email protected]
- shard-iclb: [SKIP][71] ([fdo#109278]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-iclb7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb2/igt@[email protected]

* igt@perf@gen12-mi-rpc:
- shard-tglb: [FAIL][73] ([i915#1085]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-tglb1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-tglb8/igt@[email protected]

* {igt@perf@polling-parameterized}:
- shard-iclb: [FAIL][75] ([i915#1542]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-iclb6/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb4/igt@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][77] ([i915#468]) -> [FAIL][78] ([i915#454])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-tglb2/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-tglb5/igt@[email protected]

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-iclb: [SKIP][79] ([i915#1316] / [i915#579]) -> [SKIP][80] ([fdo#109293] / [fdo#109506])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-iclb7/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-iclb6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: [FAIL][81] ([fdo#108145] / [i915#265]) -> [FAIL][82] ([fdo#108145] / [i915#265] / [i915#95])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl1/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: [FAIL][83] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [FAIL][84] ([fdo#108145] / [i915#265])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-kbl2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-kbl6/igt@[email protected]
- shard-apl: [FAIL][85] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][86] ([fdo#108145] / [i915#265])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8319/shard-apl7/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4484/shard-apl1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5599 -> IGTPW_4484
* Piglit: piglit_4509 -> None

== Logs ==