Skip to contentSkip to conversation

package/apcupsd: new package

PATCH New James Hilliard 2 participants 3 messages Apr 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/apcupsd: new package

Apcupsd is a UPS control system that permits orderly shutdown of your computer in the event of a power failure.

---
Changes v1 -> v2:
- set ac_cv_path_usbcfg
- add apcupsd config sub-options

---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/apcupsd/Config.in    | 58 +++++++++++++++++++++++++++++++
 package/apcupsd/apcupsd.hash |  6 ++++
 package/apcupsd/apcupsd.mk   | 67 ++++++++++++++++++++++++++++++++++++
 5 files changed, 133 insertions(+)
 create mode 100644 package/apcupsd/Config.in
 create mode 100644 package/apcupsd/apcupsd.hash
 create mode 100644 package/apcupsd/apcupsd.mk
DEVELOPERS +1 -0
index c831d9d2d1..67456d0c4b 100644
@@ -1171,6 +1171,7 @@ F:	configs/pine64_defconfig
 F:	configs/pine64_sopine_defconfig
 
 N:	James Hilliard <[email protected]>
+F:	package/apcupsd/
 F:	package/gensio/
 F:	package/lua-std-debug/
 F:	package/lua-std-normalize/
package/Config.in +1 -0
index ccf54f2417..7a0ff1716d 100644
@@ -415,6 +415,7 @@ endmenu
 	source "package/aer-inject/Config.in"
 	source "package/am335x-pru-package/Config.in"
 	source "package/amd-catalyst/Config.in"
+	source "package/apcupsd/Config.in"
 	source "package/avrdude/Config.in"
 	source "package/bcache-tools/Config.in"
 	source "package/biosdevname/Config.in"
package/apcupsd/Config.in new file +58 -0

58 lines not on this page · raw message

package/apcupsd/apcupsd.hash new file +6 -0
new file mode 100644
index 0000000000..6795560f62
@@ -0,0 +1,6 @@
+# From https://sourceforge.net/projects/apcupsd/files/apcupsd%20-%20Stable/3.14.14/
+md5  cc8f5ced77f38906a274787acb9bc980  apcupsd-3.14.14.tar.gz
+sha1  f027fa141c929371fe860443b6d911ef3a3606fb  apcupsd-3.14.14.tar.gz
+# Locally computed:
+sha256  db7748559b6b4c3784f9856561ef6ac6199ef7bd019b3edcd7e0a647bf8f9867  apcupsd-3.14.14.tar.gz
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/apcupsd/apcupsd.mk new file +67 -0

67 lines not on this page · raw message

Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 package/apcupsd: new package

Quoted 4 lines · On Sat, 18 Apr 2020 18:39:53 -0600 James Hilliard <[email protected]>…

Apcupsd is a UPS control system that permits orderly shutdown of your computer in the event of a power failure.

I've applied, after changing the order of the option in Config.in and their handling in the .mk file so that they are sorted alphabetically.

However, one thing worries me: this package installs a binary called 'smtp' in $(TARGET_DIR)/usr/bin. 'smtp' seems like an awfully generic name, which could easily clash with another package. Should we rename that to apcupsd-smtp ? I'm not sure if 'smtp' gets used directly by apcupsd, or it's only a tool that you can use in apcupsd's configuration file.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/apcupsd: new package

In reply to James Hilliard
Quoted 8 lines · On Sat, 18 Apr 2020 18:39:53 -0600 James Hilliard <[email protected]>…

Apcupsd is a UPS control system that permits orderly shutdown of your computer in the event of a power failure.

---
Changes v1 -> v2:
- set ac_cv_path_usbcfg
- add apcupsd config sub-options

Quoted 10 lines
---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/apcupsd/Config.in    | 58 +++++++++++++++++++++++++++++++
 package/apcupsd/apcupsd.hash |  6 ++++
 package/apcupsd/apcupsd.mk   | 67 ++++++++++++++++++++++++++++++++++++
 5 files changed, 133 insertions(+)
 create mode 100644 package/apcupsd/Config.in
 create mode 100644 package/apcupsd/apcupsd.hash
 create mode 100644 package/apcupsd/apcupsd.mk

The build fails when the host machine doesn't have 'man' and 'col' to generate the documentation:

http://autobuild.buildroot.net/results/e65/e65c23c3c1cae9aa9d697323fabf8a6f310fc3ba/build-end.log

Could you have a look ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com