Skip to contentSkip to conversation

dt-bindings: net: mdio.yaml fixes

PATCH Superseded Florian Fainelli 2 participants 5 messages Apr 19, 2020

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover dt-bindings: net: mdio.yaml fixes

Hi,

This patch series documents some common MDIO devices properties such as resets (and delays) and broken-turn-around. The second patch also rephrases some descriptions to be more general towards MDIO devices and not specific towards Ethernet PHYs.

Florian Fainelli (2):
dt-bindings: net: mdio: Document common properties
dt-bindings: net: mdio: Make descriptions more general

 .../devicetree/bindings/net/mdio.yaml         | 37 ++++++++++++++++---
 1 file changed, 32 insertions(+), 5 deletions(-)
Signature · 1 line
2.19.1
#1 lore raw

PATCH v2 1/2 dt-bindings: net: mdio: Document common properties

Some of the properties pertaining to the broken turn around or resets were only documented in ethernet-phy.yaml while they are applicable across all MDIO devices and not Ethernet PHYs specifically which are a superset.

---
 .../devicetree/bindings/net/mdio.yaml         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
Documentation/devicetree/bindings/net/mdio.yaml +27 -0
index 50c3397a82bc..d268ed80bb77 100644
@@ -50,6 +50,33 @@ patternProperties:
         description:
           The ID number for the PHY.
 
+      broken-turn-around:
+        $ref: /schemas/types.yaml#definitions/flag
+        description:
+          If set, indicates the MDIO device does not correctly release
+          the turn around line low at the end of a MDIO transaction.
+
+      resets:
+        maxItems: 1
+
+      reset-names:
+        const: phy
+
+      reset-gpios:
+        maxItems: 1
+        description:
+          The GPIO phandle and specifier for the MDIO reset signal.
+
+      reset-assert-us:
+        description:
+          Delay after the reset was asserted in microseconds. If this
+          property is missing the delay will be skipped.
+
+      reset-deassert-us:
+        description:
+          Delay after the reset was deasserted in microseconds. If
+          this property is missing the delay will be skipped.
+
     required:
       - reg
 
Signature · 1 line
2.19.1
maintainer
#2 lore raw

Re: [PATCH net-next v2 1/2] dt-bindings: net: mdio: Document common properties

Quoted 15 lines · Florian Fainelli

Some of the properties pertaining to the broken turn around or resets were only documented in ethernet-phy.yaml while they are applicable across all MDIO devices and not Ethernet PHYs specifically which are a superset.

---
 .../devicetree/bindings/net/mdio.yaml         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
Documentation/devicetree/bindings/net/mdio.yaml +0 -0
index 50c3397a82bc..d268ed80bb77 100644

Documentation/devicetree/bindings/net/mdio.yaml patternProperties: · line 57

Quoted 8 lines
Documentation/devicetree/bindings/net/mdio.yaml +5 -0
@@ -50,6 +50,33 @@ patternProperties:
         description:
           The ID number for the PHY.
 
+      broken-turn-around:
+        $ref: /schemas/types.yaml#definitions/flag
+        description:
+          If set, indicates the MDIO device does not correctly release
+          the turn around line low at the end of a MDIO transaction.

Sorry, missed this the first time. Turn around is in the middle of the transaction, after the register bits for C22, not at the end of the transaction.

Andrew

#3 lore raw

PATCH v2 2/2 dt-bindings: net: mdio: Make descriptions more general

In reply to Florian Fainelli

A number of descriptions assume a PHY device, but since this binding describes a MDIO bus which can have different kinds of MDIO devices attached to it, rephrase some descriptions to be more general in that regard.

---
 Documentation/devicetree/bindings/net/mdio.yaml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/net/mdio.yaml +5 -5
index d268ed80bb77..7ea0b5510bc3 100644
@@ -31,13 +31,13 @@ properties:
     maxItems: 1
     description:
       The phandle and specifier for the GPIO that controls the RESET
-      lines of all PHYs on that MDIO bus.
+      lines of all devices on that MDIO bus.
 
   reset-delay-us:
     description:
-      RESET pulse width in microseconds. It applies to all PHY devices
-      and must therefore be appropriately determined based on all PHY
-      requirements (maximum value of all per-PHY RESET pulse widths).
+      RESET pulse width in microseconds. It applies to all MDIO devices
+      and must therefore be appropriately determined based on all devices
+      requirements (maximum value of all per-device RESET pulse widths).
 
 patternProperties:
   "^ethernet-phy@[0-9a-f]+$":
@@ -48,7 +48,7 @@ patternProperties:
         minimum: 0
         maximum: 31
         description:
-          The ID number for the PHY.
+          The ID number for the device.
 
       broken-turn-around:
         $ref: /schemas/types.yaml#definitions/flag
Signature · 1 line
2.19.1
maintainer Reviewed-by on v2 2/2
#4 lore raw

Re: [PATCH net-next v2 2/2] dt-bindings: net: mdio: Make descriptions more general

Quoted 6 lines · Florian Fainelli

A number of descriptions assume a PHY device, but since this binding describes a MDIO bus which can have different kinds of MDIO devices attached to it, rephrase some descriptions to be more general in that regard.

Andrew