RDMA/bnxt: Delete 'nq_ptr' variable which is not used
Subsystems (2)
PATCH 1/1 RDMA/bnxt: Delete 'nq_ptr' variable which is not used
From: Leon Romanovsky <[email protected]>
The variable "nq_ptr" is set but never used, this generates the following warning while compiling kernel with W=1 option.
drivers/infiniband/hw/bnxt_re/qplib_fp.c: In function 'bnxt_qplib_service_nq':drivers/infiniband/hw/bnxt_re/qplib_fp.c:303:25: warning:
variable 'nq_ptr' set but not used [-Wunused-but-set-variable]
303 | struct nq_base *nqe, **nq_ptr;
|--- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/hw/bnxt_re/qplib_fp.c +1 -2
@@ -300,12 +300,12 @@ static void bnxt_qplib_service_nq(unsigned long data) {struct bnxt_qplib_nq *nq = (struct bnxt_qplib_nq *)data;struct bnxt_qplib_hwq *hwq = &nq->hwq; -struct nq_base *nqe, **nq_ptr;int num_srqne_processed =0 ;int num_cqne_processed =0 ;struct bnxt_qplib_cq *cq;int budget = nq->budget;u32 sw_cons, raw_cons; +struct nq_base *nqe;uintptr_t q_handle;u16 type;
@@ -314,7 +314,6 @@ static void bnxt_qplib_service_nq(unsigned long data) raw_cons = hwq->cons;while (budget--) { sw_cons =HWQ_CMP (raw_cons, hwq); - nq_ptr = (struct nq_base **)hwq->pbl_ptr; nqe =bnxt_qplib_get_qe (hwq, sw_cons,NULL );if (!NQE_CMP_VALID (nqe, raw_cons, hwq->max_elements))break ;
Signature · 1 line
2.25.2
Jason Gunthorpe
AppliedQuoted 8 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
The variable "
nq_ptr" is set but never used, this generates the following warning while compiling kernel with W=1 option.
drivers/infiniband/hw/bnxt_re/qplib_fp.c: In function 'bnxt_qplib_service_nq':drivers/infiniband/hw/bnxt_re/qplib_fp.c:303:25: warning:
variable 'nq_ptr' set but not used [-Wunused-but-set-variable]
Quoted 8 lines
303 | struct nq_base *nqe, **nq_ptr; |Fixes fddcbbb02af4 ("RDMA/bnxt_re: Simplify obtaining queue entry from hw ring")Signed-off-by Leon Romanovsky <[email protected]>--- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to for-next, thanks
Jason