net: phy: Propagate error from bus->reset
Subsystems (3)
PATCH 1/1 net: phy: Propagate error from bus->reset
If a bus->reset() call for the mii_bus structure returns an error (e.g.:
-EPROE_DEFER) we should propagate it accordingly.
Signed-off-by Florian Fainelli <[email protected]>
--- drivers/net/phy/mdio_bus.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/net/phy/mdio_bus.c +6 -3
@@ -627,8 +627,11 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)gpiod_set_value_cansleep (gpiod,0 ); } -if (bus->reset) - bus->reset (bus); +if (bus->reset) { + err = bus->reset (bus); +if (err) + goto error_reset_gpiod; + }for (i =0 ; i <PHY_MAX_ADDR ; i++) {if ((bus->phy_mask & (1 << i)) ==0 ) {
@@ -657,7 +660,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner) mdiodev->device_remove (mdiodev); mdiodev->device_free (mdiodev); } - +error_reset_gpiod:/* Put PHYs in RESET to save power */ if (bus->reset_gpiod)gpiod_set_value_cansleep (bus->reset_gpiod,1 );
Signature · 1 line
2.19.1
Quoted 4 lines · Florian Fainelli
If a
bus->reset()call for themii_busstructure returns an error (e.g.:
-EPROE_DEFER) we should propagate it accordingly.Signed-off-by Florian Fainelli <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>
Andrew
From: Florian Fainelli <[email protected]>
Date: Sat, 18 Apr 2020 20:17:13 -0700
Quoted 4 lines
If a
bus->reset()call for themii_busstructure returns an error (e.g.:
-EPROE_DEFER) we should propagate it accordingly.Signed-off-by Florian Fainelli <[email protected]>
Applied, thanks.