package/efl: fix build with poppler and gcc 5
PATCH 1/1 package/efl: fix build with poppler and gcc 5
-std=c++11 is needed to avoid the following build failure with poppler and gcc 5:
/home/naourr/work/instance-0/output-1/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/poppler/cpp/poppler-page.h:40:37: note: C++11 'noexcept' only available with -std=c++11 or -std=gnu++11 /home/naourr/work/instance-0/output-1/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/poppler/cpp/poppler-page.h:70:10: error: 'unique_ptr' in namespace 'std' does not name a template type
std::unique_ptr<text_box_data> m_data;
^Fixes:
- http://autobuild.buildroot.org/results/3428b9017168db9239756dc06cdaa5ae004cab97
--- package/efl/efl.mk | 2 ++ 1 file changed, 2 insertions(+)
package/efl/efl.mk +2 -0
@@ -257,6 +257,8 @@ EFL_CONF_OPTS += --disable-image-loader-webp endif ifeq ($(BR2_PACKAGE_POPPLER),y) +# poppler needs c++11 +EFL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11" EFL_DEPENDENCIES += poppler EFL_CONF_OPTS += --enable-poppler else
Signature · 1 line
2.25.1
PATCH 1/1 package/efl: fix build with poppler and gcc 5
Quoted 20 lines · On Sat, 4 Apr 2020 23:32:45 +0200 Fabrice Fontaine…
-std=c++11 is needed to avoid the following build failure with poppler and gcc 5:
/home/naourr/work/instance-0/output-1/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/poppler/cpp/poppler-page.h:40:37: note: C++11 'noexcept' only available with -std=c++11 or -std=gnu++11/home/naourr/work/instance-0/output-1/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/poppler/cpp/poppler-page.h:70:10: error: 'unique_ptr' in namespace 'std' does not name a template typestd::unique_ptr<text_box_data> m_data; ^Fixes:
- http://autobuild.buildroot.org/results/3428b9017168db9239756dc06cdaa5ae004cab97Signed-off-by Fabrice Fontaine <[email protected]>--- package/efl/efl.mk | 2 ++ 1 file changed, 2 insertions(+)package/efl/efl.mk +0
-0
package/efl/efl.mk EFL_CONF_OPTS += --disable-image-loader-webp · line 261
Quoted 5 lines
package/efl/efl.mk +2
-0@@ -257,6 +257,8 @@ EFL_CONF_OPTS += --disable-image-loader-webp endif ifeq ($(BR2_PACKAGE_POPPLER),y) +# poppler needs c++11 +EFL_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
I've never been a big fan of adding such flags, but I've applied your patch nevertheless. What would be the correct thing here? Should it be the responsibility of poppler to add -std=c++11 into the CFLAGS of its .pc file when necessary ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/efl: fix build with poppler and gcc 5
In reply to Fabrice FontaineQuoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
-std=c++11 is needed to avoid the following build failure with poppler and gcc 5:
Quoted 8 lines
/home/naourr/work/instance-0/output-1/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/poppler/cpp/poppler-page.h:40:37: note: C++11 'noexcept' only available with -std=c++11 or -std=gnu++11/home/naourr/work/instance-0/output-1/host/bin/../arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/poppler/cpp/poppler-page.h:70:10: error: 'unique_ptr' in namespace 'std' does not name a template typestd::unique_ptr<text_box_data> m_data; ^Fixes:
- http://autobuild.buildroot.org/results/3428b9017168db9239756dc06cdaa5ae004cab97Signed-off-by Fabrice Fontaine <[email protected]>
Committed to 2020.02.x, thanks.
I initially worried if older gcc versions (efl only requires 4.7+) support the -std=c++11 option, but according to the release notes it was added in 4.7:
https://gcc.gnu.org/gcc-4.7/changes.html
Signature · 1 line
Bye, Peter Korsgaard