Skip to contentSkip to conversation

intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N

PATCH Applied Prarit Bhargava 3 participants 5 messages Apr 20, 2020 – Apr 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 intel-speed-select: Fix speed-select-base-freq-properties output on CLX-N

On CLX-N, the perf-profile-level's output is terminated before the speed-select-base-freq-properties are output which results in a corrupt json file.

Adjust the output of speed-select-base-freq-properties by one on CLX-N.

---
 tools/power/x86/intel-speed-select/isst-display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/intel-speed-select/isst-display.c +1 -1
index 51dbaa5f02ec..f6e2ce181123 100644
@@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,
 				_isst_pbf_display_information(cpu, outf,
 							      tdp_level,
 							  &ctdp_level->pbf_info,
-							      level + 1);
+							      level + 2);
 			continue;
 		}
 
Signature · 1 line
2.18.2
#1 lore raw
Quoted 7 lines · Prarit Bhargava

On CLX-N, the perf-profile-level's output is terminated before the speed-select-base-freq-properties are output which results in a corrupt json file.

Adjust the output of speed-select-base-freq-properties by one on CLX-N.

Thanks for the patch, it will be pulled from Srinivas' tree whenever he sends a PR to PDx86 mailing list.

Quoted 23 lines
---
 tools/power/x86/intel-speed-select/isst-display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/intel-speed-select/isst-display.c +1 -2
index 51dbaa5f02ec..f6e2ce181123 100644
@@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,
                                _isst_pbf_display_information(cpu, outf,
                                                              tdp_level,
                                                          &ctdp_level->pbf_info,
-                                                             level + 1);
+                                                             level + 2);
                        continue;
                }
 
--

2.18.2

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 11 lines · Andy Shevchenko
Quoted 7 lines · Prarit Bhargava

On CLX-N, the perf-profile-level's output is terminated before the speed-select-base-freq-properties are output which results in a corrupt json file.

Adjust the output of speed-select-base-freq-properties by one on CLX-N.

Thanks for the patch, it will be pulled from Srinivas' tree whenever he sends a PR to PDx86 mailing list.

Srinivas, OOC do you want these patches to be sent somewhere else? FWIW, I'm running get_maintainers.pl to get the mailing list and cc.

P.

Quoted 27 lines
Quoted 25 lines
---
 tools/power/x86/intel-speed-select/isst-display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/intel-speed-select/isst-display.c +1 -2
index 51dbaa5f02ec..f6e2ce181123 100644
@@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE *outf, int tdp_level,
                                _isst_pbf_display_information(cpu, outf,
                                                              tdp_level,
                                                          &ctdp_level->pbf_info,
-                                                             level + 1);
+                                                             level + 2);
                        continue;
                }
 
--

2.18.2

#3 lore raw
Quoted 14 lines · Prarit Bhargava
Quoted 12 lines · Andy Shevchenko
Quoted 9 lines · Prarit Bhargava

On CLX-N, the perf-profile-level's output is terminated before the
speed-select-base-freq-properties are output which results in a corrupt
json file.

Adjust the output of speed-select-base-freq-properties by one on CLX-N.

Quoted 7 lines
Quoted 3 lines

Thanks for the patch, it will be pulled from Srinivas' tree whenever
he sends a PR to PDx86 mailing list.

Srinivas, OOC do you want these patches to be sent somewhere else? FWIW, I'm
running get_maintainers.pl to get the mailing list and cc.

This mailing list is fine.

I will take care of it once I test it out an apply to my tree.

Thanks,
Srinivas

Quoted 34 lines

P.

Quoted 31 lines
Quoted 31 lines
---
 tools/power/x86/intel-speed-select/isst-display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/intel-speed-select/isst-display.c +0 -1
index 51dbaa5f02ec..f6e2ce181123 100644
@@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu,
 FILE *outf, int tdp_level,
                                _isst_pbf_display_information(cpu
 , outf,
                                                              tdp
 _level,
                                                          &ctdp_l
 evel->pbf_info,
-                                                             lev

el + 1);
+ lev

el + 2);
                        continue;
                }

--
2.18.2

maintainer Applied
#4 lore raw
In reply to Prarit Bhargava
Quoted 7 lines · Prarit Bhargava

On CLX-N, the perf-profile-level's output is terminated before the speed-select-base-freq-properties are output which results in a corrupt
json file.

Adjust the output of speed-select-base-freq-properties by one on CLX- N.

Applied.

Thanks,
Srinivas

Quoted 28 lines
---
 tools/power/x86/intel-speed-select/isst-display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/power/x86/intel-speed-select/isst-display.c +0 -1
index 51dbaa5f02ec..f6e2ce181123 100644
@@ -470,7 +470,7 @@ void isst_ctdp_display_information(int cpu, FILE
 *outf, int tdp_level,
 				_isst_pbf_display_information(cpu,
 outf,
 							      tdp_level
 ,
 							  &ctdp_level-
 >pbf_info,
-							      level +

1);

tools/power/x86/intel-speed-select/isst-display.c +1 -0
+							      level +

2);

tools/power/x86/intel-speed-select/isst-display.c +0 -0
 			continue;
 		}