Skip to contentSkip to conversation

mm/memory: remove unnecessary pte_devmap case in copy_one_pte()

PATCH Applied [email protected] 2 participants 2 messages Apr 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mm/memory: remove unnecessary pte_devmap case in copy_one_pte()

From: chenqiwu <[email protected]>

Since commit 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support"), the assignment to 'page' for pte_devmap case has been unnecessary. Let's remove it.

---
Change in v2:
- According to Matthew's suggestion, update commit title and message.

 mm/memory.c | 2 --
 1 file changed, 2 deletions(-)
mm/memory.c +0 -2
index f703fe8..2143827 100644
@@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr,
 		get_page(page);
 		page_dup_rmap(page, false);
 		rss[mm_counter(page)]++;
-	} else if (pte_devmap(pte)) {
-		page = pte_page(pte);
 	}
 
 out_set_pte:
Signature · 1 line
1.9.1
Acked-by on v2 1/1
#1 lore raw

It would ve great to keep the cc list if reposting.

Quoted 6 lines · On Mon 20-04-20 10:28:05, [email protected] wrote:

From: chenqiwu <[email protected]>

Since commit 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support"), the assignment to 'page' for pte_devmap case has been unnecessary. Let's remove it.

And also
[[email protected] - changelog]

Quoted 1 line
Quoted 22 lines

---
Change in v2:
- According to Matthew's suggestion, update commit title and message.

 mm/memory.c | 2 --
 1 file changed, 2 deletions(-)
mm/memory.c +0 -2
index f703fe8..2143827 100644
@@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr,
 		get_page(page);
 		page_dup_rmap(page, false);
 		rss[mm_counter(page)]++;
-	} else if (pte_devmap(pte)) {
-		page = pte_page(pte);
 	}
 
 out_set_pte:
Signature · 1 line
1.9.1
Signature · 2 lines
Michal Hocko
SUSE Labs