Skip to contentSkip to conversation

configs: rockpro64-rk3399: Enable the bits for SPI flash

PATCH New Peter Robinson 3 participants 4 messages Apr 20, 2020 – Apr 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: rockpro64-rk3399: Enable the bits for SPI flash

Enable all the config options needed for SPI flash support and putting U-Boot on the SPI flash.

---
 configs/rockpro64-rk3399_defconfig | 9 +++++++++
 1 file changed, 9 insertions(+)
configs/rockpro64-rk3399_defconfig +9 -0
index 8074e4665a..4e7ea8cb6e 100644
@@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART=y
+CONFIG_SPL_SPI_SUPPORT=y
+CONFIG_SPL_SPI_FLASH_SUPPORT=y
+CONFIG_SPL_MTD_SUPPORT=y
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb"
 CONFIG_MISC_INIT_R=y
 CONFIG_DISPLAY_BOARDINFO_LATE=y
@@ -18,6 +21,8 @@ CONFIG_TPL=y
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_CMD_SF=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
@@ -34,7 +39,11 @@ CONFIG_MMC_DW=y
 CONFIG_MMC_DW_ROCKCHIP=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_ROCKCHIP_SPI=y
+CONFIG_SF_DEFAULT_SPEED=20000000
+CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
+CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
Signature · 1 line
2.26.1
#1 lore raw

PATCH 1/1 configs: rockpro64-rk3399: Enable the bits for SPI flash

Hi Peter,

Quoted 14 lines · Peter Robinson

Enable all the config options needed for SPI flash support and putting U-Boot on the SPI flash.

---
 configs/rockpro64-rk3399_defconfig | 9 +++++++++
 1 file changed, 9 insertions(+)
configs/rockpro64-rk3399_defconfig +0 -0
index 8074e4665a..4e7ea8cb6e 100644

configs/rockpro64-rk3399_defconfig CONFIG_NR_DRAM_BANKS=1 · line 13

Quoted 6 lines
configs/rockpro64-rk3399_defconfig +3 -0
@@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART=y
+CONFIG_SPL_SPI_SUPPORT=y
+CONFIG_SPL_SPI_FLASH_SUPPORT=y
+CONFIG_SPL_MTD_SUPPORT=y

Does Boot from SPI work for this via TPL?

configs/rockpro64-rk3399_defconfig CONFIG_TPL=y · line 25

Quoted 9 lines
configs/rockpro64-rk3399_defconfig +2 -0
 CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb"
 CONFIG_MISC_INIT_R=y
 CONFIG_DISPLAY_BOARDINFO_LATE=y
@@ -18,6 +21,8 @@ CONFIG_TPL=y
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_CMD_SF=y

This won't need, will select if we have DM SPI and FLASH.

configs/rockpro64-rk3399_defconfig CONFIG_MMC_DW=y · line 46

Quoted 12 lines
configs/rockpro64-rk3399_defconfig +4 -0
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TIME=y
@@ -34,7 +39,11 @@ CONFIG_MMC_DW=y
 CONFIG_MMC_DW_ROCKCHIP=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_ROCKCHIP_SPI=y
+CONFIG_SF_DEFAULT_SPEED=20000000
+CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_GIGADEVICE=y
+CONFIG_SPI_FLASH_WINBOND=y

Well,
CONFIG_SPI_FLASH_WINBOND=y
CONFIG_ROCKCHIP_SPI=y

Enough to enable SPI Flash on rk3399 platforms. refer this sha1 3d11196c802da6bb91562c9a105e401aa68b6629

Jagan.

#2 lore raw

PATCH 1/1 configs: rockpro64-rk3399: Enable the bits for SPI flash

Hi Peter,

??? Does Jagan's suggestion available for you?

Thanks,

- Kever

Quoted 57 lines · Jagan Teki

Hi Peter,

Quoted 13 lines · Peter Robinson

Enable all the config options needed for SPI flash support and putting U-Boot on the SPI flash.

---
  configs/rockpro64-rk3399_defconfig | 9 +++++++++
  1 file changed, 9 insertions(+)
configs/rockpro64-rk3399_defconfig +0 -0
index 8074e4665a..4e7ea8cb6e 100644

configs/rockpro64-rk3399_defconfig CONFIG_NR_DRAM_BANKS=1 · line 13

Quoted 6 lines
configs/rockpro64-rk3399_defconfig +3 -0
@@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1
  CONFIG_DEBUG_UART_BASE=0xFF1A0000
  CONFIG_DEBUG_UART_CLOCK=24000000
  CONFIG_DEBUG_UART=y
+CONFIG_SPL_SPI_SUPPORT=y
+CONFIG_SPL_SPI_FLASH_SUPPORT=y
+CONFIG_SPL_MTD_SUPPORT=y

Does Boot from SPI work for this via TPL?

configs/rockpro64-rk3399_defconfig CONFIG_TPL=y · line 25

Quoted 9 lines
configs/rockpro64-rk3399_defconfig +2 -0
  CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb"
  CONFIG_MISC_INIT_R=y
  CONFIG_DISPLAY_BOARDINFO_LATE=y
@@ -18,6 +21,8 @@ CONFIG_TPL=y
  CONFIG_CMD_BOOTZ=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_MMC=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_CMD_SF=y

This won't need, will select if we have DM SPI and FLASH.

configs/rockpro64-rk3399_defconfig CONFIG_MMC_DW=y · line 46

Quoted 12 lines
configs/rockpro64-rk3399_defconfig +4 -0
  CONFIG_CMD_USB=y
  # CONFIG_CMD_SETEXPR is not set
  CONFIG_CMD_TIME=y
@@ -34,7 +39,11 @@ CONFIG_MMC_DW=y
  CONFIG_MMC_DW_ROCKCHIP=y
  CONFIG_MMC_SDHCI=y
  CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_ROCKCHIP_SPI=y
+CONFIG_SF_DEFAULT_SPEED=20000000
+CONFIG_SPI_FLASH=y
  CONFIG_SPI_FLASH_GIGADEVICE=y
+CONFIG_SPI_FLASH_WINBOND=y

Well,
CONFIG_SPI_FLASH_WINBOND=y
CONFIG_ROCKCHIP_SPI=y

Enough to enable SPI Flash on rk3399 platforms. refer this sha1 3d11196c802da6bb91562c9a105e401aa68b6629

Jagan.

#3 lore raw

PATCH 1/1 configs: rockpro64-rk3399: Enable the bits for SPI flash

Quoted 4 lines · Kever Yang

Hi Peter,

Does Jagan's suggestion available for you?

I've not had time to test it hence the reason I've not replied but in the very lead Pine64 documents, see on pretty much all their board pages, that they may have either Winbond or Gigadevice SPI flash parts
[1] so his suggestion is incomplete.

Peter

[1] https://wiki.pine64.org/index.php/ROCKPro64#Datasheets_for_Components_and_Peripherals

Quoted 60 lines · Jagan Teki
Quoted 57 lines

Hi Peter,

Quoted 13 lines · Peter Robinson

Enable all the config options needed for SPI flash support and putting U-Boot on the SPI flash.

---
  configs/rockpro64-rk3399_defconfig | 9 +++++++++
  1 file changed, 9 insertions(+)
configs/rockpro64-rk3399_defconfig +0 -0
index 8074e4665a..4e7ea8cb6e 100644

configs/rockpro64-rk3399_defconfig CONFIG_NR_DRAM_BANKS=1 · line 13

Quoted 6 lines
configs/rockpro64-rk3399_defconfig +3 -0
@@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1
  CONFIG_DEBUG_UART_BASE=0xFF1A0000
  CONFIG_DEBUG_UART_CLOCK=24000000
  CONFIG_DEBUG_UART=y
+CONFIG_SPL_SPI_SUPPORT=y
+CONFIG_SPL_SPI_FLASH_SUPPORT=y
+CONFIG_SPL_MTD_SUPPORT=y

Does Boot from SPI work for this via TPL?

configs/rockpro64-rk3399_defconfig CONFIG_TPL=y · line 25

Quoted 9 lines
configs/rockpro64-rk3399_defconfig +2 -0
  CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb"
  CONFIG_MISC_INIT_R=y
  CONFIG_DISPLAY_BOARDINFO_LATE=y
@@ -18,6 +21,8 @@ CONFIG_TPL=y
  CONFIG_CMD_BOOTZ=y
  CONFIG_CMD_GPT=y
  CONFIG_CMD_MMC=y
+CONFIG_CMD_MTDPARTS=y
+CONFIG_CMD_SF=y

This won't need, will select if we have DM SPI and FLASH.

configs/rockpro64-rk3399_defconfig CONFIG_MMC_DW=y · line 46

Quoted 12 lines
configs/rockpro64-rk3399_defconfig +4 -0
  CONFIG_CMD_USB=y
  # CONFIG_CMD_SETEXPR is not set
  CONFIG_CMD_TIME=y
@@ -34,7 +39,11 @@ CONFIG_MMC_DW=y
  CONFIG_MMC_DW_ROCKCHIP=y
  CONFIG_MMC_SDHCI=y
  CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_ROCKCHIP_SPI=y
+CONFIG_SF_DEFAULT_SPEED=20000000
+CONFIG_SPI_FLASH=y
  CONFIG_SPI_FLASH_GIGADEVICE=y
+CONFIG_SPI_FLASH_WINBOND=y

Well,
CONFIG_SPI_FLASH_WINBOND=y
CONFIG_ROCKCHIP_SPI=y

Enough to enable SPI Flash on rk3399 platforms. refer this sha1 3d11196c802da6bb91562c9a105e401aa68b6629

Jagan.