Btrfs: remove useless check for copy_items() return value
PATCH 1/1 Btrfs: remove useless check for copy_items() return value
From: Filipe Manana <[email protected]>
At btrfs_log_prealloc_extents() we are checking if copy_items() returns a value greater than 0. That used to happen in the past to signal the caller that the path given to it was released and reused for other searches, but as of commit 0e56315ca147b3 ("Btrfs: fix missing hole after hole punching and fsync when using NO_HOLES"), the copy_items() function does not have that behaviour anymore and always returns 0 or a negative value. So just remove that check at btrfs_log_prealloc_extents(), which the previously mentioned commit forgot to remove.
--- fs/btrfs/tree-log.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
fs/btrfs/tree-log.c +1 -4
@@ -4336,12 +4336,9 @@ static int btrfs_log_prealloc_extents(struct btrfs_trans_handle *trans, } } } -if (ins_nr >0 ) { +if (ins_nr >0 ) ret =copy_items (trans, inode, dst_path, path, start_slot, ins_nr,1 ,0 ); -if (ret >0 ) - ret =0 ; - } out:btrfs_release_path (path);btrfs_free_path (dst_path);
Signature · 1 line
2.11.0
Quoted 11 lines · On Tue, Apr 21, 2020 at 11:25:31AM +0100, [email protected] wrote:
From: Filipe Manana <[email protected]>
At
btrfs_log_prealloc_extents()we are checking ifcopy_items()returns a value greater than 0. That used to happen in the past to signal the caller that the path given to it was released and reused for other searches, but as of commit0e56315ca147b3("Btrfs: fix missing hole after hole punching and fsync when usingNO_HOLES"), thecopy_items()function does not have that behaviour anymore and always returns 0 or a negative value. So just remove that check atbtrfs_log_prealloc_extents(), which the previously mentioned commit forgot to remove.
Quoted 1 line
Signed-off-by Filipe Manana <[email protected]>
Added to misc-next, thanks.