libipt_ULOG.c - include strings.h for the definition of ffs()
Subsystems (3)
PATCH 1/1 libipt_ULOG.c - include strings.h for the definition of ffs()
From: Maciej Żenczykowski <[email protected]>
This resolves compiler warnings:
extensions/libext4_srcs/gen/gensrcs/external/iptables/extensions/libipt_ULOG.c:89:32: error: implicit declaration of function 'ffs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
printf(" --ulog-nlgroup %d", ffs(loginfo->nl_group));
^extensions/libext4_srcs/gen/gensrcs/external/iptables/extensions/libipt_ULOG.c:105:9: error: implicit declaration of function 'ffs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
ffs(loginfo->nl_group));
^
Test: builds with less warnings
--- extensions/libipt_ULOG.c | 1 + 1 file changed, 1 insertion(+)
extensions/libipt_ULOG.c +1 -0
@@ -11,6 +11,7 @@*/ #include <stdio.h> #include <string.h> +#include <strings.h> #include <xtables.h> /* For 64bit kernel / 32bit userspace */ #include <linux/netfilter_ipv4/ipt_ULOG.h>
Signature · 1 line
2.26.1.301.g55bc3eb7cb9-goog
Pablo Neira Ayuso
maintainerQuoted 4 lines · Maciej Żenczykowski
From: Maciej Żenczykowski <[email protected]>
This resolves compiler warnings:
Quoted 8 lines
extensions/libext4_srcs/gen/gensrcs/external/iptables/extensions/libipt_ULOG.c:89:32: error: implicit declaration of function 'ffs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]printf(" --ulog-nlgroup %d", ffs(loginfo->nl_group)); ^
extensions/libext4_srcs/gen/gensrcs/external/iptables/extensions/libipt_ULOG.c:105:9: error: implicit declaration of function 'ffs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
ffs(loginfo->nl_group));
^Test: builds with less warnings
For the record, what compiler is triggering this? Or you use different -W options there?
I don't see these with gcc 9.3 here.
Quoted 20 lines
Signed-off-by Maciej Żenczykowski <[email protected]>--- extensions/libipt_ULOG.c | 1 + 1 file changed, 1 insertion(+)extensions/libipt_ULOG.c +1
-0@@ -11,6 +11,7 @@*/ #include <stdio.h> #include <string.h> +#include <strings.h> #include <xtables.h> /* For 64bit kernel / 32bit userspace */ #include <linux/netfilter_ipv4/ipt_ULOG.h> Signature · 1 line
2.26.1.301.g55bc3eb7cb9-goog
Must be some version of clang - presumably with -Wimplicit-function-declaration turned on.
I'm honestly not sure quite how to check, but it is whatever is the default in aosp on master.
note: I guess it could also be bionic vs libc header files... but per man ffs:
http://man7.org/linux/man-pages/man3/ffs.3.html
#include <strings.h>
int ffs(int i);
#include <string.h>
int ffsl(long int i);
int ffsll(long long int i);strings.h is the right header file.
Applied.