Skip to contentSkip to conversation

package/linux-tools: selftests: add numactl dependency for net tests

PATCH New Vadym Kochan 2 participants 6 messages Mar 25, 2020 – Apr 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/linux-tools: selftests: add numactl dependency for net tests

Linux selftests/net/reuseport_bpf_numa.c requires numa.h header which is provided by numactl package. Otherwise net tests are failed to install.

---
 package/linux-tools/Config.in                  | 1 +
 package/linux-tools/linux-tool-selftests.mk.in | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/linux-tools/Config.in +1 -0
index ceb58c668a..eda17440fe 100644
@@ -91,6 +91,7 @@ config BR2_PACKAGE_LINUX_TOOLS_SELFTESTS
 	select BR2_PACKAGE_KMOD_TOOLS # runtime (modprobe -n)
 	select BR2_PACKAGE_POPT
 	select BR2_PACKAGE_LIBCAP_NG
+	select BR2_PACKAGE_NUMACTL # required by net tests
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS # runtime (taskset)
 	help
package/linux-tools/linux-tool-selftests.mk.in +1 -1
index c4e5bf0fea..48849c5b52 100644
@@ -16,7 +16,7 @@ SELFTESTS_ARCH=$(KERNEL_ARCH)
 endif
 endif
 
-SELFTESTS_DEPENDENCIES = libcap-ng popt
+SELFTESTS_DEPENDENCIES = libcap-ng popt numactl
 
 SELFTESTS_MAKE_FLAGS = \
 	$(LINUX_MAKE_FLAGS) \
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/linux-tools: selftests: add numactl dependency for net tests

Hello Vadym,

Quoted 5 lines · On Wed, 25 Mar 2020 18:42:40 +0200 Vadym Kochan <[email protected]> wrote:

Linux selftests/net/reuseport_bpf_numa.c requires numa.h header which is provided by numactl package. Otherwise net tests are failed to install.

Thanks for your patch. However, I think this is not going in the right direction. Indeed, the selftests have many more dependencies:

- The BPF tests need libcap and libelf

- The gpio tests require libmount from util-linux

- The memfd tests require fuse

- The netfilter tests require libmnl

etc.

So, I think we should:

- Pass FORCE_TARGETS=1 during the build so that the build aborts if a required dependency is not found.

- Switch to using more optional dependencies, and disable the TARGETS that we cannot build by passing the appropriate SKIP_TARGETS value to the Makefile.

Could you work on this ? We probably need to make libcap-ng optional, but also popt. The other options that are selected by BR2_PACKAGE_LINUX_TOOLS_SELFTESTS might also need to be revisited.

An alternative is to just say that we don't care about making all of that optional, and simply unconditionally enable all the dependencies that selftests need, to build everything. Easier, but that's not the normal Buildroot design principle.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/linux-tools: selftests: add numactl dependency for net tests

Hi Thomas,

Quoted 37 lines · Thomas Petazzoni

Hello Vadym,

Quoted 5 lines · On Wed, 25 Mar 2020 18:42:40 +0200 Vadym Kochan <[email protected]> wrote:

Linux selftests/net/reuseport_bpf_numa.c requires numa.h header which is provided by numactl package. Otherwise net tests are failed to install.

Thanks for your patch. However, I think this is not going in the right direction. Indeed, the selftests have many more dependencies:

- The BPF tests need libcap and libelf

- The gpio tests require libmount from util-linux

- The memfd tests require fuse

- The netfilter tests require libmnl

etc.

So, I think we should:

- Pass FORCE_TARGETS=1 during the build so that the build aborts if a required dependency is not found.

- Switch to using more optional dependencies, and disable the TARGETS that we cannot build by passing the appropriate SKIP_TARGETS value to the Makefile.

Could you work on this ? We probably need to make libcap-ng optional, but also popt. The other options that are selected by BR2_PACKAGE_LINUX_TOOLS_SELFTESTS might also need to be revisited.

Quoted 8 lines

An alternative is to just say that we don't care about making all of that optional, and simply unconditionally enable all the dependencies that selftests need, to build everything. Easier, but that's not the normal Buildroot design principle.

Best regards,

Thomas

Yes, I understand your point. I think it would be useful to add config options per each selftests subsystem to easy turn it on.

Regards,
Vadym Kochan

#3 lore raw

PATCH 1/1 package/linux-tools: selftests: add numactl dependency for net tests

Hello,

Quoted 18 lines · On Tue, 21 Apr 2020 20:51:40 +0300 Vadim Kochan <[email protected]> wrote:
Quoted 18 lines

So, I think we should:

- Pass FORCE_TARGETS=1 during the build so that the build aborts if a required dependency is not found.

- Switch to using more optional dependencies, and disable the TARGETS that we cannot build by passing the appropriate SKIP_TARGETS value to the Makefile.

Could you work on this ? We probably need to make libcap-ng optional, but also popt. The other options that are selected by BR2_PACKAGE_LINUX_TOOLS_SELFTESTS might also need to be revisited.

An alternative is to just say that we don't care about making all of that optional, and simply unconditionally enable all the dependencies that selftests need, to build everything. Easier, but that's not the normal Buildroot design principle.

Quoted 6 lines
Quoted 3 lines

Best regards,

Thomas

Yes, I understand your point. I think it would be useful to add config options per each selftests subsystem to easy turn it on.

I don't know if we really want to add one sub-option for each selftest subsystem, that would be quite a lot.

However, we should properly enable/disable selftest subsystems depending on the availability of the necessary dependencies. For example, if numactl is enabled, then we enable the network-related selftests, otherwise we disable them.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/linux-tools: selftests: add numactl dependency for net tests

Hi,

Quoted 33 lines · Thomas Petazzoni

Hello,

Quoted 18 lines · On Tue, 21 Apr 2020 20:51:40 +0300 Vadim Kochan <[email protected]> wrote:
Quoted 18 lines

So, I think we should:

- Pass FORCE_TARGETS=1 during the build so that the build aborts if a required dependency is not found.

- Switch to using more optional dependencies, and disable the TARGETS that we cannot build by passing the appropriate SKIP_TARGETS value to the Makefile.

Could you work on this ? We probably need to make libcap-ng optional, but also popt. The other options that are selected by BR2_PACKAGE_LINUX_TOOLS_SELFTESTS might also need to be revisited.

An alternative is to just say that we don't care about making all of that optional, and simply unconditionally enable all the dependencies that selftests need, to build everything. Easier, but that's not the normal Buildroot design principle.

Quoted 6 lines
Quoted 3 lines

Best regards,

Thomas

Yes, I understand your point. I think it would be useful to add config options per each selftests subsystem to easy turn it on.

I don't know if we really want to add one sub-option for each selftest subsystem, that would be quite a lot.

Quoted 8 lines

However, we should properly enable/disable selftest subsystems depending on the availability of the necessary dependencies. For example, if numactl is enabled, then we enable the network-related selftests, otherwise we disable them.

Best regards,

Thomas

My only concern is that user should guess which packages are needed for particular test suites (I mean at least per sub-system), or document it somewhere ?

Regards,
Vadym Kochan

#5 lore raw

PATCH 1/1 package/linux-tools: selftests: add numactl dependency for net tests

Quoted 3 lines · On Wed, 22 Apr 2020 14:23:36 +0300 Vadim Kochan <[email protected]> wrote:

My only concern is that user should guess which packages are needed for particular test suites (I mean at least per sub-system), or document it somewhere ?

This is pretty common in Buildroot that we have automatic optional
dependencies: we enable a feature if the necessary dependencies are available. Having sub-options for everything would be a nightmare.

In addition, if a user had to build the selftests manually, he would also have to figure out "aaah, I need numactl to build the network tests".

In any case, the Buildroot .mk clearly documents the fact that package ABC is needed to get a given feature in package XYZ.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com