Skip to contentSkip to conversation

package/selinux-python: fix dependency

PATCH New Fabrice Fontaine 3 participants 3 messages Apr 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/selinux-python: fix dependency

Commit 791292c48d5165515ca08f35d8cbc1ef78d3ed95 forgot to add !BR2_PACKAGE_PYTHON dependency, without it the following error will be raised if the user selects BR2_PACKAGE_PYTHON and python-selinux:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON3
Depends on [n]: !BR2_PACKAGE_PYTHON [=y] && BR2_USE_WCHAR [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] Selected by [y]:
- BR2_PACKAGE_SELINUX_PYTHON [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]

Fixes:
- No autobuilder failures yet

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Fix commit message, keep select and add a !BR2_PACKAGE_PYTHON dependency

 package/selinux-python/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/selinux-python/Config.in +4 -0
index 1a610b29f0..862a63095a 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_SELINUX_PYTHON
 	bool "selinux-python"
+	depends on !BR2_PACKAGE_PYTHON
 	depends on BR2_USE_MMU
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
@@ -37,6 +38,9 @@ config BR2_PACKAGE_SELINUX_PYTHON_SEPOLGEN
 
 endif
 
+comment "selinux-python needs python3"
+	depends on BR2_PACKAGE_PYTHON
+
 comment "selinux-python packages needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/1 package/selinux-python: fix dependency

Quoted 8 lines · On Tue, 21 Apr 2020 16:53:15 +0200 Fabrice Fontaine…

Commit 791292c48d5165515ca08f35d8cbc1ef78d3ed95 forgot to add !BR2_PACKAGE_PYTHON dependency, without it the following error will be raised if the user selects BR2_PACKAGE_PYTHON and python-selinux:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON3
Depends on [n]: !BR2_PACKAGE_PYTHON [=y] && BR2_USE_WCHAR [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] Selected by [y]:
- BR2_PACKAGE_SELINUX_PYTHON [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]

Aah, yes. Indeed. Now it makes complete sense. And thank you for fixing this, I indeed completely overlooked that when changing the "select BR2_PACKAGE_PYTHON3".

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/selinux-python: fix dependency

In reply to Fabrice Fontaine

Fabrice, All,

On 2020-04-21 16:53 +0200, Fabrice Fontaine spake thusly:

Quoted 33 lines

Commit 791292c48d5165515ca08f35d8cbc1ef78d3ed95 forgot to add !BR2_PACKAGE_PYTHON dependency, without it the following error will be raised if the user selects BR2_PACKAGE_PYTHON and python-selinux:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON3
Depends on [n]: !BR2_PACKAGE_PYTHON [=y] && BR2_USE_WCHAR [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] Selected by [y]:
- BR2_PACKAGE_SELINUX_PYTHON [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n]

Fixes:
- No autobuilder failures yet

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Fix commit message, keep select and add a !BR2_PACKAGE_PYTHON dependency

 package/selinux-python/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/selinux-python/Config.in +1 -0
index 1a610b29f0..862a63095a 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_SELINUX_PYTHON
 	bool "selinux-python"
+	depends on !BR2_PACKAGE_PYTHON
 	depends on BR2_USE_MMU
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS

package/selinux-python/Config.in config BR2_PACKAGE_SELINUX_PYTHON_SEPOLGEN · line 42

Quoted 5 lines
package/selinux-python/Config.in +2 -0
@@ -37,6 +38,9 @@ config BR2_PACKAGE_SELINUX_PYTHON_SEPOLGEN
 
 endif
 
+comment "selinux-python needs python3"
+	depends on BR2_PACKAGE_PYTHON

I've added a dependency on MMU, as there is nothing that can be done about that. Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/selinux-python/Config.in +0 -0
 comment "selinux-python packages needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'