Skip to contentSkip to conversation

ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()

PATCH In review Jason Yan 2 participants 3 messages Apr 20, 2020 – Apr 22, 2020

Subsystems (3)
lore
Share & tools
lore

Jason Yan

author
#0 lore raw

PATCH 1/1 ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()

The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning:

drivers/net/wireless/ath/ath11k/debug.c:198:57-62: WARNING: conversion to bool not needed here drivers/net/wireless/ath/ath11k/debug.c:218:58-63: WARNING: conversion to bool not needed here

---
 drivers/net/wireless/ath/ath11k/debug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath11k/debug.c +2 -2
index 8d485171b0b3..69db298e16fb 100644
@@ -195,7 +195,7 @@ void ath11k_debug_fw_stats_process(struct ath11k_base *ab, struct sk_buff *skb)
 				total_vdevs_started += ar->num_started_vdevs;
 		}
 
-		is_end = ((++num_vdev) == total_vdevs_started ? true : false);
+		is_end = ((++num_vdev) == total_vdevs_started);
 
 		list_splice_tail_init(&stats.vdevs,
 				      &ar->debug.fw_stats.vdevs);
@@ -215,7 +215,7 @@ void ath11k_debug_fw_stats_process(struct ath11k_base *ab, struct sk_buff *skb)
 		/* Mark end until we reached the count of all started VDEVs
 		 * within the PDEV
 		 */
-		is_end = ((++num_bcn) == ar->num_started_vdevs ? true : false);
+		is_end = ((++num_bcn) == ar->num_started_vdevs);
 
 		list_splice_tail_init(&stats.bcn,
 				      &ar->debug.fw_stats.bcn);
Signature · 1 line
2.21.1
#1 lore raw
Quoted 10 lines · Jason Yan

The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning:

drivers/net/wireless/ath/ath11k/debug.c:198:57-62: WARNING: conversion to bool not needed here drivers/net/wireless/ath/ath11k/debug.c:218:58-63: WARNING: conversion to bool not needed here

Patch applied to ath-next branch of ath.git, thanks.

d81709346cea ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()

Signature · 8 lines
https://patchwork.kernel.org/patch/11498785/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#2 lore raw
In reply to Jason Yan
Quoted 10 lines · Jason Yan

The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning:

drivers/net/wireless/ath/ath11k/debug.c:198:57-62: WARNING: conversion to bool not needed here drivers/net/wireless/ath/ath11k/debug.c:218:58-63: WARNING: conversion to bool not needed here

Patch applied to ath-next branch of ath.git, thanks.

d81709346cea ath11k: remove conversion to bool in ath11k_debug_fw_stats_process()

Signature · 3 lines
https://patchwork.kernel.org/patch/11498785/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches