garmin_gps: add sanity checking for data length
Subsystems (2)
PATCH 1/1 garmin_gps: add sanity checking for data length
We must not process packets shorter than a packet ID
Signed-off-by Oliver Neukum <[email protected]>
Reported-and-tested-by [email protected]
--- drivers/usb/serial/garmin_gps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/serial/garmin_gps.c +2 -2
@@ -1138,8 +1138,8 @@ static void garmin_read_process(struct garmin_data *garmin_data_p,send it directly to the tty port */ if (garmin_data_p->flags &FLAGS_QUEUING ) {pkt_add (garmin_data_p, data, data_length); - }else if (bulk_data || -getLayerId (data) ==GARMIN_LAYERID_APPL ) { + }else if (bulk_data || (data_length >=sizeof (u32) && +getLayerId (data) ==GARMIN_LAYERID_APPL )) {spin_lock_irqsave (&garmin_data_p->lock, flags); garmin_data_p->flags |=APP_RESP_SEEN ;
Signature · 1 line
2.16.4
Johan Hovold
maintainerQuoted 4 lines · Oliver Neukum
We must not process packets shorter than a packet ID
Signed-off-by Oliver Neukum <[email protected]>Reported-and-tested-by [email protected]
Applied with a Fixes and CC-stable tag as technically this is a minuscule slab info leak.
Johan