Skip to contentSkip to conversation

pinctrl: intel: Update description in struct intel_community

PATCH In review Andy Shevchenko 2 participants 6 messages Apr 21, 2020 – Apr 22, 2020

Subsystems (3)
GPIO Pin control Pin controller - Intel
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/2 pinctrl: intel: Update description in struct intel_community

It appears that most of the drivers, that are using struct intel_community, utilize gpps rather than gpp_size. Update comment accordingly.

While here, correct the description of gpp_size, i.e. remove double space and drop redundant 'etc.' part.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-intel.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/intel/pinctrl-intel.h +4 -4
index 87fc0555ef90e..058bf2b6d9f0e 100644
@@ -94,8 +94,8 @@ enum {
  * @ie_offset: Register offset of GPI_IE from @regs.
  * @features: Additional features supported by the hardware
  * @pin_base: Starting pin of pins in this community
- * @gpp_size: Maximum number of pads in each group, such as PADCFGLOCK,
- *            HOSTSW_OWN,  GPI_IS, GPI_IE, etc. Used when @gpps is %NULL.
+ * @gpp_size: Maximum number of pads in each group, such as GPI_IS, GPI_IE,
+ *            PADCFGLOCK, HOSTSW_OWN. Used when @gpps is %NULL.
  * @gpp_num_padown_regs: Number of pad registers each pad group consumes at
  *			 minimum. Use %0 if the number of registers can be
  *			 determined by the size of the group.

@@ -106,8 +106,8 @@ enum {
  * @regs: Community specific common registers (reserved for core driver)
  * @pad_regs: Community specific pad registers (reserved for core driver)
  *
- * Most Intel GPIO host controllers this driver supports each pad group is
- * of equal size (except the last one). In that case the driver can just
+ * In some of Intel GPIO host controllers this driver supports each pad group
+ * is of equal size (except the last one). In that case the driver can just
  * fill in @gpp_size field and let the core driver to handle the rest. If
  * the controller has pad groups of variable size the client driver can
  * pass custom @gpps and @ngpps instead.
Signature · 1 line
2.26.1
author
#1 lore raw

PATCH 2/2 pinctrl: intel: Move npins closer to pin_base in struct intel_community

It's common across the drivers to use the (pin_base, npins) pair to describe community characteristics. Thus, move them in the struct intel_community to be closer to each other.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-intel.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pinctrl/intel/pinctrl-intel.h +3 -2
index 058bf2b6d9f0e..bd653f2a07382 100644
@@ -94,12 +94,12 @@ enum {
  * @ie_offset: Register offset of GPI_IE from @regs.
  * @features: Additional features supported by the hardware
  * @pin_base: Starting pin of pins in this community
+ * @npins: Number of pins in this community
  * @gpp_size: Maximum number of pads in each group, such as GPI_IS, GPI_IE,
  *            PADCFGLOCK, HOSTSW_OWN. Used when @gpps is %NULL.
  * @gpp_num_padown_regs: Number of pad registers each pad group consumes at
  *			 minimum. Use %0 if the number of registers can be
  *			 determined by the size of the group.
- * @npins: Number of pins in this community
  * @gpps: Pad groups if the controller has variable size pad groups
  * @ngpps: Number of pad groups in this community
  * @pad_map: Optional non-linear mapping of the pads

@@ -121,12 +121,13 @@ struct intel_community {
 	unsigned int ie_offset;
 	unsigned int features;
 	unsigned int pin_base;
+	size_t npins;
 	unsigned int gpp_size;
 	unsigned int gpp_num_padown_regs;
-	size_t npins;
 	const struct intel_padgroup *gpps;
 	size_t ngpps;
 	const unsigned int *pad_map;
+
 	/* Reserved for the core driver */
 	void __iomem *regs;
 	void __iomem *pad_regs;
Signature · 1 line
2.26.1
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH v1 2/2] pinctrl: intel: Move npins closer to pin_base in struct intel_community

Quoted 29 lines · Andy Shevchenko

It's common across the drivers to use the (pin_base, npins) pair to describe community characteristics. Thus, move them in the struct intel_community to be closer to each other.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-intel.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pinctrl/intel/pinctrl-intel.h +1 -1
index 058bf2b6d9f0e..bd653f2a07382 100644
@@ -94,12 +94,12 @@ enum {
  * @ie_offset: Register offset of GPI_IE from @regs.
  * @features: Additional features supported by the hardware
  * @pin_base: Starting pin of pins in this community
+ * @npins: Number of pins in this community
  * @gpp_size: Maximum number of pads in each group, such as GPI_IS, GPI_IE,
  *            PADCFGLOCK, HOSTSW_OWN. Used when @gpps is %NULL.
  * @gpp_num_padown_regs: Number of pad registers each pad group consumes at
  *			 minimum. Use %0 if the number of registers can be
  *			 determined by the size of the group.
- * @npins: Number of pins in this community
  * @gpps: Pad groups if the controller has variable size pad groups
  * @ngpps: Number of pad groups in this community
  * @pad_map: Optional non-linear mapping of the pads

@@ -121,12 +121,13 @@ struct intel_community {
 	unsigned int ie_offset;

drivers/pinctrl/intel/pinctrl-intel.h struct intel_community { · line 130

Quoted 10 lines
drivers/pinctrl/intel/pinctrl-intel.h +2 -1
 	unsigned int features;
 	unsigned int pin_base;
+	size_t npins;
 	unsigned int gpp_size;
 	unsigned int gpp_num_padown_regs;
-	size_t npins;
 	const struct intel_padgroup *gpps;
 	size_t ngpps;
 	const unsigned int *pad_map;
+

Unrelated whitespace change?

In any case,

Acked-by Mika Westerberg <[email protected]>
author
#3 lore raw

Re: [PATCH v1 2/2] pinctrl: intel: Move npins closer to pin_base in struct intel_community

Quoted 34 lines · Mika Westerberg
Quoted 33 lines · Andy Shevchenko

It's common across the drivers to use the (pin_base, npins) pair to describe community characteristics. Thus, move them in the struct intel_community to be closer to each other.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-intel.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pinctrl/intel/pinctrl-intel.h +2 -1
index 058bf2b6d9f0e..bd653f2a07382 100644
@@ -94,12 +94,12 @@ enum {
  * @ie_offset: Register offset of GPI_IE from @regs.
  * @features: Additional features supported by the hardware
  * @pin_base: Starting pin of pins in this community
+ * @npins: Number of pins in this community
  * @gpp_size: Maximum number of pads in each group, such as GPI_IS, GPI_IE,
  *            PADCFGLOCK, HOSTSW_OWN. Used when @gpps is %NULL.
  * @gpp_num_padown_regs: Number of pad registers each pad group consumes at
  *			 minimum. Use %0 if the number of registers can be
  *			 determined by the size of the group.
- * @npins: Number of pins in this community
  * @gpps: Pad groups if the controller has variable size pad groups
  * @ngpps: Number of pad groups in this community
  * @pad_map: Optional non-linear mapping of the pads

@@ -121,12 +121,13 @@ struct intel_community {
 	unsigned int ie_offset;
 	unsigned int features;
 	unsigned int pin_base;
+	size_t npins;
 	unsigned int gpp_size;
Quoted 8 lines

drivers/pinctrl/intel/pinctrl-intel.h struct intel_community { · line 130

Quoted 6 lines
drivers/pinctrl/intel/pinctrl-intel.h +1 -1
 	unsigned int gpp_num_padown_regs;
-	size_t npins;
 	const struct intel_padgroup *gpps;
 	size_t ngpps;
 	const unsigned int *pad_map;
+

Unrelated whitespace change?

Not so. I can add justification to commit message.

Quoted 3 lines

In any case,

Acked-by Mika Westerberg <[email protected]>

Thanks.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#4 lore raw

Re: [PATCH v1 2/2] pinctrl: intel: Move npins closer to pin_base in struct intel_community

Quoted 44 lines · Andy Shevchenko
Quoted 34 lines · Mika Westerberg
Quoted 33 lines · Andy Shevchenko

It's common across the drivers to use the (pin_base, npins) pair to describe community characteristics. Thus, move them in the struct intel_community to be closer to each other.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-intel.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pinctrl/intel/pinctrl-intel.h +2 -1
index 058bf2b6d9f0e..bd653f2a07382 100644
@@ -94,12 +94,12 @@ enum {
  * @ie_offset: Register offset of GPI_IE from @regs.
  * @features: Additional features supported by the hardware
  * @pin_base: Starting pin of pins in this community
+ * @npins: Number of pins in this community
  * @gpp_size: Maximum number of pads in each group, such as GPI_IS, GPI_IE,
  *            PADCFGLOCK, HOSTSW_OWN. Used when @gpps is %NULL.
  * @gpp_num_padown_regs: Number of pad registers each pad group consumes at
  *			 minimum. Use %0 if the number of registers can be
  *			 determined by the size of the group.
- * @npins: Number of pins in this community
  * @gpps: Pad groups if the controller has variable size pad groups
  * @ngpps: Number of pad groups in this community
  * @pad_map: Optional non-linear mapping of the pads

@@ -121,12 +121,13 @@ struct intel_community {
 	unsigned int ie_offset;
 	unsigned int features;
 	unsigned int pin_base;
+	size_t npins;
 	unsigned int gpp_size;
Quoted 8 lines

drivers/pinctrl/intel/pinctrl-intel.h struct intel_community { · line 130

Quoted 6 lines
drivers/pinctrl/intel/pinctrl-intel.h +1 -1
 	unsigned int gpp_num_padown_regs;
-	size_t npins;
 	const struct intel_padgroup *gpps;
 	size_t ngpps;
 	const unsigned int *pad_map;
+

Unrelated whitespace change?

Quoted 7 lines

Not so. I can add justification to commit message.

Quoted 3 lines

In any case,

Acked-by Mika Westerberg <[email protected]>

Thanks.

Both pushed to my review and testing queue, thanks!

Second one with slightly updated commit message to reflect blank line change.

Signature · 2 lines
With Best Regards,
Andy Shevchenko