add mtk matrix keypad driver for keypad on MTK SoC
Subsystems (4)
PATCH v5 1/1 add mtk matrix keypad driver for keypad on MTK SoC
Change since v4:
- remove extra space and redundant lines
- remove disable_irq_nosync and enable_irq in irq handler
- put defconfig as a single patch
- unified device properties interface for ACPI and device trees
- fixed other issue according reviewer comments
fengping.yu (3):
dt-bindings: add matrix keypad documentation
arm64: configs: defconfig: enable mtk keypad config
drivers: input: keyboard: add mtk keypad driver
.../devicetree/bindings/input/mtk-kpd.txt | 61 +++++ arch/arm64/configs/defconfig | 1 + drivers/input/keyboard/Kconfig | 9 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mtk-kpd.c | 242 ++++++++++++++++++ 5 files changed, 314 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt create mode 100644 drivers/input/keyboard/mtk-kpd.c
--
2.18.0
PATCH v5 1/3 dt-bindings: add matrix keypad documentation
From: "fengping.yu" <[email protected]>
--- .../devicetree/bindings/input/mtk-kpd.txt | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt
Documentation/devicetree/bindings/input/mtk-kpd.txt new file +61 -0
@@ -0,0 +1,61 @@ +* Mediatek's Keypad Controller device tree binding + +Mediatek's Keypad controller is used to interface a SoC with a matrix-type +keypad device. The keypad controller supports multiple row and column lines. +A key can be placed at each intersection of a unique row and a unique column. +The keypad controller can sense a key-press and key-release and report the +event using a interrupt to the cpu. + +Required properties: +- compatible should contain: + * "mediatek,kp" for common keypad + * "mediatek,mt6779-keypad" for specific keypad chip + +- reg: The base address of the Keypad register bank. + +- interrupts: A single interrupt specifier. + +- mediatek,debounce-us: Debounce interval in microseconds, maximum value + is 256000 microseconds. + +- keypad,num-rows: Number of row lines connected to the keypad controller, it is + not equal to PCB rows number, instead you should add required value for each IC. + +- keypad,num-columns: Number of column lines connected to the keypad controller, + it is not equal to PCB columns number, instead you should add required value + for each IC. + +- linux,keymap: The keymap for keys as described in the binding document + devicetree/bindings/input/matrix-keymap.txt. + +- pinctrl: Should specify pin control groups used for this controller. + See ../pinctrl/pinctrl-bindings.txt for details. + +- clocks: Must contain one entry, for the module clock. + See ../clocks/clock-bindings.txt for details. + +- clock-names: Names of the clocks listed in clocks property in the same order. + +Optional Properties: +- wakeup-source: use any event on keypad as wakeup event. + +Example: + + keypad: kp@10010000 { + compatible = "mediatek,kp"; + reg = <0 0x10010000 0 0x1000>; + wakeup-source; + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; + clocks = <&clk26m>; + clock-names = "kpd"; + }; + + &keypad { + mediatek,debounce-us = <32000>; + keypad,num-rows = <8>; + keypad,num-columns = <9>; + linux,keymap = < MATRIX_KEY(0x00, 0x00, KEY_VOLUMEDOWN) >; + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&kpd_gpios_def_cfg>; + };
Signature · 5 lines
2.18.0 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Re: [PATCH v5 1/3] dt-bindings: add matrix keypad documentation
Hi Fengping,
Quoted 5 lines · Fengping yu
From: "fengping.yu" <[email protected]>
Signed-off-by fengping.yu <[email protected]>--- .../devicetree/bindings/input/mtk-kpd.txt | 61 +++++++++++++++++++
Pls don't add new binding docs as .txt instead you should use the new yaml schema.
Regards,
Marco
Quoted 72 lines
1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txtDocumentation/devicetree/bindings/input/mtk-kpd.txt new file +61
-0@@ -0,0 +1,61 @@ +* Mediatek's Keypad Controller device tree binding + +Mediatek's Keypad controller is used to interface a SoC with a matrix-type +keypad device. The keypad controller supports multiple row and column lines. +A key can be placed at each intersection of a unique row and a unique column. +The keypad controller can sense a key-press and key-release and report the +event using a interrupt to the cpu. + +Required properties: +- compatible should contain: + * "mediatek,kp" for common keypad + * "mediatek,mt6779-keypad" for specific keypad chip + +- reg: The base address of the Keypad register bank. + +- interrupts: A single interrupt specifier. + +- mediatek,debounce-us: Debounce interval in microseconds, maximum value + is 256000 microseconds. + +- keypad,num-rows: Number of row lines connected to the keypad controller, it is + not equal to PCB rows number, instead you should add required value for each IC. + +- keypad,num-columns: Number of column lines connected to the keypad controller, + it is not equal to PCB columns number, instead you should add required value + for each IC. + +- linux,keymap: The keymap for keys as described in the binding document + devicetree/bindings/input/matrix-keymap.txt. + +- pinctrl: Should specify pin control groups used for this controller. + See ../pinctrl/pinctrl-bindings.txt for details. + +- clocks: Must contain one entry, for the module clock. + See ../clocks/clock-bindings.txt for details. + +- clock-names: Names of the clocks listed in clocks property in the same order. + +Optional Properties: +- wakeup-source: use any event on keypad as wakeup event. + +Example: + + keypad: kp@10010000 { + compatible = "mediatek,kp"; + reg = <0 0x10010000 0 0x1000>; + wakeup-source; + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; + clocks = <&clk26m>; + clock-names = "kpd"; + }; + + &keypad { + mediatek,debounce-us = <32000>; + keypad,num-rows = <8>; + keypad,num-columns = <9>; + linux,keymap = < MATRIX_KEY(0x00, 0x00, KEY_VOLUMEDOWN) >; + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&kpd_gpios_def_cfg>; + };Signature · 1 line
2.18.0
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH v5 2/3 arm64: configs: defconfig: enable mtk keypad config
In reply to Fengping yuFrom: "fengping.yu" <[email protected]>
--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -316,6 +316,7 @@ CONFIG_KEYBOARD_GPIO=y CONFIG_KEYBOARD_SNVS_PWRKEY=m CONFIG_KEYBOARD_IMX_SC_KEY=m CONFIG_KEYBOARD_CROS_EC=y +CONFIG_KEYBOARD_MTK_KPD=y CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ATMEL_MXT=m CONFIG_INPUT_MISC=y
Signature · 5 lines
2.18.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v5 2/3] arm64: configs: defconfig: enable mtk keypad config
Quoted 3 lines · Fengping yu
From: "fengping.yu" <[email protected]>
Signed-off-by fengping.yu <[email protected]>
Nit, this should be the last patch in this series. Also you need to add a few comments wihtin the commit message. Empty commit messages are not allowed.
Regards,
Marco
Quoted 18 lines
--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)arch/arm64/configs/defconfig +1
-0@@ -316,6 +316,7 @@ CONFIG_KEYBOARD_GPIO=y CONFIG_KEYBOARD_SNVS_PWRKEY=m CONFIG_KEYBOARD_IMX_SC_KEY=m CONFIG_KEYBOARD_CROS_EC=y +CONFIG_KEYBOARD_MTK_KPD=y CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ATMEL_MXT=m CONFIG_INPUT_MISC=ySignature · 1 line
2.18.0
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH v5 3/3 drivers: input: keyboard: add mtk keypad driver
In reply to Fengping yuFrom: "fengping.yu" <[email protected]>
--- drivers/input/keyboard/Kconfig | 9 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mtk-kpd.c | 242 +++++++++++++++++++++++++++++++ 3 files changed, 252 insertions(+) create mode 100644 drivers/input/keyboard/mtk-kpd.c
drivers/input/keyboard/Kconfig +9 -0
@@ -772,6 +772,15 @@ config KEYBOARD_BCM To compile this driver as a module, choose M here: the module will be called bcm-keypad. +config KEYBOARD_MTK_KPD + tristate "MediaTek Keypad Support" + help + Say Y here if you want to use the keypad. + If unuse, say N. + + To compile this driver as a module, choose M here: the + module will be called mtk-kpd. + config KEYBOARD_MTK_PMIC tristate "MediaTek PMIC keys support" depends on MFD_MT6397
drivers/input/keyboard/Makefile +1 -0
@@ -42,6 +42,7 @@ obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o obj-$(CONFIG_KEYBOARD_MCS) += mcs_touchkey.o obj-$(CONFIG_KEYBOARD_MPR121) += mpr121_touchkey.o +obj-$(CONFIG_KEYBOARD_MTK_KPD) += mtk-kpd.o obj-$(CONFIG_KEYBOARD_MTK_PMIC) += mtk-pmic-keys.o obj-$(CONFIG_KEYBOARD_NEWTON) += newtonkbd.o obj-$(CONFIG_KEYBOARD_NOMADIK) += nomadik-ske-keypad.o
drivers/input/keyboard/mtk-kpd.c new file +242 -0
242 lines not on this page · raw message
Signature · 5 lines
2.18.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v5 3/3] drivers: input: keyboard: add mtk keypad driver
Hi Fengping,
Quoted 1 line · Fengping yu
From: "fengping.yu" <[email protected]>
Missing commit message?
Quoted 13 lines
Signed-off-by fengping.yu <[email protected]>--- drivers/input/keyboard/Kconfig | 9 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mtk-kpd.c | 242 +++++++++++++++++++++++++++++++ 3 files changed, 252 insertions(+) create mode 100644 drivers/input/keyboard/mtk-kpd.cdrivers/input/keyboard/Kconfig +0
-0
drivers/input/keyboard/Kconfig config KEYBOARD_BCM · line 776
Quoted 5 lines
drivers/input/keyboard/Kconfig +2
-0@@ -772,6 +772,15 @@ config KEYBOARD_BCM To compile this driver as a module, choose M here: the module will be called bcm-keypad. +config KEYBOARD_MTK_KPD + tristate "MediaTek Keypad Support"
I think here are some missing deps.
drivers/input/keyboard/Kconfig config KEYBOARD_BCM · line 778
Quoted 2 lines
drivers/input/keyboard/Kconfig +2
-0+ help + Say Y here if you want to use the keypad.
I would write:
"Say Y here if you want to use the keypad on MediaTek SoCs"
drivers/input/keyboard/Kconfig config KEYBOARD_BCM · line 779
Quoted 1 line
drivers/input/keyboard/Kconfig +1
-0+ If unuse, say N.
s/unuse/unsure/
Quoted 31 lines
drivers/input/keyboard/Kconfig +4
-0+ + To compile this driver as a module, choose M here: the + module will be called mtk-kpd. + config KEYBOARD_MTK_PMIC tristate "MediaTek PMIC keys support" depends on MFD_MT6397drivers/input/keyboard/Makefile +1
-0@@ -42,6 +42,7 @@ obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o obj-$(CONFIG_KEYBOARD_MCS) += mcs_touchkey.o obj-$(CONFIG_KEYBOARD_MPR121) += mpr121_touchkey.o +obj-$(CONFIG_KEYBOARD_MTK_KPD) += mtk-kpd.o obj-$(CONFIG_KEYBOARD_MTK_PMIC) += mtk-pmic-keys.o obj-$(CONFIG_KEYBOARD_NEWTON) += newtonkbd.o obj-$(CONFIG_KEYBOARD_NOMADIK) += nomadik-ske-keypad.odrivers/input/keyboard/mtk-kpd.c new file +6
-0@@ -0,0 +1,242 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2019 MediaTek Inc. +* Author Terry Chang <[email protected]> +*/ +#include <linux/clk.h>
drivers/input/keyboard/mtk-kpd.c line 16
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+#include <linux/gpio.h> +#include <linux/init.h> +#include <linux/input/matrix_keypad.h> +#include <linux/interrupt.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/of_address.h> +#include <linux/of_irq.h> +#include <linux/pinctrl/consumer.h> +#include <linux/platform_device.h>
Pls, check if all includes are needed.
Quoted 7 lines
drivers/input/keyboard/mtk-kpd.c new file +7
-0+ +#define KPD_NAME "mtk-kpd" + +#define KP_MEM 0x0004 +#define KP_DEBOUNCE 0x0018 + +#define KPD_DEBOUNCE_MASK GENMASK(13, 0)
drivers/input/keyboard/mtk-kpd.c line 33
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+#define KPD_DEBOUNCE_MAX 256000 +#define KPD_NUM_MEMS 5 +#define KPD_NUM_BITS 136/* 4 * 32 + 8 MEM5 only use 8 BITS */ +#define BITS_TO_U32 (nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u32)) + +struct mtk_keypad { +struct input_dev *input_dev; +struct clk *clk; +void __iomem *base; +unsigned int irqnr;
You don't need the irqnr here.
drivers/input/keyboard/mtk-kpd.c line 43
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+bool wakeup; +u32 key_debounce; +u32 n_rows; +u32 n_cols; +DECLARE_BITMAP (keymap_state,KPD_NUM_BITS ); +}; + +static irqreturn_t kpd_irq_handler (int irq,void *dev_id) +{ +/* use _nosync to avoid deadlock */
What did you mean by this comment?
drivers/input/keyboard/mtk-kpd.c line 52
Quoted 9 lines
drivers/input/keyboard/mtk-kpd.c new file +9
-0+struct mtk_keypad *keypad = dev_id; +unsigned short *keycode = keypad->input_dev->keycode; +DECLARE_BITMAP (new_state,KPD_NUM_BITS ); +DECLARE_BITMAP (change,KPD_NUM_BITS ); +int bit_nr; +int pressed; +unsigned short code; + +memcpy_fromio (new_state, keypad->base +KP_MEM ,KPD_NUM_MEMS );
As I written below, pls make use of the regmap() framework.
drivers/input/keyboard/mtk-kpd.c line 57
Quoted 4 lines
drivers/input/keyboard/mtk-kpd.c new file +4
-0+bitmap_xor (change, new_state, keypad->keymap_state,KPD_NUM_BITS ); + +for_each_set_bit (bit_nr, change,KPD_NUM_BITS ) { + pressed =test_bit (bit_nr, new_state) ==0U ;
I would write !test_bit() and add a comment /* pressed == 0 */
drivers/input/keyboard/mtk-kpd.c line 61
Quoted 4 lines
drivers/input/keyboard/mtk-kpd.c new file +4
-0+dev_dbg (&keypad->input_dev->dev,"%s" , + pressed ?"pressed" :"released" ); + +/* per 32bit register only use low 16bit as keypad mem register */
Pls, align the comment.
Quoted 13 lines
drivers/input/keyboard/mtk-kpd.c new file +13
-0+ code = keycode[bit_nr -16 * (BITS_TO_U32 (bit_nr) -1 )]; + +input_report_key (keypad->input_dev, code, pressed); +input_sync (keypad->input_dev); + +dev_dbg (&keypad->input_dev->dev, +"report Linux keycode = %d\n" , code); + } + +bitmap_copy (keypad->keymap_state, new_state,KPD_NUM_BITS ); + +return IRQ_HANDLED ; +}
drivers/input/keyboard/mtk-kpd.c line 84
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+ +static int kpd_get_dts_info (struct mtk_keypad *keypad) +{ +int ret; +struct device *dev = keypad->input_dev->dev.parent; +struct device_node *node = dev->of_node; + + ret =matrix_keypad_parse_properties (dev, &keypad->n_rows, + &keypad->n_cols); +
Unnecessary newline.
Quoted 8 lines
drivers/input/keyboard/mtk-kpd.c new file +8
-0+if (ret) { +dev_err (dev,"Failed to parse keypad params\n" ); +return ret; + } + + ret =device_property_read_u32 (dev,"mediatek,debounce-us" , + &keypad->key_debounce); +if (ret) {
drivers/input/keyboard/mtk-kpd.c line 102
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+dev_err (dev,"Failed to read mediatek debounce time\n" ); +return ret; + } + +if (keypad->key_debounce >KPD_DEBOUNCE_MAX ) { +dev_err (dev,"Debounce time exceeds the maximum allowed time 256ms\n" ); +return -EINVAL ; + } + + keypad->wakeup =device_property_read_bool (node,"wakeup-source" );
Did you test this? It should be:
device_property_read_bool(dev, "wakeup-source");
Quoted 32 lines
drivers/input/keyboard/mtk-kpd.c new file +32
-0+ +dev_dbg (dev,"n_row=%d n_col=%d debounce=%d\n" , + keypad->n_rows, keypad->n_cols, + keypad->key_debounce); + +return 0 ; +} + +static int kpd_pdrv_probe (struct platform_device *pdev) +{ +struct mtk_keypad *keypad; +struct pinctrl *keypad_pinctrl; +struct pinctrl_state *kpd_default; +int ret; + + keypad =devm_kzalloc (&pdev->dev,sizeof (*keypad),GFP_KERNEL ); +if (!keypad) +return -ENOMEM ; + +bitmap_fill (keypad->keymap_state,KPD_NUM_BITS ); + + keypad->input_dev =devm_input_allocate_device (&pdev->dev); +if (!keypad->input_dev) { +dev_err (&pdev->dev,"Failed to allocate input dev\n" ); +return -ENOMEM ; + } + + keypad->input_dev->name =KPD_NAME ; + keypad->input_dev->id.bustype =BUS_HOST ; + + ret =kpd_get_dts_info (keypad); +if (ret) {
drivers/input/keyboard/mtk-kpd.c line 144
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+dev_err (&pdev->dev,"Failed to get dts info\n" ); +return ret; + } + + ret =matrix_keypad_build_keymap (NULL ,NULL , + keypad->n_rows, + keypad->n_cols, +NULL , + keypad->input_dev); +
Unnecessary Newline.
Quoted 7 lines
drivers/input/keyboard/mtk-kpd.c new file +7
-0+if (ret) { +dev_err (&pdev->dev,"Failed to build keymap\n" ); +return ret; + } + +input_set_drvdata (keypad->input_dev, keypad); +
drivers/input/keyboard/mtk-kpd.c line 161
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+ keypad->base =devm_platform_ioremap_resource (pdev,0 ); +if (IS_ERR (keypad->base)) { +dev_err (&pdev->dev,"Failed to get resource and iomap keypad\n" ); +return PTR_ERR (keypad->base); + } + +if (keypad->key_debounce >KPD_DEBOUNCE_MAX ) { +dev_err (&pdev->dev,"Invalid debounce time value.\n" ); +return -EINVAL ; + }
This check is already done withn the kpd_get_dts_info(). I would say to drop the kpd_get_dts_info() function and probe it all within the probe() function. It is not that much data you need and it removes the wakupsrc var fromt the driver state. Furthermore devm_platform_ioremap_resource() and devm_clk_get() parses the DT too. I would parse the deps before you setup and fill the input_dev to fail early.
drivers/input/keyboard/mtk-kpd.c line 164
Quoted 2 lines
drivers/input/keyboard/mtk-kpd.c new file +2
-0+writew (keypad->key_debounce *32 /1000 &KPD_DEBOUNCE_MASK , + keypad->base +KP_DEBOUNCE );
Also I would avoid this completely and instead use the regmap() interface which has mmio support.
drivers/input/keyboard/mtk-kpd.c line 175
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+ keypad->clk =devm_clk_get (&pdev->dev,"kpd" ); +if (IS_ERR (keypad->clk)) { +return PTR_ERR (keypad->clk); + } + + ret =clk_prepare_enable (keypad->clk); +if (ret) { +dev_err (&pdev->dev,"cannot prepare/enable keypad clock\n" ); +return ret; + }
Nit you can add a devm_add_action_or_reset() here to avoid the goto:
error handling.
Quoted 6 lines
drivers/input/keyboard/mtk-kpd.c new file +6
-0+ keypad_pinctrl =devm_pinctrl_get (&pdev->dev); +if (IS_ERR (keypad_pinctrl)) { + ret =PTR_ERR (keypad_pinctrl); + goto disable_kpd_clk; + } +
drivers/input/keyboard/mtk-kpd.c line 192
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+ kpd_default =pinctrl_lookup_state (keypad_pinctrl,"default" ); +if (IS_ERR (kpd_default)) { +dev_err (&pdev->dev,"No default pinctrl state\n" ); + ret =PTR_ERR (kpd_default); + goto disable_kpd_clk; + } + +pinctrl_select_state (keypad_pinctrl, kpd_default); + + keypad->irqnr =platform_get_irq (pdev,0 );
As writting above, the irqnr can be a local var.
drivers/input/keyboard/mtk-kpd.c line 201
Quoted 9 lines
drivers/input/keyboard/mtk-kpd.c new file +9
-0+if (keypad->irqnr <0 ) { +dev_err (&pdev->dev,"Failed to get irq\n" ); + ret = -keypad->irqnr; + goto disable_kpd_clk; + } + + ret =devm_request_irq (&pdev->dev, keypad->irqnr, + kpd_irq_handler,0 , +KPD_NAME , keypad);
Why do you don't use the threaded irq [devm_request_threaded_irq()]?
Quoted 5 lines
drivers/input/keyboard/mtk-kpd.c new file +5
-0+if (ret) { +dev_err (&pdev->dev,"Failed to request IRQ#%d:%d\n" , + keypad->irqnr, ret); + goto disable_kpd_clk; + }
drivers/input/keyboard/mtk-kpd.c line 216
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+ + ret =input_register_device (keypad->input_dev); +if (ret) { +dev_err (&pdev->dev,"Failed to register device\n" ); + goto disable_kpd_clk; + } + +device_init_wakeup (&pdev->dev, keypad->wakeup); + +platform_set_drvdata (pdev, keypad);
Where do you need the drvdata? It seems useless.
drivers/input/keyboard/mtk-kpd.c line 227
Quoted 10 lines
drivers/input/keyboard/mtk-kpd.c new file +10
-0+return 0 ; + +disable_kpd_clk: +clk_disable_unprepare (keypad->clk); +return ret; +} + +static const struct of_device_id kpd_of_match[] = { + {.compatible ="mediatek,kp" }, + {}
Nit { }
or
{ /*sentinel*/ }
drivers/input/keyboard/mtk-kpd.c line 223
Quoted 1 line
drivers/input/keyboard/mtk-kpd.c new file +1
-0+};
MODULE_DEVICE_TABLE(of, kpd_of_match);
drivers/input/keyboard/mtk-kpd.c line 237
Quoted 9 lines
drivers/input/keyboard/mtk-kpd.c new file +9
-0+ +static struct platform_driver kpd_pdrv = { + .probe = kpd_pdrv_probe, + .driver = { + .name =KPD_NAME , + .of_match_table = kpd_of_match, + }, +}; +
Unnecessary newline.
Regards,
Marco
Quoted 5 lines
drivers/input/keyboard/mtk-kpd.c new file +5
-0+module_platform_driver (kpd_pdrv); + +MODULE_AUTHOR ("Mediatek Corporation" ); +MODULE_DESCRIPTION ("MTK Keypad (KPD) Driver" ); +MODULE_LICENSE ("GPL" );
Re: [PATCH v5 3/3] drivers: input: keyboard: add mtk keypad driver
In reply to Fengping yuQuoted 2 lines · Fengping yu
From: "fengping.yu" <[email protected]>
This misses the commit message. It's a show stopper for such patches. Read this [1].
[1]: https://chris.beams.io/posts/git-commit/
...
drivers/input/keyboard/mtk-kpd.c line 24
Quoted 2 lines
drivers/input/keyboard/mtk-kpd.c new file +2
-0+#define KPD_DEBOUNCE_MASK GENMASK(13, 0) +#define KPD_DEBOUNCE_MAX 256000
Is there any unit in which debounce time is being measured? Add it as a suffix to the definition, if it's possible.
...
Quoted 1 line
+#define
BITS_TO_U32(nr)DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u32))
This already defined in bits.h.
...
drivers/input/keyboard/mtk-kpd.c line 154
Quoted 4 lines
drivers/input/keyboard/mtk-kpd.c new file +3
-0+ keypad->base =devm_platform_ioremap_resource (pdev,0 ); +if (IS_ERR (keypad->base)) { +dev_err (&pdev->dev,"Failed to get resource and iomap keypad\n" );
This is duplicate noisy message, please remove.
Quoted 2 lines
(quoted diff) +2
-0+ return PTR_ERR(keypad->base); + }
...
drivers/input/keyboard/mtk-kpd.c line 163
Quoted 1 line
drivers/input/keyboard/mtk-kpd.c new file +1
-0+ writew(keypad->key_debounce * 32 / 1000 & KPD_DEBOUNCE_MASK,
Perhaps one pair of parentheses is needed to make logic clear.
(Yes, I remember I commented on this in earlier versions where it was many
parentheses around above calculations, but you have to use common sense as well)
Quoted 1 line
drivers/input/keyboard/mtk-kpd.c new file +1
-0+ keypad->base + KP_DEBOUNCE);
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Fengping,
Quoted 6 lines · Fengping yu
Change since v4:
- remove extra space and redundant lines
- removedisable_irq_nosyncandenable_irqin irq handler
- put defconfig as a single patch
- unified device properties interface for ACPI and device trees
This is a good changelog for reviewers.
Quoted 1 line
- fixed other issue according reviewer comments
This one is a bit useless..
Regards,
Marco
Quoted 17 lines
fengping.yu (3):
dt-bindings: add matrix keypad documentation
arm64: configs: defconfig: enable mtk keypad config
drivers: input: keyboard: add mtk keypad driver.../devicetree/bindings/input/mtk-kpd.txt | 61 +++++ arch/arm64/configs/defconfig | 1 + drivers/input/keyboard/Kconfig | 9 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mtk-kpd.c | 242 ++++++++++++++++++ 5 files changed, 314 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.txt create mode 100644 drivers/input/keyboard/mtk-kpd.c--
2.18.0
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |