Skip to contentSkip to conversation

tools-build-tweak-unused-value-workaround.patch removed from -mm tree

merged [email protected] 1 participant 1 message Apr 23, 2020

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: tools/build: tweak unused value workaround
has been removed from the -mm tree. Its filename was
tools-build-tweak-unused-value-workaround.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: George Burgess IV <[email protected]>
Subject: tools/build: tweak unused value workaround

Clang has -Wself-assign enabled by default under -Wall, which always gets -Werror'ed on this file, causing sync-compare-and-swap to be disabled by default. The generally-accepted way to spell "this value is intentionally unused," is casting it to void. This is accepted by both GCC and Clang with -Wall enabled: https://godbolt.org/z/qqZ9r3

---

 tools/build/feature/test-sync-compare-and-swap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/build/feature/test-sync-compare-and-swap.c renamed from tools/build/feature/test-sync-compare-and-swap.c~tools-build-tweak-unused-value-workaround +1 -1
@@ -7,7 +7,7 @@ int main(int argc, char *argv[])
 {
 	uint64_t old, new = argc;
 
-	argv = argv;
+	(void)argv;
 	do {
 		old = __sync_val_compare_and_swap(&x, 0, 0);
 	} while (!__sync_bool_compare_and_swap(&x, old, new));

_

Patches currently in -mm which might be from [email protected] are