Skip to contentSkip to conversation

package/rsync: annotate CVE-2017-16548

PATCH New Fabrice Fontaine 3 participants 6 messages Mar 1, 2020 – May 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rsync: annotate CVE-2017-16548

CVE-2017-165484 is misclassified (by our CVE tracker) as affecting version 3.1.3, while in fact it affects 3.1.2 and 3.1.3-development

---
 package/rsync/rsync.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/rsync/rsync.mk +4 -0
index 52875e428a..95d19a7f4c 100644
@@ -13,6 +13,10 @@ RSYNC_CONF_OPTS = \
 	--with-included-zlib=no \
 	--with-included-popt=no
 
+# CVE-2017-165484 is misclassified (by our CVE tracker) as affecting version 3.1.3,
+# while in fact it affects 3.1.2 and 3.1.3-development
+RSYNC_IGNORE_CVES += CVE-2017-16548
+
 ifeq ($(BR2_PACKAGE_ACL),y)
 RSYNC_DEPENDENCIES += acl
 else
Signature · 1 line
2.25.0
#1 lore raw

PATCH 1/1 package/rsync: annotate CVE-2017-16548

Hello,

I'm adding in Cc: Matthew Weber and Akshay Bhat for the interaction with NVD.

Also adding Titouan Christophe for the discussion about our script that does the CVE checking.

Quoted 13 lines · On Sun, 1 Mar 2020 20:27:27 +0100 Fabrice Fontaine…

CVE-2017-165484 is misclassified (by our CVE tracker) as affecting version 3.1.3, while in fact it affects 3.1.2 and 3.1.3-development

---
 package/rsync/rsync.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/rsync/rsync.mk +0 -0
index 52875e428a..95d19a7f4c 100644

package/rsync/rsync.mk RSYNC_CONF_OPTS = \ · line 18

Quoted 6 lines
package/rsync/rsync.mk +3 -0
@@ -13,6 +13,10 @@ RSYNC_CONF_OPTS = \
 	--with-included-zlib=no \
 	--with-included-popt=no
 
+# CVE-2017-165484 is misclassified (by our CVE tracker) as affecting version 3.1.3,
+# while in fact it affects 3.1.2 and 3.1.3-development
+RSYNC_IGNORE_CVES += CVE-2017-16548

Indeed commit 47a63d90e71d3e19e0e96052bb8c6b9cb140ecc1 which fixes this CVE is part of the 3.1.3 release. This means the NVD database is wrong.

Instead of doing a workaround in Buildroot, can we report this to the NVD maintainers ?

But now that I look at https://nvd.nist.gov/vuln/detail/CVE-2017-16548
I see that the affected versions are 3.1.2 and 3.1.3pre1. Even the latter is not correct: the commit was merged before the 3.1.3pre1 tag. In addition, I don't see this "pre1" information in the version information available in the JSON in format 1.0 we use.

Perhaps the JSON in format 1.1 has more detailed information, and we should switch to using JSON in format 1.1.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/rsync: annotate CVE-2017-16548

Quoted 35 lines · Thomas Petazzoni

Hello,

I'm adding in Cc: Matthew Weber and Akshay Bhat for the interaction with NVD.

Also adding Titouan Christophe for the discussion about our script that does the CVE checking.

Quoted 13 lines · On Sun, 1 Mar 2020 20:27:27 +0100 Fabrice Fontaine…

CVE-2017-165484 is misclassified (by our CVE tracker) as affecting version 3.1.3, while in fact it affects 3.1.2 and 3.1.3-development

---
 package/rsync/rsync.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/rsync/rsync.mk +0 -0
index 52875e428a..95d19a7f4c 100644

package/rsync/rsync.mk RSYNC_CONF_OPTS = \ · line 18

Quoted 6 lines
package/rsync/rsync.mk +3 -0
@@ -13,6 +13,10 @@ RSYNC_CONF_OPTS = \
      --with-included-zlib=no \
      --with-included-popt=no
 
+# CVE-2017-165484 is misclassified (by our CVE tracker) as affecting version 3.1.3,
+# while in fact it affects 3.1.2 and 3.1.3-development
+RSYNC_IGNORE_CVES += CVE-2017-16548

Indeed commit 47a63d90e71d3e19e0e96052bb8c6b9cb140ecc1 which fixes this CVE is part of the 3.1.3 release. This means the NVD database is wrong.

Quoted 2 lines

Instead of doing a workaround in Buildroot, can we report this to the NVD maintainers ?

Thanks for finding this. I have sent the below information to NVD, will post back once I hear more:
There is an error in the cpe version information for:
https://nvd.nist.gov/vuln/detail/CVE-2017-16548

The correct range should be:
From (excluding)
2.6.9
Up to (including)
3.1.2

Details:
Commit fixing the CVE:
https://git.samba.org/rsync.git/?p=rsync.git;a=commit;h=47a63d90e71d3e19e0e96052bb8c6b9cb140ecc1

Versions Containing fix:

$ git tag --contains 47a63d90e71d3e19e0e96052bb8c6b9cb140ecc1
v3.1.3
v3.1.3pre1

Commit introducing the CVE:

$ git log --oneline --diff-filter=A -- xattrs.c
16edf865 The improved --xattrs option is landing on the trunk.
Version introducing the CVE (excluding):
$ git -c 'versionsort.suffix=pre' tag --no-contains 16edf8659
--sort=-version:refname |head -1
v2.6.9

Thanks,
Akshay

#3 lore raw

PATCH 1/1 package/rsync: annotate CVE-2017-16548

Quoted 4 lines · On Fri, 24 Apr 2020 10:36:02 -0400 Akshay Bhat <[email protected]> wrote:

Thanks for finding this. I have sent the below information to NVD, will post back once I hear more:
There is an error in the cpe version information for:
https://nvd.nist.gov/vuln/detail/CVE-2017-16548

Wow, thanks a lot for sending this up to the NVD database maintainers!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/rsync: annotate CVE-2017-16548

Quoted 10 lines · Thomas Petazzoni
Quoted 4 lines · On Fri, 24 Apr 2020 10:36:02 -0400 Akshay Bhat <[email protected]> wrote:

Thanks for finding this. I have sent the below information to NVD, will post back once I hear more:
There is an error in the cpe version information for:
https://nvd.nist.gov/vuln/detail/CVE-2017-16548

Wow, thanks a lot for sending this up to the NVD database maintainers!

After a bit of back and forth with the NVD maintainers, the information has finally been updated:
https://nvd.nist.gov/vuln/detail/CVE-2017-16548

Thanks,
Akshay

#5 lore raw

PATCH 1/1 package/rsync: annotate CVE-2017-16548

Quoted 3 lines · On Fri, 1 May 2020 10:30:26 -0400 Akshay Bhat <[email protected]> wrote:

After a bit of back and forth with the NVD maintainers, the information has finally been updated:
https://nvd.nist.gov/vuln/detail/CVE-2017-16548

Thanks a lot for this work!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com