aarch32 compilation
cover aarch32 compilation
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/
When building with meson, requires series:
http://patches.dpdk.org/cover/68534/
[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.html
Ruifeng Wang (3):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header file
drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- lib/librte_eal/arm/include/rte_vect.h | 6 +++++- 3 files changed, 8 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/3 arch/arm: add vcopyq intrinsic for aarch32
vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic.
--- lib/librte_eal/arm/include/rte_vect.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
lib/librte_eal/arm/include/rte_vect.h +5 -1
@@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a)#endif -#if RTE_CC_IS_GNU && (GCC_VERSION <70000 ) +#if defined(RTE_ARCH_ARM ) || \ +(defined(RTE_ARCH_ARM64 ) &&RTE_CC_IS_GNU && (GCC_VERSION <70000 )) +/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32) +* On AArch64, this intrinsic is supported since GCC versioin 7. +*/ static inline uint32x4_t vcopyq_laneq_u32 (uint32x4_t a,const int lane_a,uint32x4_t b,const int lane_b)
Signature · 1 line
2.17.1
Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32
Quoted 8 lines · Ruifeng Wang
vcopyq_laneq_u32should be implemented for aarch32 which doesn't have the intrinsic.Fixes 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Gavin Hu <[email protected]>
This fixes build of examples/l3fwd for armv7.
PATCH 2/3 net/ixgbe: add support for aarch32
In reply to Ruifeng WangExpand vector PMD support to aarch32.
--- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx.h +2 -2
@@ -33,7 +33,7 @@#define RTE_IXGBE_DESCS_PER_LOOP 4 -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )#define RTE_IXGBE_RXQ_REARM_THRESH 32#define RTE_IXGBE_MAX_RX_BURST RTE_IXGBE_RXQ_REARM_THRESH#endif
@@ -117,7 +117,7 @@ struct ixgbe_rx_queue {uint8_t using_ipsec;/**< indicates that IPsec RX feature is in use */ #endif -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )uint16_t rxrearm_nb;/**< number of remaining to be re-armed */ uint16_t rxrearm_start;/**< the idx we start the re-arming from */ #endif
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: add support for aarch32
Quoted 23 lines · Ruifeng Wang
Expand vector PMD support to aarch32.
Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Gavin Hu <[email protected]>--- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ixgbe/ixgbe_rxtx.h +1
-1@@ -33,7 +33,7 @@#define RTE_IXGBE_DESCS_PER_LOOP 4 -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )#define RTE_IXGBE_RXQ_REARM_THRESH 32#define RTE_IXGBE_MAX_RX_BURST RTE_IXGBE_RXQ_REARM_THRESH#endif
drivers/net/ixgbe/ixgbe_rxtx.h struct ixgbe_rx_queue { · line 123
Quoted 8 lines
drivers/net/ixgbe/ixgbe_rxtx.h +1
-1@@ -117,7 +117,7 @@ struct ixgbe_rx_queue {uint8_t using_ipsec;/**< indicates that IPsec RX feature is in use */ #endif -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )uint16_t rxrearm_nb;/**< number of remaining to be re-armed */ uint16_t rxrearm_start;/**< the idx we start the re-arming from */ #endif
This is not enough for Make build, since it doesn't compile 'ixgbe_rxtx_vec_neon.c' for 'RTE_ARCH_ARM', it needs to be updated.
btw, also should IXGBE_PMD enabled by default 'defconfig_arm-armv7a-linuxapp-gcc'? Which is by default disabled currently.
Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: add support for aarch32
Quoted 44 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, May 1, 2020 11:00 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; Honnappa Nagarahalli <[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: add support for aarch32Quoted 13 lines · Ruifeng Wang
Expand vector PMD support to aarch32.
Signed-off-by Ruifeng Wang <[email protected]>Reviewed-by Gavin Hu <[email protected]>--- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/net/ixgbe/ixgbe_rxtx.hindex20a8b291d..7e09291b2100644drivers/net/ixgbe/ixgbe_rxtx.h line 39
Quoted 8 lines
drivers/net/ixgbe/ixgbe_rxtx.h +2
-1@@ -33,7 +33,7 @@#define RTE_IXGBE_DESCS_PER_LOOP 4 -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || +defined(RTE_ARCH_ARM )#define RTE_IXGBE_RXQ_REARM_THRESH 32#define RTE_IXGBE_MAX_RX_BURST
RTE_IXGBE_RXQ_REARM_THRESHdrivers/net/ixgbe/ixgbe_rxtx.h struct ixgbe_rx_queue { · line 122
Quoted 8 lines
drivers/net/ixgbe/ixgbe_rxtx.h +2
-0#endif @@ -117,7 +117,7 @@ struct ixgbe_rx_queue {uint8_t using_ipsec;/**< indicates that IPsec RX feature is in use */ #endif -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || +defined(RTE_ARCH_ARM )uint16_t rxrearm_nb;/**< number of remaining to be re- armed */
Quoted 9 lines
drivers/net/ixgbe/ixgbe_rxtx.h struct ixgbe_rx_queue { · line 123
Quoted 1 line
drivers/net/ixgbe/ixgbe_rxtx.h +0
-0uint16_t rxrearm_start;/**< the idx we start the re-arming from */
Quoted 2 lines
#endif
This is not enough for Make build, since it doesn't compile '
ixgbe_rxtx_vec_neon.c' for 'RTE_ARCH_ARM', it needs to be updated.
Agreed. Will update Makefile to include this.
Quoted 3 lines
btw, also should
IXGBE_PMDenabled by default 'defconfig_arm-armv7a- linuxapp-gcc'? Which is by default disabled currently.
Yes. We can enable IXGBE_PMD by default since it now compiles. Will change it in next version.
PATCH 3/3 net/ixgbe: fix include of vector header file
In reply to Ruifeng WangThe include of 'arm_neon.h' causes issues to old gcc and aarch32. Including 'rte_vect.h' instead fixes these issues.
--- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c +1 -2
@@ -5,13 +5,12 @@#include <stdint.h> #include <rte_ethdev_driver.h> #include <rte_malloc.h> +#include <rte_vect.h> #include "ixgbe_ethdev.h" #include "ixgbe_rxtx.h" #include "ixgbe_rxtx_vec_common.h" -#include <arm_neon.h> -#pragma GCC diagnostic ignored "-Wcast-qual" static inline void
Signature · 1 line
2.17.1
Quoted 9 lines · Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/When building with meson, requires series:
http://patches.dpdk.org/cover/68534/
Quoted 9 lines
[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.htmlRuifeng Wang (3):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header file
Not directly related to this patch but since you are fixing aarch32 compilation, I am getting following -Wcast-align warnings [1] while cross building with:
arm-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0
[1].../lib/librte_eal/linux/eal_vfio_mp_sync.c: In function ‘vfio_mp_primary’:.../lib/librte_eal/linux/eal_vfio_mp_sync.c:31:28: warning: cast increases required alignment of target type [-Wcast-align]
31 | struct vfio_mp_param *r = (struct vfio_mp_param *)reply.param;
| ^.../lib/librte_eal/linux/eal_vfio_mp_sync.c:33:3: warning: cast increases required alignment of target type [-Wcast-align]
33 | (const struct vfio_mp_param *)msg->param;
| ^.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_open_group_fd’:.../lib/librte_eal/linux/eal_vfio.c:269:28: warning: cast increases required alignment of target type [-Wcast-align]
269 | struct vfio_mp_param *p = (struct vfio_mp_param *)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:316:7: warning: cast increases required alignment of target type [-Wcast-align]
316 | p = (struct vfio_mp_param *)mp_rep->param;
| ^
CC eal_common_class.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_sync_default_container’:.../lib/librte_eal/linux/eal_vfio.c:627:28: warning: cast increases required alignment of target type [-Wcast-align]
627 | struct vfio_mp_param *p = (struct vfio_mp_param *)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:652:7: warning: cast increases required alignment of target type [-Wcast-align]
652 | p = (struct vfio_mp_param *)mp_rep->param;
| ^.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_get_default_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1094:28: warning: cast increases required alignment of target type [-Wcast-align]
1094 | struct vfio_mp_param *p = (struct vfio_mp_param *)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:1116:7: warning: cast increases required alignment of target type [-Wcast-align]
1116 | p = (struct vfio_mp_param *)mp_rep->param;
| ^
CC eal_common_bus.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘rte_vfio_get_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1202:28: warning: cast increases required alignment of target type [-Wcast-align]
1202 | struct vfio_mp_param *p = (struct vfio_mp_param *)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:1248:7: warning: cast increases required alignment of target type [-Wcast-align]
1248 | p = (struct vfio_mp_param *)mp_rep->param;
| ^
Quoted 32 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, May 1, 2020 11:07 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; Honnappa Nagarahalli <[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 9 lines · Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/When building with meson, requires series:
http://patches.dpdk.org/cover/68534/Quoted 9 lines
[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.htmlRuifeng Wang (3):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header file
Quoted 4 lines
Not directly related to this patch but since you are fixing aarch32 compilation, I am getting following -Wcast-align warnings [1] while cross building with:
arm-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0
I got the same warnings with arm-linux-gnueabihf-gcc. The warnings spread in many different files. It is because armv7a/aarch32 puts strict align requirement.
We can first make it compile. And clean up such warnings in next step?
Quoted 49 lines
[1]
.../lib/librte_eal/linux/eal_vfio_mp_sync.c: In function ‘vfio_mp_primary’:.../lib/librte_eal/linux/eal_vfio_mp_sync.c:31:28: warning: cast increases required alignment of target type [-Wcast-align]
31 | structvfio_mp_param*r = (structvfio_mp_param*)reply.param;
| ^.../lib/librte_eal/linux/eal_vfio_mp_sync.c:33:3: warning: cast increases required alignment of target type [-Wcast-align]33 | (const struct vfio_mp_param *)msg->param; | ^
.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_open_group_fd’:.../lib/librte_eal/linux/eal_vfio.c:269:28: warning: cast increases required alignment of target type [-Wcast-align]
269 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:316:7: warning: cast increases required alignment of target type [-Wcast-align]
316 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_class.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_sync_default_container’:.../lib/librte_eal/linux/eal_vfio.c:627:28: warning: cast increases required alignment of target type [-Wcast-align]
627 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:652:7: warning: cast increases required alignment of target type [-Wcast-align]
652 | p = (structvfio_mp_param*)mp_rep->param;
| ^.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_get_default_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1094:28: warning: cast increases required alignment of target type [-Wcast-align]
1094 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:1116:7: warning: cast increases required alignment of target type [-Wcast-align]
1116 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_bus.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘rte_vfio_get_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1202:28: warning: cast increases required alignment of target type [-Wcast-align]
1202 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:1248:7: warning: cast increases required alignment of target type [-Wcast-align]
1248 | p = (structvfio_mp_param*)mp_rep->param;
| ^
Quoted 32 lines · Ruifeng Wang
Quoted 32 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, May 1, 2020 11:07 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; Honnappa Nagarahalli <[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 18 lines · Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/When building with meson, requires series:
http://patches.dpdk.org/cover/68534/[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.htmlRuifeng Wang (3):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header file
Quoted 7 lines
Quoted 4 lines
Not directly related to this patch but since you are fixing aarch32 compilation, I am getting following -Wcast-align warnings [1] while cross building with:
arm-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0I got the same warnings with arm-linux-gnueabihf-gcc. The warnings spread in many different files. It is because armv7a/aarch32 puts strict align requirement.
We can first make it compile. And clean up such warnings in next step?
Sure.
I thought it would break the build, aren't we using -Werror for the target?
Quoted 50 lines
Quoted 50 lines
[1]
.../lib/librte_eal/linux/eal_vfio_mp_sync.c: In function ‘vfio_mp_primary’:.../lib/librte_eal/linux/eal_vfio_mp_sync.c:31:28: warning: cast increases required alignment of target type [-Wcast-align]
31 | structvfio_mp_param*r = (structvfio_mp_param*)reply.param;
| ^.../lib/librte_eal/linux/eal_vfio_mp_sync.c:33:3: warning: cast increases required alignment of target type [-Wcast-align]33 | (const struct vfio_mp_param *)msg->param; | ^
.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_open_group_fd’:.../lib/librte_eal/linux/eal_vfio.c:269:28: warning: cast increases required alignment of target type [-Wcast-align]
269 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:316:7: warning: cast increases required alignment of target type [-Wcast-align]
316 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_class.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_sync_default_container’:.../lib/librte_eal/linux/eal_vfio.c:627:28: warning: cast increases required alignment of target type [-Wcast-align]
627 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:652:7: warning: cast increases required alignment of target type [-Wcast-align]
652 | p = (structvfio_mp_param*)mp_rep->param;
| ^.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_get_default_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1094:28: warning: cast increases required alignment of target type [-Wcast-align]
1094 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:1116:7: warning: cast increases required alignment of target type [-Wcast-align]
1116 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_bus.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘rte_vfio_get_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1202:28: warning: cast increases required alignment of target type [-Wcast-align]
1202 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
| ^.../lib/librte_eal/linux/eal_vfio.c:1248:7: warning: cast increases required alignment of target type [-Wcast-align]
1248 | p = (structvfio_mp_param*)mp_rep->param;
| ^
Quoted 51 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, May 6, 2020 6:14 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; Honnappa Nagarahalli <[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 8 lines · Ruifeng Wang
Quoted 8 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, May 1, 2020 11:07 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; HonnappaNagarahalli
Quoted 18 lines
Quoted 18 lines
<[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 13 lines · Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/When building with meson, requires series:
http://patches.dpdk.org/cover/68534/[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.htmlQuoted 8 lines
Quoted 8 lines
Quoted 5 lines
Ruifeng Wang (3):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header fileNot directly related to this patch but since you are fixing aarch32 compilation, I am getting following -Wcast-align warnings [1] while cross
building with:
Quoted 2 lines
Quoted 2 lines
arm-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0
Quoted 8 lines
Quoted 1 line
I got the same warnings with arm-linux-gnueabihf-gcc. The warnings
spread in many different files.
Quoted 2 lines
It is because armv7a/aarch32 puts strict align requirement. We can first make it compile. And clean up such warnings in next step?
Sure.
I thought it would break the build, aren't we using -Werror for the target?
Currently, "RTE_DEVEL_BUILD=n" is needed for armv7 build.
http://patches.dpdk.org/patch/62820/
Quoted 57 lines
Quoted 17 lines
Quoted 11 lines
[1]
.../lib/librte_eal/linux/eal_vfio_mp_sync.c: In function ‘vfio_mp_primary’:.../lib/librte_eal/linux/eal_vfio_mp_sync.c:31:28: warning: cast increases required alignment of target type [-Wcast-align]
31 | structvfio_mp_param*r = (structvfio_mp_param*)reply.param;
| ^.../lib/librte_eal/linux/eal_vfio_mp_sync.c:33:3: warning: cast increases required alignment of target type [-Wcast-align]Quoted 6 lines
33 | (const struct vfio_mp_param *)msg->param; | ^
.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_open_group_fd’:.../lib/librte_eal/linux/eal_vfio.c:269:28: warning: cast increases required alignment of target type [-Wcast-align]
269 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 7 lines
Quoted 7 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:316:7: warning: cast increases required alignment of target type [-Wcast-align]
316 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_class.o.../lib/librte_eal/linux/eal_vfio.c: In function‘vfio_sync_default_container’:
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio.c:627:28: warning: cast increases required alignment of target type [-Wcast-align]
627 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 6 lines
Quoted 6 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:652:7: warning: cast increases required alignment of target type [-Wcast-align]
652 | p = (structvfio_mp_param*)mp_rep->param;
| ^.../lib/librte_eal/linux/eal_vfio.c: In function‘vfio_get_default_container_fd’:
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio.c:1094:28: warning: cast increases required alignment of target type [-Wcast-align]
1094 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 10 lines
Quoted 10 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:1116:7: warning: cast increases required alignment of target type [-Wcast-align]
1116 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_bus.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘rte_vfio_get_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1202:28: warning: cast increases required alignment of target type [-Wcast-align]
1202 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 5 lines
Quoted 5 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:1248:7: warning: cast increases required alignment of target type [-Wcast-align]
1248 | p = (structvfio_mp_param*)mp_rep->param;
| ^
Quoted 53 lines · Ruifeng Wang
Quoted 53 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, May 6, 2020 6:14 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; Honnappa Nagarahalli <[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 8 lines · Ruifeng Wang
Quoted 8 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, May 1, 2020 11:07 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; HonnappaNagarahalli
Quoted 18 lines
Quoted 18 lines
<[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 13 lines · Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/When building with meson, requires series:
http://patches.dpdk.org/cover/68534/[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.htmlQuoted 8 lines
Quoted 8 lines
Quoted 5 lines
Ruifeng Wang (3):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header fileNot directly related to this patch but since you are fixing aarch32 compilation, I am getting following -Wcast-align warnings [1] while cross
building with:
Quoted 3 lines
Quoted 2 lines
arm-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0
I got the same warnings with arm-linux-gnueabihf-gcc. The warnings
spread in many different files.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
It is because armv7a/aarch32 puts strict align requirement. We can first make it compile. And clean up such warnings in next step?
Sure.
I thought it would break the build, aren't we using -Werror for the target?
Currently, "RTE_DEVEL_BUILD=n" is needed for armv7 build.
http://patches.dpdk.org/patch/62820/
May be not.
I did able to build without "RTE_DEVEL_BUILD=n", while checking how :), found that "CONFIG_RTE_ARCH_STRICT_ALIGN=y" set in the armv7a config (defconfig_arm-armv7a-linux-gcc), seems explicitly added for these '-Wcast-align' warnings.
Overall to the point of the discussion, since this way or that, build is not broken with cast-align warnings, I am OK to fix them later gradually.
A side note is, I wonder if these 'RTE_DEVEL_BUILD' or 'CONFIG_RTE_ARCH_STRICT_ALIGN' reflected to the meson build, taking into account that make build is going away on 20.11, will we able to keep these functionalities in meson.
Quoted 59 lines
Quoted 58 lines
Quoted 4 lines
Quoted 4 lines
Quoted 14 lines
Quoted 8 lines
[1]
.../lib/librte_eal/linux/eal_vfio_mp_sync.c: In function ‘vfio_mp_primary’:.../lib/librte_eal/linux/eal_vfio_mp_sync.c:31:28: warning: cast increases required alignment of target type [-Wcast-align]
31 | structvfio_mp_param*r = (structvfio_mp_param*)reply.param;
| ^.../lib/librte_eal/linux/eal_vfio_mp_sync.c:33:3: warning: cast increases required alignment of target type [-Wcast-align]Quoted 6 lines
33 | (const struct vfio_mp_param *)msg->param; | ^
.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_open_group_fd’:.../lib/librte_eal/linux/eal_vfio.c:269:28: warning: cast increases required alignment of target type [-Wcast-align]
269 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 7 lines
Quoted 7 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:316:7: warning: cast increases required alignment of target type [-Wcast-align]
316 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_class.o.../lib/librte_eal/linux/eal_vfio.c: In function‘vfio_sync_default_container’:
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio.c:627:28: warning: cast increases required alignment of target type [-Wcast-align]
627 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 6 lines
Quoted 6 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:652:7: warning: cast increases required alignment of target type [-Wcast-align]
652 | p = (structvfio_mp_param*)mp_rep->param;
| ^.../lib/librte_eal/linux/eal_vfio.c: In function‘vfio_get_default_container_fd’:
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio.c:1094:28: warning: cast increases required alignment of target type [-Wcast-align]
1094 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 10 lines
Quoted 10 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:1116:7: warning: cast increases required alignment of target type [-Wcast-align]
1116 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_bus.o.../lib/librte_eal/linux/eal_vfio.c: In function ‘rte_vfio_get_container_fd’:.../lib/librte_eal/linux/eal_vfio.c:1202:28: warning: cast increases required alignment of target type [-Wcast-align]
1202 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 5 lines
Quoted 5 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:1248:7: warning: cast increases required alignment of target type [-Wcast-align]
1248 | p = (structvfio_mp_param*)mp_rep->param;
| ^
Quoted 84 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, May 6, 2020 10:15 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; Honnappa Nagarahalli <[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 8 lines · Ruifeng Wang
Quoted 8 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Wednesday, May 6, 2020 6:14 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; HonnappaNagarahalli
Quoted 46 lines
Quoted 46 lines
<[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 8 lines · Ruifeng Wang
Quoted 8 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Friday, May 1, 2020 11:07 PM
To: Ruifeng Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; Gavin Hu <[email protected]>; HonnappaNagarahalli
Quoted 24 lines
Quoted 24 lines
<[email protected]>; [email protected]; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 0/3] aarch32 compilationQuoted 18 lines · Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/When building with meson, requires series:
http://patches.dpdk.org/cover/68534/[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.htmlRuifeng Wang (3):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header fileQuoted 3 lines
Quoted 3 lines
Not directly related to this patch but since you are fixing aarch32 compilation, I am getting following -Wcast-align warnings [1] while cross
building with:
Quoted 3 lines
Quoted 2 lines
arm-linux-gcc.br_real (Buildroot 2020.02-00011-g7ea8a52) 9.3.0
I got the same warnings with arm-linux-gnueabihf-gcc. The warnings
spread in many different files.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
It is because armv7a/aarch32 puts strict align requirement. We can first make it compile. And clean up such warnings in next step?
Sure.
I thought it would break the build, aren't we using -Werror for the target?
Currently, "RTE_DEVEL_BUILD=n" is needed for armv7 build.
http://patches.dpdk.org/patch/62820/May be not.
I did able to build without "RTE_DEVEL_BUILD=n", while checking how :), found that "
CONFIG_RTE_ARCH_STRICT_ALIGN=y" set in the armv7a config (defconfig_arm-armv7a-linux-gcc), seems explicitly added for these '-Wcast- align' warnings.
Quoted 8 lines
Overall to the point of the discussion, since this way or that, build is not broken with cast-align warnings, I am OK to fix them later gradually.
A side note is, I wonder if these '
RTE_DEVEL_BUILD' or 'CONFIG_RTE_ARCH_STRICT_ALIGN' reflected to the meson build, taking into account that make build is going away on 20.11, will we able to keep these functionalities in meson.
Yes. There is a patch to enable meson build for armv7, and 'CONFIG_RTE_ARCH_STRICT_ALIGN' is added.
http://patches.dpdk.org/patch/69539/
Meson also provides option to set "werror".
The functionalities can be kept.
Quoted 62 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
[1]
.../lib/librte_eal/linux/eal_vfio_mp_sync.c: In function‘vfio_mp_primary’:
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio_mp_sync.c:31:28: warning: cast increases required alignment of target type [-Wcast-align]
31 | structvfio_mp_param*r = (structvfio_mp_param*)reply.param;
Quoted 32 lines
Quoted 32 lines
Quoted 9 lines
Quoted 9 lines
| ^
.../lib/librte_eal/linux/eal_vfio_mp_sync.c:33:3: warning: cast increases required alignment of target type [-Wcast-align]33 | (const struct vfio_mp_param *)msg->param; | ^
.../lib/librte_eal/linux/eal_vfio.c: In function ‘vfio_open_group_fd’:.../lib/librte_eal/linux/eal_vfio.c:269:28: warning: cast increases required alignment of target type [-Wcast-align]
269 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 7 lines
Quoted 7 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:316:7: warning: cast increases required alignment of target type [-Wcast-align]
316 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_class.o.../lib/librte_eal/linux/eal_vfio.c: In function‘vfio_sync_default_container’:
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio.c:627:28: warning: cast increases required alignment of target type [-Wcast-align]
627 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 6 lines
Quoted 6 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:652:7: warning: cast increases required alignment of target type [-Wcast-align]
652 | p = (structvfio_mp_param*)mp_rep->param;
| ^.../lib/librte_eal/linux/eal_vfio.c: In function‘vfio_get_default_container_fd’:
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio.c:1094:28: warning: cast increases required alignment of target type [-Wcast-align]
1094 | structvfio_mp_param*p = (structvfio_mp_paramQuoted 8 lines
Quoted 8 lines
*)mp_req.param;
Quoted 7 lines
Quoted 7 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:1116:7: warning: cast increases required alignment of target type [-Wcast-align]
1116 | p = (structvfio_mp_param*)mp_rep->param;
| ^
CC eal_common_bus.o.../lib/librte_eal/linux/eal_vfio.c: In function‘rte_vfio_get_container_fd’:
Quoted 10 lines
Quoted 9 lines
Quoted 3 lines
Quoted 3 lines
.../lib/librte_eal/linux/eal_vfio.c:1202:28: warning: cast increases required alignment of target type [-Wcast-align]
1202 | structvfio_mp_param*p = (structvfio_mp_param*)mp_req.param;
Quoted 5 lines
Quoted 5 lines
| ^
.../lib/librte_eal/linux/eal_vfio.c:1248:7: warning: cast increases required alignment of target type [-Wcast-align]
1248 | p = (structvfio_mp_param*)mp_rep->param;
| ^
v2 cover aarch32 compilation
In reply to Ruifeng WangBuild aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/
When building with meson, requires series:
http://patches.dpdk.org/cover/69536/
[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.html
v2:
Fix aarch32 Make build for ixgbe, and enable ixgbe PMD by default. Add aarch32 support for i40e, and enable i40e PMD by default.
Ruifeng Wang (4):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header file
net/i40e: add support for aarch32
config/defconfig_arm-armv7a-linuxapp-gcc | 4 ++-- drivers/net/i40e/Makefile | 2 +- drivers/net/i40e/i40e_rxtx_vec_neon.c | 2 +- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- lib/librte_eal/arm/include/rte_vect.h | 6 +++++- 7 files changed, 13 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/4 arch/arm: add vcopyq intrinsic for aarch32
vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic.
This fixes build of examples/l3fwd for armv7.
--- lib/librte_eal/arm/include/rte_vect.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
lib/librte_eal/arm/include/rte_vect.h +5 -1
@@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a)#endif -#if RTE_CC_IS_GNU && (GCC_VERSION <70000 ) +#if defined(RTE_ARCH_ARM ) || \ +(defined(RTE_ARCH_ARM64 ) &&RTE_CC_IS_GNU && (GCC_VERSION <70000 )) +/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32) +* On AArch64, this intrinsic is supported since GCC versioin 7. +*/ static inline uint32x4_t vcopyq_laneq_u32 (uint32x4_t a,const int lane_a,uint32x4_t b,const int lane_b)
Signature · 1 line
2.17.1
PATCH v2 2/4 net/ixgbe: add support for aarch32
In reply to Ruifeng WangExpand vector PMD support to aarch32.
Enable ixgbe PMD by default for armv7 make build.
--- config/defconfig_arm-armv7a-linuxapp-gcc | 2 +- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)
config/defconfig_arm-armv7a-linuxapp-gcc +1 -1
@@ -30,6 +30,7 @@ CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n # KNI is not supported on 32-bit CONFIG_RTE_LIBRTE_KNI=n +CONFIG_RTE_LIBRTE_IXGBE_PMD=y # cannot use those on ARM CONFIG_RTE_LIBRTE_ARK_PMD=n CONFIG_RTE_LIBRTE_EM_PMD=n
@@ -39,7 +40,6 @@ CONFIG_RTE_LIBRTE_E1000_PMD=n CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n CONFIG_RTE_LIBRTE_I40E_PMD=n -CONFIG_RTE_LIBRTE_IXGBE_PMD=n CONFIG_RTE_LIBRTE_VMXNET3_PMD=n CONFIG_RTE_LIBRTE_QEDE_PMD=n CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
drivers/net/ixgbe/Makefile +1 -1
@@ -88,7 +88,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_ethdev.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_fdir.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_pf.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_flow.c -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_neon.c else ifeq ($(CONFIG_RTE_ARCH_X86),y) SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_sse.c
drivers/net/ixgbe/ixgbe_rxtx.h +2 -2
@@ -33,7 +33,7 @@#define RTE_IXGBE_DESCS_PER_LOOP 4 -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )#define RTE_IXGBE_RXQ_REARM_THRESH 32#define RTE_IXGBE_MAX_RX_BURST RTE_IXGBE_RXQ_REARM_THRESH#endif
@@ -117,7 +117,7 @@ struct ixgbe_rx_queue {uint8_t using_ipsec;/**< indicates that IPsec RX feature is in use */ #endif -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )uint16_t rxrearm_nb;/**< number of remaining to be re-armed */ uint16_t rxrearm_start;/**< the idx we start the re-arming from */ #endif
Signature · 1 line
2.17.1
Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32
Hello Ruifeng,
config/defconfig_arm-armv7a-linuxapp-gcc CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n · line 33
Quoted 9 lines · Ruifeng Wang
config/defconfig_arm-armv7a-linuxapp-gcc +1
-0@@ -30,6 +30,7 @@ CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n # KNI is not supported on 32-bit CONFIG_RTE_LIBRTE_KNI=n +CONFIG_RTE_LIBRTE_IXGBE_PMD=y
All components are enabled by default in the common_base file. We explicitly disable components in the targets config files that can't support them.
$ git grep IXGBE_PMD= origin/master -- config/ config/common_base:CONFIG_RTE_LIBRTE_IXGBE_PMD=y config/defconfig_arm-armv7a-linuxapp-gcc:CONFIG_RTE_LIBRTE_IXGBE_PMD=n config/defconfig_ppc_64-power8-linuxapp-gcc:CONFIG_RTE_LIBRTE_IXGBE_PMD=n
config/defconfig_arm-armv7a-linuxapp-gcc CONFIG_RTE_LIBRTE_E1000_PMD=n · line 42
Quoted 8 lines
config/defconfig_arm-armv7a-linuxapp-gcc +0
-1# cannot use those on ARM CONFIG_RTE_LIBRTE_ARK_PMD=n CONFIG_RTE_LIBRTE_EM_PMD=n@@ -39,7 +40,6 @@ CONFIG_RTE_LIBRTE_E1000_PMD=n CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n CONFIG_RTE_LIBRTE_I40E_PMD=n -CONFIG_RTE_LIBRTE_IXGBE_PMD=n
So removing this line only should be enough.
Idem with i40e in following patch.
Quoted 3 lines
config/defconfig_arm-armv7a-linuxapp-gcc +0
-0CONFIG_RTE_LIBRTE_VMXNET3_PMD=n CONFIG_RTE_LIBRTE_QEDE_PMD=n CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
Signature · 1 line
David Marchand
Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32
Quoted 11 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Tuesday, June 23, 2020 4:37 PM
To: Ruifeng Wang <[email protected]>
Cc: [email protected]; Wei Zhao <[email protected]>; Jeff Guo <[email protected]>; dev <[email protected]>; Yigit, Ferruh <[email protected]>; Honnappa Nagarahalli <[email protected]>; Juraj Linkeš <[email protected]>; nd <[email protected]>
Subject: Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32
Quoted 1 line
Hello Ruifeng,
Hi David,
Thanks for your review.
Quoted 19 lines
config/defconfig_arm-armv7a-linuxapp-gcc
Quoted 6 lines · Ruifeng Wang
config/defconfig_arm-armv7a-linuxapp-gcc +0
-0@@ -30,6 +30,7 @@
CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=nconfig/defconfig_arm-armv7a-linuxapp-gcc CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n · line 33
Quoted 4 lines
config/defconfig_arm-armv7a-linuxapp-gcc +1
-0# KNI is not supported on 32-bit CONFIG_RTE_LIBRTE_KNI=n +CONFIG_RTE_LIBRTE_IXGBE_PMD=yAll components are enabled by default in the
common_basefile.
We explicitly disable components in the targets config files that can't support them.
Quoted 7 lines
$ git grep IXGBE_PMD= origin/master -- config/ config/common_base:CONFIG_RTE_LIBRTE_IXGBE_PMD=y config/defconfig_arm-armv7a-linuxapp- gcc:CONFIG_RTE_LIBRTE_IXGBE_PMD=n config/defconfig_ppc_64-power8-linuxapp- gcc:CONFIG_RTE_LIBRTE_IXGBE_PMD=n
Didn't realize that.
Will change to remove IXGBE line from armv7a config in next version.
Quoted 11 lines
Quoted 7 lines
config/defconfig_arm-armv7a-linuxapp-gcc +0
-0# cannot use those on ARM CONFIG_RTE_LIBRTE_ARK_PMD=n CONFIG_RTE_LIBRTE_EM_PMD=n@@ -39,7 +40,6 @@ CONFIG_RTE_LIBRTE_E1000_PMD=n
CONFIG_RTE_LIBRTE_ENIC_PMD=nCONFIG_RTE_LIBRTE_FM10K_PMD=nCONFIG_RTE_LIBRTE_I40E_PMD=n-CONFIG_RTE_LIBRTE_IXGBE_PMD=nSo removing this line only should be enough.
Idem with i40e in following patch.
Will remove the line from armv7a config in next version. /Ruifeng
Quoted 8 lines
Quoted 4 lines
CONFIG_RTE_LIBRTE_VMXNET3_PMD=n
CONFIG_RTE_LIBRTE_QEDE_PMD=n
CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n--
David Marchand
PATCH v2 3/4 net/ixgbe: fix include of vector header file
In reply to Ruifeng WangThe include of 'arm_neon.h' causes issues to old gcc and aarch32. Including 'rte_vect.h' instead fixes these issues.
--- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c +1 -2
@@ -5,13 +5,12 @@#include <stdint.h> #include <rte_ethdev_driver.h> #include <rte_malloc.h> +#include <rte_vect.h> #include "ixgbe_ethdev.h" #include "ixgbe_rxtx.h" #include "ixgbe_rxtx_vec_common.h" -#include <arm_neon.h> -#pragma GCC diagnostic ignored "-Wcast-qual" static inline void
Signature · 1 line
2.17.1
PATCH v2 4/4 net/i40e: add support for aarch32
In reply to Ruifeng WangExpand vector PMD support to aarch32.
Enable i40e PMD by default for armv7 make build.
--- config/defconfig_arm-armv7a-linuxapp-gcc | 2 +- drivers/net/i40e/Makefile | 2 +- drivers/net/i40e/i40e_rxtx_vec_neon.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
config/defconfig_arm-armv7a-linuxapp-gcc +1 -1
@@ -30,6 +30,7 @@ CONFIG_RTE_LIBRTE_EAL_VMWARE_TSC_MAP_SUPPORT=n # KNI is not supported on 32-bit CONFIG_RTE_LIBRTE_KNI=n +CONFIG_RTE_LIBRTE_I40E_PMD=y CONFIG_RTE_LIBRTE_IXGBE_PMD=y # cannot use those on ARM CONFIG_RTE_LIBRTE_ARK_PMD=n
@@ -39,7 +40,6 @@ CONFIG_RTE_LIBRTE_CXGBE_PMD=n CONFIG_RTE_LIBRTE_E1000_PMD=n CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n -CONFIG_RTE_LIBRTE_I40E_PMD=n CONFIG_RTE_LIBRTE_VMXNET3_PMD=n CONFIG_RTE_LIBRTE_QEDE_PMD=n CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
drivers/net/i40e/Makefile +1 -1
@@ -69,7 +69,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_dcb.c SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_ethdev.c SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_rxtx.c -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_I40E_INC_VECTOR) += i40e_rxtx_vec_neon.c else ifeq ($(CONFIG_RTE_ARCH_PPC_64),y) SRCS-$(CONFIG_RTE_LIBRTE_I40E_INC_VECTOR) += i40e_rxtx_vec_altivec.c
drivers/net/i40e/i40e_rxtx_vec_neon.c +1 -1
@@ -6,6 +6,7 @@#include <stdint.h> #include <rte_ethdev_driver.h> #include <rte_malloc.h> +#include <rte_vect.h> #include "base/i40e_prototype.h" #include "base/i40e_type.h"
@@ -13,7 +14,6 @@#include "i40e_rxtx.h" #include "i40e_rxtx_vec_common.h" -#include <arm_neon.h> #pragma GCC diagnostic ignored "-Wcast-qual"
Signature · 1 line
2.17.1
v3 cover aarch32 compilation
In reply to Ruifeng WangBuild aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/
When building with meson, requires series:
http://patches.dpdk.org/cover/69536/
[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.html
v3:
Remove ixgbe/i40e from armv7 config to set these PMDs enabled. v2:
Fix aarch32 Make build for ixgbe, and enable ixgbe PMD by default. Add aarch32 support for i40e, and enable i40e PMD by default.
Ruifeng Wang (4):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header file
net/i40e: add support for aarch32
config/defconfig_arm-armv7a-linuxapp-gcc | 2 -- drivers/net/i40e/Makefile | 2 +- drivers/net/i40e/i40e_rxtx_vec_neon.c | 2 +- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- lib/librte_eal/arm/include/rte_vect.h | 6 +++++- 7 files changed, 11 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/4 arch/arm: add vcopyq intrinsic for aarch32
vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic.
This fixes build of examples/l3fwd for armv7.
--- lib/librte_eal/arm/include/rte_vect.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
lib/librte_eal/arm/include/rte_vect.h +5 -1
@@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a)#endif -#if RTE_CC_IS_GNU && (GCC_VERSION <70000 ) +#if defined(RTE_ARCH_ARM ) || \ +(defined(RTE_ARCH_ARM64 ) &&RTE_CC_IS_GNU && (GCC_VERSION <70000 )) +/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32) +* On AArch64, this intrinsic is supported since GCC versioin 7. +*/ static inline uint32x4_t vcopyq_laneq_u32 (uint32x4_t a,const int lane_a,uint32x4_t b,const int lane_b)
Signature · 1 line
2.17.1
PATCH v3 2/4 net/ixgbe: add support for aarch32
In reply to Ruifeng WangExpand vector PMD support to aarch32.
Enable ixgbe PMD by default for armv7 make build.
--- config/defconfig_arm-armv7a-linuxapp-gcc | 1 - drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-)
config/defconfig_arm-armv7a-linuxapp-gcc +0 -1
@@ -39,7 +39,6 @@ CONFIG_RTE_LIBRTE_E1000_PMD=n CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n CONFIG_RTE_LIBRTE_I40E_PMD=n -CONFIG_RTE_LIBRTE_IXGBE_PMD=n CONFIG_RTE_LIBRTE_VMXNET3_PMD=n CONFIG_RTE_LIBRTE_QEDE_PMD=n CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
drivers/net/ixgbe/Makefile +1 -1
@@ -88,7 +88,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_ethdev.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_fdir.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_pf.c SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_flow.c -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_neon.c else ifeq ($(CONFIG_RTE_ARCH_X86),y) SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_sse.c
drivers/net/ixgbe/ixgbe_rxtx.h +2 -2
@@ -33,7 +33,7 @@#define RTE_IXGBE_DESCS_PER_LOOP 4 -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )#define RTE_IXGBE_RXQ_REARM_THRESH 32#define RTE_IXGBE_MAX_RX_BURST RTE_IXGBE_RXQ_REARM_THRESH#endif
@@ -117,7 +117,7 @@ struct ixgbe_rx_queue {uint8_t using_ipsec;/**< indicates that IPsec RX feature is in use */ #endif -#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) +#if defined(RTE_ARCH_X86 ) || defined(RTE_ARCH_ARM64 ) || defined(RTE_ARCH_ARM )uint16_t rxrearm_nb;/**< number of remaining to be re-armed */ uint16_t rxrearm_start;/**< the idx we start the re-arming from */ #endif
Signature · 1 line
2.17.1
PATCH v3 3/4 net/ixgbe: fix include of vector header file
In reply to Ruifeng WangThe include of 'arm_neon.h' causes issues to old gcc and aarch32. Including 'rte_vect.h' instead fixes these issues.
--- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c +1 -2
@@ -5,13 +5,12 @@#include <stdint.h> #include <rte_ethdev_driver.h> #include <rte_malloc.h> +#include <rte_vect.h> #include "ixgbe_ethdev.h" #include "ixgbe_rxtx.h" #include "ixgbe_rxtx_vec_common.h" -#include <arm_neon.h> -#pragma GCC diagnostic ignored "-Wcast-qual" static inline void
Signature · 1 line
2.17.1
PATCH v3 4/4 net/i40e: add support for aarch32
In reply to Ruifeng WangExpand vector PMD support to aarch32.
Enable i40e PMD by default for armv7 make build.
--- config/defconfig_arm-armv7a-linuxapp-gcc | 1 - drivers/net/i40e/Makefile | 2 +- drivers/net/i40e/i40e_rxtx_vec_neon.c | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-)
config/defconfig_arm-armv7a-linuxapp-gcc +0 -1
@@ -38,7 +38,6 @@ CONFIG_RTE_LIBRTE_CXGBE_PMD=n CONFIG_RTE_LIBRTE_E1000_PMD=n CONFIG_RTE_LIBRTE_ENIC_PMD=n CONFIG_RTE_LIBRTE_FM10K_PMD=n -CONFIG_RTE_LIBRTE_I40E_PMD=n CONFIG_RTE_LIBRTE_VMXNET3_PMD=n CONFIG_RTE_LIBRTE_QEDE_PMD=n CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
drivers/net/i40e/Makefile +1 -1
@@ -69,7 +69,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_dcb.c SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_ethdev.c SRCS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += i40e_rxtx.c -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) SRCS-$(CONFIG_RTE_LIBRTE_I40E_INC_VECTOR) += i40e_rxtx_vec_neon.c else ifeq ($(CONFIG_RTE_ARCH_PPC_64),y) SRCS-$(CONFIG_RTE_LIBRTE_I40E_INC_VECTOR) += i40e_rxtx_vec_altivec.c
drivers/net/i40e/i40e_rxtx_vec_neon.c +1 -1
@@ -6,6 +6,7 @@#include <stdint.h> #include <rte_ethdev_driver.h> #include <rte_malloc.h> +#include <rte_vect.h> #include "base/i40e_prototype.h" #include "base/i40e_type.h"
@@ -13,7 +14,6 @@#include "i40e_rxtx.h" #include "i40e_rxtx_vec_common.h" -#include <arm_neon.h> #pragma GCC diagnostic ignored "-Wcast-qual"
Signature · 1 line
2.17.1
Quoted 19 lines · Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these.
When building with make, please refer to guide:
http://patches.dpdk.org/patch/62820/When building with meson, requires series:
http://patches.dpdk.org/cover/69536/[1] https://mails.dpdk.org/archives/dev/2020-April/162673.html
[2] https://mails.dpdk.org/archives/dev/2020-April/163846.htmlv3:
Remove ixgbe/i40e from armv7 config to set these PMDs enabled. v2:
Fix aarch32 Make build for ixgbe, and enable ixgbe PMD by default. Add aarch32 support for i40e, and enable i40e PMD by default.
Quoted 5 lines
Ruifeng Wang (4):
arch/arm: add vcopyq intrinsic for aarch32
net/ixgbe: add support for aarch32
net/ixgbe: fix include of vector header file
net/i40e: add support for aarch32
For series,
Applied to dpdk-next-net/master, thanks.