Skip to contentSkip to conversation

mem: mark pages as not accessed when returning back to memory pool

PATCH Applied Li Feng 3 participants 4 messages Apr 24, 2020 – Apr 26, 2020

lore
Share & tools
lore

Li Feng

author
#0 lore raw

PATCH 1/1 mem: mark pages as not accessed when returning back to memory pool

Commit 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA") has mapped the initialized memory with PROT_NONE, and when it's unmapped, eal_memalloc.c should remmap the anonymous memory with PROT_NONE too.

---
 lib/librte_eal/linux/eal_memalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/linux/eal_memalloc.c +1 -1
index 9d2a6fc6f..64a2b44c1 100644
@@ -683,7 +683,7 @@ free_seg(struct rte_memseg *ms, struct hugepage_info *hi,
 	/* erase page data */
 	memset(ms->addr, 0, ms->len);
 
-	if (mmap(ms->addr, ms->len, PROT_READ,
+	if (mmap(ms->addr, ms->len, PROT_NONE,
 			MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0) ==
 				MAP_FAILED) {
 		RTE_LOG(DEBUG, EAL, "couldn't unmap page\n");
Signature · 8 lines
2.11.0


-- 
The SmartX email address is only for business purpose. Any sent message 
that is not related to the business is not authorized or permitted by 
SmartX.
本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Li Feng

Commit 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA") has mapped the initialized memory with PROT_NONE, and when it's unmapped, eal_memalloc.c should remmap the anonymous memory with PROT_NONE too.

---
  lib/librte_eal/linux/eal_memalloc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/linux/eal_memalloc.c +0 -0
index 9d2a6fc6f..64a2b44c1 100644

lib/librte_eal/linux/eal_memalloc.c free_seg(struct rte_memseg *ms, struct hugepage_info *hi, · line 689

Quoted 8 lines
lib/librte_eal/linux/eal_memalloc.c +1 -1
@@ -683,7 +683,7 @@ free_seg(struct rte_memseg *ms, struct hugepage_info *hi,
  	/* erase page data */
  	memset(ms->addr, 0, ms->len);
 
-	if (mmap(ms->addr, ms->len, PROT_READ,
+	if (mmap(ms->addr, ms->len, PROT_NONE,
  			MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0) ==
  				MAP_FAILED) {
  		RTE_LOG(DEBUG, EAL, "couldn't unmap page\n");
Fixes 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA")
Signature · 2 lines
Thanks,
Anatoly
Acked-by Anatoly Burakov on v1 1/1 Applied
#2 lore raw
In reply to Li Feng
Quoted 6 lines · Li Feng

Commit 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA") has mapped the initialized memory with PROT_NONE, and when it's unmapped, eal_memalloc.c should remmap the anonymous memory with PROT_NONE too.

Fixes 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA")

Applied, thanks.

Please for future contributions, could you get this footer removed?

Quoted 4 lines

The SmartX email address is only for business purpose. Any sent message that is not related to the business is not authorized or permitted by SmartX.
本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.

Signature · 1 line
David Marchand
author
#3 lore raw

Thanks,

Feng Li

Quoted 12 lines · David Marchand <[email protected]> 于2020年4月25日周六 上午1:10写道:
Quoted 6 lines · Li Feng

Commit 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA") has mapped the initialized memory with PROT_NONE, and when it's unmapped, eal_memalloc.c should remmap the anonymous memory with PROT_NONE too.

Fixes 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA")
Quoted 7 lines

Applied, thanks.

Please for future contributions, could you get this footer removed?

I think It's attached by the corporation mail server. Maybe I need ask IT department for help.

Quoted 10 lines
Quoted 5 lines

The SmartX email address is only for business purpose. Any sent message that is not related to the business is not authorized or permitted by SmartX.
本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.

--
David Marchand

Signature · 4 lines
The SmartX email address is only for business purpose. Any sent message 
that is not related to the business is not authorized or permitted by 
SmartX.
本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.