Skip to contentSkip to conversation

package/matio: new package

PATCH Superseded Gwenhael Goavec-Merou 3 participants 4 messages Apr 24, 2020 – Apr 25, 2020

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/matio: new package

From: Gwenhael Goavec-Merou <[email protected]>

matio is an C library for reading and writing MATLAB MAT files.

---
Changes v1 -> v2:
* add one blank line befor URL (Heiko)
* drop blank lines around MATIO_DEPENDENCIES and MATIO_INSTALL_STAGING (Heiko)
* drop comment about STAGING (Heiko)
* += -> + for MATIO_CONF_ENV (Heiko)

---
 DEVELOPERS               |  1 +
 package/Config.in        |  1 +
 package/matio/Config.in  | 15 +++++++++++++++
 package/matio/matio.hash |  5 +++++
 package/matio/matio.mk   | 25 +++++++++++++++++++++++++
 5 files changed, 47 insertions(+)
 create mode 100644 package/matio/Config.in
 create mode 100644 package/matio/matio.hash
 create mode 100644 package/matio/matio.mk
DEVELOPERS +1 -0
index c57bc1c5c9..6cd115be38 100644
@@ -1101,6 +1101,7 @@ F:	package/gnuradio/
 F:	package/gqrx/
 F:	package/gr-osmosdr/
 F:	package/libusbgx/
+F:	package/matio/
 F:	package/python-cheetah/
 F:	package/python-markdown/
 F:	package/python-remi/
package/Config.in +1 -0
index a9c6f6fcbc..f7c48d2d9e 100644
@@ -1868,6 +1868,7 @@ endif
 	source "package/liquid-dsp/Config.in"
 	source "package/llvm/Config.in"
 	source "package/lttng-libust/Config.in"
+	source "package/matio/Config.in"
 	source "package/mpc/Config.in"
 	source "package/mpdecimal/Config.in"
 	source "package/mpfr/Config.in"
package/matio/Config.in new file +15 -0
new file mode 100644
index 0000000000..b6c4223e44
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_MATIO
+	bool "matio"
+	select BR2_PACKAGE_ZLIB
+	help
+	  matio is an C library for reading and writing MATLAB MAT
+	  files.
+
+	  https://sourceforge.net/projects/matio
+
+if BR2_PACKAGE_MATIO
+
+config BR2_PACKAGE_MATIO_SPARSE
+	bool "sparse support"
+
+endif
package/matio/matio.hash new file +5 -0
new file mode 100644
index 0000000000..d84f50e0b2
@@ -0,0 +1,5 @@
+# From https://sourceforge.net/projects/matio/files/matio/1.5.17/
+sha512  af8ff11c7c44fea9ea6886e381f49ef9186946f3def98ad9695f2d5d1df045c35e8f4ceac12a44be397f7bbd708b4803762b5ce54c45b60a9f446d551c04f5d2  matio-1.5.17.tar.gz
+# Locally computed
+sha256  5e455527d370ab297c4abe5a2ab4d599c93ac7c1a0c85d841cc5c22f8221c400  matio-1.5.17.tar.gz
+sha256  62a0cab69eeadb3697a2249d5a869915b89e62b59b794dd70802c2b8624ed374  COPYING
package/matio/matio.mk new file +25 -0
new file mode 100644
index 0000000000..2ac46f10ad
@@ -0,0 +1,25 @@
+################################################################################
+#
+# matio
+#
+################################################################################
+
+MATIO_VERSION = 1.5.17
+MATIO_SITE = http://downloads.sourceforge.net/project/matio/matio/$(MATIO_VERSION)
+MATIO_LICENSE = BSD-2-Clause
+MATIO_LICENSE_FILES = COPYING
+MATIO_DEPENDENCIES = zlib
+MATIO_INSTALL_STAGING = YES
+
+# va_copy()
+MATIO_CONF_ENV = ac_cv_va_copy=yes
+
+MATIO_CONF_OPTS = --enable-mat73=no
+
+ifeq ($(BR2_PACKAGE_MATIO_SPARSE),y)
+MATIO_CONF_OPTS += --enable-extended-sparse=yes
+else
+MATIO_CONF_OPTS += --enable-extended-sparse=no
+endif
+
+$(eval $(autotools-package))
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/1 package/matio: new package

Gwenhael, All,

On 2020-04-24 10:56 +0200, Gwenhael Goavec-Merou spake thusly:

Quoted 6 lines

From: Gwenhael Goavec-Merou <[email protected]>

matio is an C library for reading and writing MATLAB MAT files.

---

[--SNIP--]

Quoted 9 lines
package/matio/Config.in new file +3 -0
new file mode 100644
index 0000000000..b6c4223e44
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_MATIO
+	bool "matio"
+	select BR2_PACKAGE_ZLIB

package/matio/Config.in line 13

Quoted 10 lines
package/matio/Config.in new file +10 -0
+	help
+	  matio is an C library for reading and writing MATLAB MAT
+	  files.
+
+	  https://sourceforge.net/projects/matio
+
+if BR2_PACKAGE_MATIO
+
+config BR2_PACKAGE_MATIO_SPARSE
+	bool "sparse support"

Why do we need this top be optional? Does it increase the size considerably?

Im intrigued, because...

[--SNIP--]

Quoted 13 lines
package/matio/matio.mk new file +7 -0
new file mode 100644
index 0000000000..2ac46f10ad
@@ -0,0 +1,25 @@
+################################################################################
+#
+# matio
+#
+################################################################################
+
+MATIO_VERSION = 1.5.17

package/matio/matio.mk line 17

Quoted 10 lines
package/matio/matio.mk new file +10 -0
+MATIO_SITE = http://downloads.sourceforge.net/project/matio/matio/$(MATIO_VERSION)
+MATIO_LICENSE = BSD-2-Clause
+MATIO_LICENSE_FILES = COPYING
+MATIO_DEPENDENCIES = zlib
+MATIO_INSTALL_STAGING = YES
+
+# va_copy()
+MATIO_CONF_ENV = ac_cv_va_copy=yes
+
+MATIO_CONF_OPTS = --enable-mat73=no

... here you explicitly disable a feature.

package/matio/matio.mk line 22

Quoted 4 lines
package/matio/matio.mk new file +4 -0
+ifeq ($(BR2_PACKAGE_MATIO_SPARSE),y)
+MATIO_CONF_OPTS += --enable-extended-sparse=yes
+else
+MATIO_CONF_OPTS += --enable-extended-sparse=no

Usually, we use: --enable-extended-sparse and --disable-extended-sparse=yes

Regards,
Yann E. MORIN.

Quoted 10 lines
package/matio/matio.mk new file +3 -0
+endif
+
+$(eval $(autotools-package))
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 package/matio: new package

Yann, all

Quoted 24 lines · On Fri, 24 Apr 2020 14:05:45 +0200 "Yann E. MORIN" <[email protected]>…

Gwenhael, All,

On 2020-04-24 10:56 +0200, Gwenhael Goavec-Merou spake thusly:

Quoted 6 lines

From: Gwenhael Goavec-Merou <[email protected]>

matio is an C library for reading and writing MATLAB MAT files.

---

[--SNIP--]

Quoted 14 lines
package/matio/Config.in new file +8 -0
new file mode 100644
index 0000000000..b6c4223e44
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_MATIO
+	bool "matio"
+	select BR2_PACKAGE_ZLIB
+	help
+	  matio is an C library for reading and writing MATLAB MAT
+	  files.
+
+	  https://sourceforge.net/projects/matio
Quoted 9 lines

package/matio/Config.in line 13

Quoted 5 lines
package/matio/Config.in new file +5 -0
+
+if BR2_PACKAGE_MATIO
+
+config BR2_PACKAGE_MATIO_SPARSE
+	bool "sparse support"  

Why do we need this top be optional? Does it increase the size considerably?

I need to check

Quoted 21 lines

Im intrigued, because...

[--SNIP--]

Quoted 17 lines
package/matio/matio.mk new file +8 -0
new file mode 100644
index 0000000000..2ac46f10ad
@@ -0,0 +1,25 @@
+################################################################################
+#
+# matio
+#
+################################################################################
+
+MATIO_VERSION = 1.5.17
+MATIO_SITE =

http://downloads.sourceforge.net/project/matio/matio/$(MATIO_VERSION)

package/matio/matio.mk new file +2 -0
+MATIO_LICENSE = BSD-2-Clause +MATIO_LICENSE_FILES = COPYING
+MATIO_DEPENDENCIES = zlib
Quoted 9 lines

package/matio/matio.mk line 17

Quoted 6 lines
package/matio/matio.mk new file +6 -0
+MATIO_INSTALL_STAGING = YES
+
+# va_copy()
+MATIO_CONF_ENV = ac_cv_va_copy=yes
+
+MATIO_CONF_OPTS = --enable-mat73=no  

... here you explicitly disable a feature.

This feature requires hdf5, not available. I must add a message to explain why

Quoted 11 lines

package/matio/matio.mk line 22

Quoted 5 lines
package/matio/matio.mk new file +4 -0
+ifeq ($(BR2_PACKAGE_MATIO_SPARSE),y)
+MATIO_CONF_OPTS += --enable-extended-sparse=yes
+else
+MATIO_CONF_OPTS += --enable-extended-sparse=no  

Usually, we use: --enable-extended-sparse and --disable-extended-sparse=yes

Regards,
Yann E. MORIN.

Quoted 6 lines
Quoted 6 lines
package/matio/matio.mk new file +3 -0
+endif
+
+$(eval $(autotools-package))
Signature · 1 line
2.25.1

Regards,
Gwen

#3 lore raw

PATCH v2 1/1 package/matio: new package

In reply to Gwenhael Goavec-Merou

package/matio/matio.hash line 4

Quoted 10 lines · On Fri, 24 Apr 2020 10:56:24 +0200 Gwenhael Goavec-Merou…
package/matio/matio.hash new file +4 -0
new file mode 100644
index 0000000000..d84f50e0b2
@@ -0,0 +1,5 @@
+# From https://sourceforge.net/projects/matio/files/matio/1.5.17/
+sha512  af8ff11c7c44fea9ea6886e381f49ef9186946f3def98ad9695f2d5d1df045c35e8f4ceac12a44be397f7bbd708b4803762b5ce54c45b60a9f446d551c04f5d2  matio-1.5.17.tar.gz
+# Locally computed
+sha256  5e455527d370ab297c4abe5a2ab4d599c93ac7c1a0c85d841cc5c22f8221c400  matio-1.5.17.tar.gz

If there's an upstream provided sha512 hash, I'm not sure it's really useful to add a locally calculated sha256 hash.

package/matio/matio.hash

Quoted 11 lines
package/matio/matio.hash new file +11 -0
+MATIO_VERSION = 1.5.17
+MATIO_SITE = http://downloads.sourceforge.net/project/matio/matio/$(MATIO_VERSION)
+MATIO_LICENSE = BSD-2-Clause
+MATIO_LICENSE_FILES = COPYING
+MATIO_DEPENDENCIES = zlib
+MATIO_INSTALL_STAGING = YES
+
+# va_copy()
+MATIO_CONF_ENV = ac_cv_va_copy=yes
+
+MATIO_CONF_OPTS = --enable-mat73=no

Please use:

	--disable-mat73

package/matio/matio.hash

Quoted 3 lines
package/matio/matio.hash new file +3 -0
+
+ifeq ($(BR2_PACKAGE_MATIO_SPARSE),y)
+MATIO_CONF_OPTS += --enable-extended-sparse=yes

Just:

--enable-extended-sparse

package/matio/matio.hash

Quoted 2 lines
package/matio/matio.hash new file +2 -0
+else
+MATIO_CONF_OPTS += --enable-extended-sparse=no

Use:

--disable-extended-sparse

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com