Skip to contentSkip to conversation

toolchain/toolchain-external: install ldd on the target

PATCH New Sébastien Szymanski 3 participants 4 messages Apr 22, 2020 – Apr 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain/toolchain-external: install ldd on the target

From: Julien Boibessot <[email protected]>

From: Julien Boibessot <[email protected]>

It could be usefull to have ldd on the target so install it.

[S?bastien: add commit message]
---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 7 +++++++
 1 file changed, 7 insertions(+)
toolchain/toolchain-external/pkg-toolchain-external.mk +7 -0
index 8667d7ddf6..6d91cb5d1e 100644
@@ -499,6 +499,12 @@ define TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO
 	fi
 endef
 
+define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD
+	$(Q)if test -f $(STAGING_DIR)/usr/bin/ldd ; then \
+		$(INSTALL) -D $(STAGING_DIR)/usr/bin/ldd $(TARGET_DIR)/usr/bin/ldd ; \
+		$(SED) 's:.*/bin/bash:#!/bin/sh:' $(TARGET_DIR)/usr/bin/ldd ; \
+	fi
+endef
 
 ################################################################################
 # inner-toolchain-external-package -- defines the generic installation rules
@@ -593,6 +599,7 @@ define $(2)_INSTALL_TARGET_CMDS
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS)
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER)
 	$$(TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO)
+	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD)
 endef
 
 # Call the generic package infrastructure to generate the necessary
Signature · 1 line
2.25.3
#1 lore raw

PATCH 1/1 toolchain/toolchain-external: install ldd on the target

S?bastien, Julien, All,

On 2020-04-22 17:34 +0200, S?bastien Szymanski spake thusly:

Quoted 5 lines

From: Julien Boibessot <[email protected]>

From: Julien Boibessot <[email protected]>

It could be usefull to have ldd on the target so install it.

What does ldd bring that can't be already achieved? For example on my host system:

    $ ldd /bin/bash
        linux-vdso.so.1 (0x00007ffea5be0000)
        libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f2ea6fa0000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f2ea6f9a000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f2ea6da9000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f2ea7114000)
    $ LD_TRACE_LOADED_OBJECTS=1 /bin/bash
        linux-vdso.so.1 (0x00007ffd3d3a7000)
        libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f46883cd000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f46883c7000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f46881d6000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f4688419000)

(yes, that's shorter to type, I guess?)

Regards,
Yann E. MORIN.

Quoted 39 lines
[S?bastien: add commit message]
---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 7 +++++++
 1 file changed, 7 insertions(+)
toolchain/toolchain-external/pkg-toolchain-external.mk +7 -0
index 8667d7ddf6..6d91cb5d1e 100644
@@ -499,6 +499,12 @@ define TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO
 	fi
 endef
 
+define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD
+	$(Q)if test -f $(STAGING_DIR)/usr/bin/ldd ; then \
+		$(INSTALL) -D $(STAGING_DIR)/usr/bin/ldd $(TARGET_DIR)/usr/bin/ldd ; \
+		$(SED) 's:.*/bin/bash:#!/bin/sh:' $(TARGET_DIR)/usr/bin/ldd ; \
+	fi
+endef
 
 ################################################################################
 # inner-toolchain-external-package -- defines the generic installation rules
@@ -593,6 +599,7 @@ define $(2)_INSTALL_TARGET_CMDS
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS)
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER)
 	$$(TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO)
+	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD)
 endef
 
 # Call the generic package infrastructure to generate the necessary
Signature · 6 lines
2.25.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 toolchain/toolchain-external: install ldd on the target

Quoted 10 lines · On Fri, 24 Apr 2020 14:02:46 +0200 "Yann E. MORIN" <[email protected]>…

What does ldd bring that can't be already achieved? For example on my host system:

    $ ldd /bin/bash
        linux-vdso.so.1 (0x00007ffea5be0000)
        libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f2ea6fa0000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f2ea6f9a000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f2ea6da9000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f2ea7114000)
Quoted 6 lines
    $ LD_TRACE_LOADED_OBJECTS=1 /bin/bash
        linux-vdso.so.1 (0x00007ffd3d3a7000)
        libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007f46883cd000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f46883c7000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f46881d6000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f4688419000)

I guess the main thing that it brings is that people know about "ldd" in general, while nobody knows about LD_TRACE_LOADED_OBJECTS :)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 toolchain/toolchain-external: install ldd on the target

In reply to Sébastien Szymanski

S?bastien, All,

On 2020-04-22 17:34 +0200, S?bastien Szymanski spake thusly:

Quoted 9 lines

From: Julien Boibessot <[email protected]>

From: Julien Boibessot <[email protected]>

It could be usefull to have ldd on the target so install it.

[S?bastien: add commit message]

I was not too fond of it, but it looks like we do install it for an internal glibc-based toolchain, so meh...

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 36 lines
---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 7 +++++++
 1 file changed, 7 insertions(+)
toolchain/toolchain-external/pkg-toolchain-external.mk +7 -0
index 8667d7ddf6..6d91cb5d1e 100644
@@ -499,6 +499,12 @@ define TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO
 	fi
 endef
 
+define TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD
+	$(Q)if test -f $(STAGING_DIR)/usr/bin/ldd ; then \
+		$(INSTALL) -D $(STAGING_DIR)/usr/bin/ldd $(TARGET_DIR)/usr/bin/ldd ; \
+		$(SED) 's:.*/bin/bash:#!/bin/sh:' $(TARGET_DIR)/usr/bin/ldd ; \
+	fi
+endef
 
 ################################################################################
 # inner-toolchain-external-package -- defines the generic installation rules
@@ -593,6 +599,7 @@ define $(2)_INSTALL_TARGET_CMDS
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LIBS)
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_GDBSERVER)
 	$$(TOOLCHAIN_EXTERNAL_FIXUP_UCLIBCNG_LDSO)
+	$$(TOOLCHAIN_EXTERNAL_INSTALL_TARGET_LDD)
 endef
 
 # Call the generic package infrastructure to generate the necessary
Signature · 6 lines
2.25.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'