package/libtasn1: fix build with gcc 4.8
PATCH 1/1 package/libtasn1: fix build with gcc 4.8
Fixes:
- http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896
Signed-off-by Fabrice Fontaine <[email protected]>
--- ...orpus2array.c-fix-build-with-gcc-4.8.patch | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 package/libtasn1/0002-fuzz-corpus2array.c-fix-build-with-gcc-4.8.patch
package/libtasn1/0002-fuzz-corpus2array.c-fix-build-with-gcc-4.8.patch new file +46 -0
@@ -0,0 +1,46 @@ +From f633abcfb9cff19efca53aa68ddc96217e7487ae Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Fri, 24 Apr 2020 16:57:35 +0200 +Subject: [PATCH] fuzz/corpus2array.c: fix build with gcc 4.8 + +Fix the following build failure with gcc 4.8: + +corpus2array.c:123:4: error: 'for' loop initial declarations are only allowed in C99 mode + for (int i = 8; i < 32 ; i++) { + ^ +corpus2array.c:123:4: note: use option -std=c99 or -std=gnu99 to compile your code + +Fixes: + - http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896 + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upstream status: not sent yet] +--- + fuzz/corpus2array.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/fuzz/corpus2array.c b/fuzz/corpus2array.c +index fc30524..b2d01ee 100644 +--- a/fuzz/corpus2array.c ++++ b/fuzz/corpus2array.c +@@ -112,7 +112,7 @@ int main(void) + printf(" { NULL"); + + if (e.type) { +- int add = 0; ++ int i, add = 0; + + // we leave the lowest 8 bit out + if ((e.type & 0xFF) == 17) { +@@ -120,7 +120,7 @@ int main(void) + add = 1; + } + +- for (int i = 8; i < 32 ; i++) { ++ for (i = 8; i < 32 ; i++) { + if ((e.type & (1U << i)) && typename[i - 8]) { + printf(add ? "|%s" : ", %s", typename[i - 8]); + add = 1; +-- +2.25.1 +
Signature · 1 line
2.25.1
PATCH 1/1 package/libtasn1: fix build with gcc 4.8
Fabrice, All,
On 2020-04-24 17:04 +0200, Fabrice Fontaine spake thusly:
Quoted 45 lines
Fixes:
- http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896Signed-off-by Fabrice Fontaine <[email protected]>--- ...orpus2array.c-fix-build-with-gcc-4.8.patch | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 package/libtasn1/0002-fuzz-corpus2array.c-fix-build-with-gcc-4.8.patchpackage/libtasn1/0002-fuzz-corpus2array.c-fix-build-with-gcc-4.8.patch new file +30
-0@@ -0,0 +1,46 @@ +From f633abcfb9cff19efca53aa68ddc96217e7487ae Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Fri, 24 Apr 2020 16:57:35 +0200 +Subject: [PATCH] fuzz/corpus2array.c: fix build with gcc 4.8 + +Fix the following build failure with gcc 4.8: + +corpus2array.c:123:4: error: 'for' loop initial declarations are only allowed in C99 mode + for (int i = 8; i < 32 ; i++) { + ^ +corpus2array.c:123:4: note: use option -std=c99 or -std=gnu99 to compile your code + +Fixes: + - http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896 + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upstream status: not sent yet] +--- + fuzz/corpus2array.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/fuzz/corpus2array.c b/fuzz/corpus2array.c +index fc30524..b2d01ee 100644 +--- a/fuzz/corpus2array.c ++++ b/fuzz/corpus2array.c +@@ -112,7 +112,7 @@ int main(void) + printf(" { NULL"); + + if (e.type) { +- int add = 0;
package/libtasn1/0002-fuzz-corpus2array.c-fix-build-with-gcc-4.8.patch line 40
Quoted 10 lines
package/libtasn1/0002-fuzz-corpus2array.c-fix-build-with-gcc-4.8.patch new file +10
-0++ int i, add = 0; + + // we leave the lowest 8 bit out + if ((e.type & 0xFF) == 17) { +@@ -120,7 +120,7 @@ int main(void) + add = 1; + } + +- for (int i = 8; i < 32 ; i++) { ++ for (i = 8; i < 32 ; i++) {
I think a better solution would be to switch to using -std=gnu99 (or std=c99). For example:
LIBTASN1_CONF_OPTS = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
I've doen a quick test-build, and it seems to fit the bill here. Care to sanity-check this proposal and resend, please?
Regards,
Yann E. MORIN.
Quoted 13 lines
package/libtasn1/0002-fuzz-corpus2array.c-fix-build-with-gcc-4.8.patch new file +6
-0+ if ((e.type & (1U << i)) && typename[i - 8]) { + printf(add ? "|%s" : ", %s", typename[i - 8]); + add = 1; +-- +2.25.1 +Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'