Skip to contentSkip to conversation

dma-buf: heaps: Initialize during core instead of subsys

PATCH In review Andrew F. Davis 2 participants 2 messages Apr 24, 2020 – Apr 25, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma-buf: heaps: Initialize during core instead of subsys

Some clients of DMA-Heaps probe earlier than subsys_initcall(), this can cause issues when these clients call dma_heap_add() before the core DMA-Heaps framework has initialized. DMA-Heaps should initialize during core startup to get ahead of all users.

---
 drivers/dma-buf/dma-heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma-buf/dma-heap.c +1 -1
index afd22c9dbdcf..af6edfbeddfe 100644
@@ -295,4 +295,4 @@ static int dma_heap_init(void)
 
 	return 0;
 }
-subsys_initcall(dma_heap_init);
+core_initcall(dma_heap_init);
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Andrew F. Davis

Some clients of DMA-Heaps probe earlier than subsys_initcall(), this can cause issues when these clients call dma_heap_add() before the core DMA-Heaps framework has initialized. DMA-Heaps should initialize during core startup to get ahead of all users.

No objection from me right off.

thanks
-john
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel