Skip to contentSkip to conversation

package/libtorrent: annotate CVE-2009-1760 and CVE-2016-5301

PATCH New Fabrice Fontaine 2 participants 2 messages Mar 1, 2020 – Apr 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libtorrent: annotate CVE-2009-1760 and CVE-2016-5301

CVE-2009-1760 and CVE-2016-5301 are misclassified (by our CVE tracker) as affecting libtorrent, while in fact they affect libtorrent-rasterbar.

---
 package/libtorrent/libtorrent.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/libtorrent/libtorrent.mk +4 -0
index c8310cab65..17c6f92ab4 100644
@@ -14,6 +14,10 @@ LIBTORRENT_INSTALL_STAGING = YES
 LIBTORRENT_LICENSE = GPL-2.0
 LIBTORRENT_LICENSE_FILES = COPYING
 
+# CVE-2009-1760 and CVE-2016-5301 are misclassified (by our CVE tracker) as
+# affecting libtorrent, while in fact they affect libtorrent-rasterbar.
+LIBTORRENT_IGNORE_CVES += CVE-2009-1760 CVE-2016-5301
+
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 LIBTORRENT_CONF_OPTS += --enable-openssl
 LIBTORRENT_DEPENDENCIES += openssl
Signature · 1 line
2.25.0
#1 lore raw

PATCH 1/1 package/libtorrent: annotate CVE-2009-1760 and CVE-2016-5301

Quoted 13 lines · On Sun, 1 Mar 2020 21:00:49 +0100 Fabrice Fontaine…

CVE-2009-1760 and CVE-2016-5301 are misclassified (by our CVE tracker) as affecting libtorrent, while in fact they affect libtorrent-rasterbar.

---
 package/libtorrent/libtorrent.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/libtorrent/libtorrent.mk +0 -0
index c8310cab65..17c6f92ab4 100644

package/libtorrent/libtorrent.mk LIBTORRENT_INSTALL_STAGING = YES · line 19

Quoted 6 lines
package/libtorrent/libtorrent.mk +3 -0
@@ -14,6 +14,10 @@ LIBTORRENT_INSTALL_STAGING = YES
 LIBTORRENT_LICENSE = GPL-2.0
 LIBTORRENT_LICENSE_FILES = COPYING
 
+# CVE-2009-1760 and CVE-2016-5301 are misclassified (by our CVE tracker) as
+# affecting libtorrent, while in fact they affect libtorrent-rasterbar.
+LIBTORRENT_IGNORE_CVES += CVE-2009-1760 CVE-2016-5301

Here as well, I don't think this is the proper solution. You're just papering over the actual problem, not solving it.

CVE-2009-1760 is described like this:

      "affects" : {
        "vendor" : {
          "vendor_data" : [ {
            "vendor_name" : "rasterbar_software",
            "product" : {
              "product_data" : [ {
                "product_name" : "libtorrent",

So indeed, since we currently only match on "product_name", we believe this CVE is for libtorrent, while it is for libtorrent-rasterbar.

The proper way to solve this is to have better CPE matching logic. Your patch is just removing the CVEs from libtorrent, but not making them appear for libtorrent-rasterbar (even though they probably wouldn't appear as they are quite old).

Let's work together on a proper CPE matching logic instead.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com