package/uacme: select openssl or gnutls with ualpn
PATCH v3 1/1 package/uacme: select openssl or gnutls with ualpn
ualpn with mbedtls requires the activation of MBEDTLS_X509_ALLOW_UNSUPPORTED_CRITICAL_EXTENSION on mbedtls which can be a security risk.
So let the user explicitly choose the crypto library by copy/pasting behavior of libssh and don't allow the user to select mbedtls with ualpn
Fixes:
- http://autobuild.buildroot.org/results/5d42189299549cd655218e9e7cfcfa63e79f74ec
Signed-off-by Fabrice Fontaine <[email protected]>
---
Changes v2 -> v3 (after review of Yann E. Morin):
- Put back the option to select crypto backend and do not allow the user to select mbedtls with ualpn
Changes v1 -> v2 (after review of Thomas Petazzoni and Yann E. Morin):
- Do not use ualpn with mbedtls
package/uacme/Config.in | 24 ++++++++++++++++++++++++ package/uacme/uacme.mk | 6 +++--- 2 files changed, 27 insertions(+), 3 deletions(-)
package/uacme/Config.in +24 -0
@@ -16,6 +16,30 @@ config BR2_PACKAGE_UACME if BR2_PACKAGE_UACME +choice + prompt "Crypto Backend" + help + Select crypto library to be used in uacme. + +config BR2_PACKAGE_UACME_GNUTLS + bool "gnutls" + depends on BR2_PACKAGE_GNUTLS + +config BR2_PACKAGE_UACME_MBEDTLS + bool "mbedtls" + depends on BR2_PACKAGE_MBEDTLS + depends on !BR2_PACKAGE_UACME_UALPN + +comment "mbedtls crypto backend unavailable with ualpn" + depends on BR2_PACKAGE_MBEDTLS + depends on BR2_PACKAGE_UACME_UALPN + +config BR2_PACKAGE_UACME_OPENSSL + bool "openssl" + depends on BR2_PACKAGE_OPENSSL + +endchoice + config BR2_PACKAGE_UACME_UALPN bool "enable ualpn" depends on BR2_TOOLCHAIN_HAS_THREADS
package/uacme/uacme.mk +3 -3
@@ -15,13 +15,13 @@ UACME_DEPENDENCIES = libcurl UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99' -ifeq ($(BR2_PACKAGE_GNUTLS),y) +ifeq ($(BR2_PACKAGE_UACME_GNUTLS),y) UACME_CONF_OPTS += --with-gnutls UACME_DEPENDENCIES += gnutls -else ifeq ($(BR2_PACKAGE_MBEDTLS),y) +else ifeq ($(BR2_PACKAGE_UACME_MBEDTLS),y) UACME_CONF_OPTS += --with-mbedtls UACME_DEPENDENCIES += mbedtls -else ifeq ($(BR2_PACKAGE_OPENSSL),y) +else ifeq ($(BR2_PACKAGE_UACME_OPENSSL),y) UACME_CONF_OPTS += --with-openssl UACME_DEPENDENCIES += openssl endif
Signature · 1 line
2.25.1