Skip to contentSkip to conversation

spi: mpc8xxx_spi: fix missing dev_err definition

PATCH New Rasmus Villemoes 2 participants 2 messages Apr 20, 2020 – Apr 26, 2020 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: mpc8xxx_spi: fix missing dev_err definition

The build currently fails with

drivers/spi/mpc8xxx_spi.c:64:3: warning: implicit declaration of function ?dev_err? [-Wimplicit-function-declaration]
...
drivers/spi/built-in.o: In function `mpc8xxx_spi_set_speed':
drivers/spi/mpc8xxx_spi.c:227: undefined reference to `dev_err'

Fixes 4856cc7a97 (mpc8xxx_spi: implement real ->set_speed)
Fixes 1a7b462dee (mpc8xxx_spi: put max_cs to use)

---
Those patches got into -rc5, but I hadn't noticed commit 336d4615f8fa (dm: core: Create a new header file for 'compat' features) from -rc2. Sorry about this. Probably no buildbot caught it before release because no in-tree defconfig sets CONFIG_MPC8XXX_SPI=y.

 drivers/spi/mpc8xxx_spi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/mpc8xxx_spi.c +1 -0
index 1bde31ad34..e48debb045 100644
@@ -12,6 +12,7 @@
 #include <spi.h>
 #include <asm/mpc8xxx_spi.h>
 #include <asm-generic/gpio.h>
+#include <dm/device_compat.h>
 
 enum {
 	SPI_EV_NE = BIT(31 - 22),	/* Receiver Not Empty */
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 spi: mpc8xxx_spi: fix missing dev_err definition

Quoted 10 lines · Rasmus Villemoes

The build currently fails with

drivers/spi/mpc8xxx_spi.c:64:3: warning: implicit declaration of function ?dev_err? [-Wimplicit-function-declaration]
...
drivers/spi/built-in.o: In function `mpc8xxx_spi_set_speed':
drivers/spi/mpc8xxx_spi.c:227: undefined reference to `dev_err'

Fixes 4856cc7a97 (mpc8xxx_spi: implement real ->set_speed)
Fixes 1a7b462dee (mpc8xxx_spi: put max_cs to use)

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200426/43b0b145/attachment.sig>