Skip to contentSkip to conversation

aspeed: DTS specified m-pll

PATCH In review Joel Stanley 2 participants 5 messages Apr 27, 2020

Subsystems (2)
lore
Share & tools
lore

Joel Stanley

author maintainer
#0 lore raw

cover aspeed: DTS specified m-pll

Joel Stanley (2):
ast2600: ram: Enable device tree based DDR config
ast2600: tacoma: Run DDR at 1333

 arch/arm/dts/ast2600-tacoma.dts    |  2 +-
 drivers/ram/aspeed/Kconfig         |  7 +++++
 drivers/ram/aspeed/sdram_ast2600.c | 47 ++++++++++++++++++++++++------
 3 files changed, 46 insertions(+), 10 deletions(-)
Signature · 1 line
2.26.1
author maintainer
#1 lore raw

PATCH 1/2 ast2600: ram: Enable device tree based DDR config

The driver supports specification of the M-PLL via the device tree, and partially supported using this to configure the SDRAM rate used for memory training.

This patch finishes the job and exposes the setting through Kconfig.

---
 drivers/ram/aspeed/Kconfig         |  7 +++++
 drivers/ram/aspeed/sdram_ast2600.c | 47 ++++++++++++++++++++++++------
 2 files changed, 45 insertions(+), 9 deletions(-)
drivers/ram/aspeed/Kconfig +7 -0
index 38bbe128da71..0d30cd6941fe 100644
@@ -1,7 +1,14 @@
 if RAM || SPL_RAM
 
+config AST2600_SDRAMMC_MANUAL_CLK
+	bool "AST2600 SDRAM manual clock rate selection"
+	help
+	 In order to speed up DRAM init time, write pre-defined values to
+	 registers directly. This skips devce tree based detection.
+
 choice
 	prompt "DDR4 target data rate"
+	depends on AST2600_SDRAMMC_MANUAL_CLK
 	default ASPEED_DDR4_1600
 
 config ASPEED_DDR4_400
drivers/ram/aspeed/sdram_ast2600.c +38 -9

118 lines not on this page · raw message

Signature · 1 line
2.26.1
Acked-by on v1 1/2
#2 lore raw

Re: [PATCH u-boot v2019.04-aspeed-openbmc 1/2] ast2600: ram: Enable device tree based DDR config

Quoted 7 lines · Joel Stanley

The driver supports specification of the M-PLL via the device tree, and partially supported using this to configure the SDRAM rate used for memory training.

This patch finishes the job and exposes the setting through Kconfig.

author maintainer
#3 lore raw

PATCH 2/2 ast2600: tacoma: Run DDR at 1333

In reply to Joel Stanley

Restrict M-PLL to 333MHz so DDR runs at 1333MHz. Failures were seen when running M-PLL at 400MHz.

---
 arch/arm/dts/ast2600-tacoma.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/ast2600-tacoma.dts +1 -1
index 302847b1a8e5..b56d0029c655 100644
@@ -39,7 +39,7 @@
 };
 
 &sdrammc {
-	clock-frequency = <400000000>;
+	clock-frequency = <333000000>;
 };
 
 &wdt2 {
Signature · 1 line
2.26.1