Skip to contentSkip to conversation

kbuild: remove unused AS assignment

PATCH In review Masahiro Yamada 3 participants 4 messages Apr 27, 2020 – May 1, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: remove unused AS assignment

$(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove AS variable") killed it.

Remove the left-over code in arch/{arm,arm64}/Makefile.

---

 arch/arm/Makefile   | 2 --
 arch/arm64/Makefile | 2 --
 2 files changed, 4 deletions(-)
arch/arm/Makefile +0 -2
index 7d5cd0f85461..cd28211f1418 100644
@@ -45,12 +45,10 @@ endif
 ifeq ($(CONFIG_CPU_BIG_ENDIAN),y)
 KBUILD_CPPFLAGS	+= -mbig-endian
 CHECKFLAGS	+= -D__ARMEB__
-AS		+= -EB
 KBUILD_LDFLAGS	+= -EB
 else
 KBUILD_CPPFLAGS	+= -mlittle-endian
 CHECKFLAGS	+= -D__ARMEL__
-AS		+= -EL
 KBUILD_LDFLAGS	+= -EL
 endif
 
arch/arm64/Makefile +0 -2
index 85e4149cc5d5..d86cc9137539 100644
@@ -84,7 +84,6 @@ KBUILD_CFLAGS += $(branch-prot-flags-y)
 ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
 KBUILD_CPPFLAGS	+= -mbig-endian
 CHECKFLAGS	+= -D__AARCH64EB__
-AS		+= -EB
 # Prefer the baremetal ELF build target, but not all toolchains include
 # it so fall back to the standard linux version if needed.
 KBUILD_LDFLAGS	+= -EB $(call ld-option, -maarch64elfb, -maarch64linuxb)
@@ -92,7 +91,6 @@ UTS_MACHINE	:= aarch64_be
 else
 KBUILD_CPPFLAGS	+= -mlittle-endian
 CHECKFLAGS	+= -D__AARCH64EL__
-AS		+= -EL
 # Same as above, prefer ELF but fall back to linux target if needed.
 KBUILD_LDFLAGS	+= -EL $(call ld-option, -maarch64elf, -maarch64linux)
 UTS_MACHINE	:= aarch64
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Masahiro Yamada
Quoted 11 lines · Masahiro Yamada

$(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove AS variable") killed it.

Remove the left-over code in arch/{arm,arm64}/Makefile.

---

 arch/arm/Makefile   | 2 --
 arch/arm64/Makefile | 2 --
 2 files changed, 4 deletions(-)

(If you post the arm64 part as a separate patch, I can pick it up)

Will

#3 lore raw
Quoted 10 lines · Will Deacon
Quoted 8 lines · Masahiro Yamada

$(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove AS variable") killed it.

Remove the left-over code in arch/{arm,arm64}/Makefile.

---

Quoted 7 lines
Quoted 3 lines
 arch/arm/Makefile   | 2 --
 arch/arm64/Makefile | 2 --
 2 files changed, 4 deletions(-)

(If you post the arm64 part as a separate patch, I can pick it up)

This is just a trivial cleanup patch.
So, I do not split it per-arch.

Applied to linux-kbuild.

Signature · 2 lines
Best Regards
Masahiro Yamada