Skip to contentSkip to conversation

net: lpc-enet: fix error return code in lpc_mii_init()

PATCH Applied Wei Yongjun 3 participants 3 messages Apr 27, 2020 – May 1, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: lpc-enet: fix error return code in lpc_mii_init()

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.

Fixes b7370112f519 ("lpc32xx: Added ethernet driver")
---
 drivers/net/ethernet/nxp/lpc_eth.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/nxp/lpc_eth.c +2 -1
index d20cf03a3ea0..311454d9b0bc 100644
@@ -823,7 +823,8 @@ static int lpc_mii_init(struct netdata_local *pldat)
 	if (err)
 		goto err_out_unregister_bus;
 
-	if (lpc_mii_probe(pldat->ndev) != 0)
+	err = lpc_mii_probe(pldat->ndev);
+	if (err)
 		goto err_out_unregister_bus;
 
 	return 0;