Skip to contentSkip to conversation

ptp_qoriq: output PPS signal on FIPER2 in default

PATCH Applied Yangbo Lu 3 participants 4 messages Apr 27, 2020 – May 1, 2020

Subsystems (4)
lore
Share & tools
lore

Yangbo Lu

author maintainer
#0 lore raw

PATCH 1/1 ptp_qoriq: output PPS signal on FIPER2 in default

Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default which is more desired by user.

---
 include/linux/fsl/ptp_qoriq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/fsl/ptp_qoriq.h +1 -1
index 7588456..884b8f8 100644
@@ -135,7 +135,7 @@ struct ptp_qoriq_registers {
 #define DEFAULT_CKSEL		1
 #define DEFAULT_TMR_PRSC	2
 #define DEFAULT_FIPER1_PERIOD	1000000000
-#define DEFAULT_FIPER2_PERIOD	100000
+#define DEFAULT_FIPER2_PERIOD	1000000000
 
 struct ptp_qoriq {
 	void __iomem *base;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · Yangbo Lu

Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default which is more desired by user.

FIPER1 is already 1-PPS by default, and the user can load anything they want in the device tree, so I don't really see the need for this change.

But, I am not really opposed to it, either.

Thanks,
Richard

author maintainer
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: Richard Cochran <[email protected]>
Sent: Monday, April 27, 2020 9:52 PM
To: Y.b. Lu <[email protected]>
Cc: [email protected]; David S . Miller <[email protected]>; Leo Li <[email protected]>
Subject: Re: [PATCH] ptp_qoriq: output PPS signal on FIPER2 in default

On Mon, Apr 27, 2020 at 11:39:03AM +0800, Yangbo Lu wrote:

Quoted 8 lines
Quoted 2 lines

Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default which is more desired by user.

FIPER1 is already 1-PPS by default, and the user can load anything they want in the device tree, so I don't really see the need for this change.

But, I am not really opposed to it, either.

Thanks a lot, Richard.
Yes, I understand. I just think as the default configuration, PPS may be properer than 100 us period pulse which I don't know used for.

Quoted 3 lines

Thanks,
Richard