Skip to contentSkip to conversation

iio: bmp280: fix compensation of humidity

PATCH Superseded Andreas Klinger 2 participants 2 messages Apr 27, 2020 IIO

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: bmp280: fix compensation of humidity

Output of humidity compensation is limited to the range between 0 and 100 percent. Add this to the compensation formula as described in the datasheet chapter 4.2.3.

---
 drivers/iio/pressure/bmp280-core.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/iio/pressure/bmp280-core.c +3 -0
index 29c209cc1108..ac9ef1b63b07 100644
@@ -271,6 +271,9 @@ static u32 bmp280_compensate_humidity(struct bmp280_data *data,
 		+ (s32)2097152) * calib->H2 + 8192) >> 14);
 	var -= ((((var >> 15) * (var >> 15)) >> 7) * (s32)calib->H1) >> 4;
 
+	var = var < 0 ? 0 : var;
+	var = var > 419430400 ? 419430400 : var;
+
 	return var >> 12;
 };
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 14 lines · Andreas Klinger

Output of humidity compensation is limited to the range between 0 and 100 percent. Add this to the compensation formula as described in the datasheet chapter 4.2.3.

---
 drivers/iio/pressure/bmp280-core.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/iio/pressure/bmp280-core.c +0 -0
index 29c209cc1108..ac9ef1b63b07 100644

drivers/iio/pressure/bmp280-core.c static u32 bmp280_compensate_humidity(struct bmp280_data *data, · line 276

Quoted 6 lines
drivers/iio/pressure/bmp280-core.c +3 -0
@@ -271,6 +271,9 @@ static u32 bmp280_compensate_humidity(struct bmp280_data *data,
 		+ (s32)2097152) * calib->H2 + 8192) >> 14);
 	var -= ((((var >> 15) * (var >> 15)) >> 7) * (s32)calib->H1) >> 4;
 
+	var = var < 0 ? 0 : var;
+	var = var > 419430400 ? 419430400 : var;
+

Looks that clamp_val() might come in handy here.

Quoted 5 lines
drivers/iio/pressure/bmp280-core.c +0 -1
 	return var >> 12;
 };
 
--

2.20.1