Skip to contentSkip to conversation

examples/ip_pipeline: fix resource leak for pipeline

PATCH In review Jasvinder Singh 2 participants 2 messages Apr 27, 2020 – May 24, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples/ip_pipeline: fix resource leak for pipeline

For sending request messages to data plane threads, the caller invokes pipeline_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response.

Coverity Issues: 357750, 357740, 357749, 357758, 357702, 357736, 357679, 357791, 357738, 357778, 357716, 357705, 357776, 357753, 357729, 357735

Fixes 50e73d051806 ("examples/ip_pipeline: add stats read commands")
Fixes 6b1b3c3c9d30 ("examples/ip_pipeline: add port enable and disable commands")
Fixes a3a95b7d58b9 ("examples/ip_pipeline: add table entry commands")
Fixes 3186282f8e12 ("examples/ip_pipeline: add table bulk add command")
Fixes f634e4c5698a ("examples/ip_pipeline: add table entry delete command")
Fixes c64b9121a963 ("examples/ip_pipeline: add table entry stats command")
Fixes 7e11393e40ef ("examples/ip_pipeline: add meter profile commands")
Fixes e92058d604e6 ("examples/ip_pipeline: add meter stats command")
Fixes 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command")
Fixes d0d306c7f2a1 ("examples/ip_pipeline: add TTL stats command")
Fixes a3169ee5ec59 ("examples/ip_pipeline: support rule time read")
---
 examples/ip_pipeline/thread.c | 40 -----------------------------------
 1 file changed, 40 deletions(-)
examples/ip_pipeline/thread.c +0 -40
index fda4d3c2a..adb83167c 100644
@@ -811,8 +811,6 @@ pipeline_port_in_stats_read(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -859,8 +857,6 @@ pipeline_port_in_enable(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -905,8 +901,6 @@ pipeline_port_in_disable(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -959,8 +953,6 @@ pipeline_port_out_stats_read(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -1015,8 +1007,6 @@ pipeline_table_stats_read(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -1432,10 +1422,6 @@ pipeline_table_rule_add(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL) {
-		free(rule);
-		return -1;
-	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1534,10 +1520,6 @@ pipeline_table_rule_add_default(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL) {
-		free(rule);
-		return -1;
-	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1651,10 +1633,6 @@ pipeline_table_rule_add_bulk(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL) {
-		table_rule_list_free(list);
-		return -ENOMEM;
-	}
 
 	/* Read response */
 	status = rsp->status;
@@ -1729,8 +1707,6 @@ pipeline_table_rule_delete(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -1786,8 +1762,6 @@ pipeline_table_rule_delete_default(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -1853,8 +1827,6 @@ pipeline_table_rule_stats_read(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -1911,8 +1883,6 @@ pipeline_table_mtr_profile_add(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -1963,8 +1933,6 @@ pipeline_table_mtr_profile_delete(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -2033,8 +2001,6 @@ pipeline_table_rule_mtr_read(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -2092,8 +2058,6 @@ pipeline_table_dscp_table_update(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -2160,8 +2124,6 @@ pipeline_table_rule_ttl_read(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
@@ -2225,8 +2187,6 @@ pipeline_table_rule_time_read(const char *pipeline_name,
 
 	/* Send request and wait for response */
 	rsp = pipeline_msg_send_recv(p, req);
-	if (rsp == NULL)
-		return -1;
 
 	/* Read response */
 	status = rsp->status;
Signature · 1 line
2.21.1
#1 lore raw

27/04/2020 18:57, Jasvinder Singh:

Quoted 21 lines

For sending request messages to data plane threads, the caller invokes pipeline_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response.

Coverity Issues: 357750, 357740, 357749, 357758, 357702, 357736, 357679, 357791, 357738, 357778, 357716, 357705, 357776, 357753, 357729, 357735

Fixes 50e73d051806 ("examples/ip_pipeline: add stats read commands")
Fixes 6b1b3c3c9d30 ("examples/ip_pipeline: add port enable and disable commands")
Fixes a3a95b7d58b9 ("examples/ip_pipeline: add table entry commands")
Fixes 3186282f8e12 ("examples/ip_pipeline: add table bulk add command")
Fixes f634e4c5698a ("examples/ip_pipeline: add table entry delete command")
Fixes c64b9121a963 ("examples/ip_pipeline: add table entry stats command")
Fixes 7e11393e40ef ("examples/ip_pipeline: add meter profile commands")
Fixes e92058d604e6 ("examples/ip_pipeline: add meter stats command")
Fixes 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command")
Fixes d0d306c7f2a1 ("examples/ip_pipeline: add TTL stats command")
Fixes a3169ee5ec59 ("examples/ip_pipeline: support rule time read")
Quoted 2 lines

This patch has been forgotten.

Applied and squashed with "fix resource leak for thread".