kernfs: fix possibility of NULL pointer dereference.
PATCH 1/1 kernfs: fix possibility of NULL pointer dereference.
When dentry is negative, "kernfs_dentry_node" returns NULL. In this case, "kernfs_root" dereferences NULL pointer.
Signed-off-by youngjun <[email protected]>
--- fs/kernfs/dir.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
fs/kernfs/dir.c +10 -8
@@ -1133,15 +1133,16 @@ static int kernfs_iop_mkdir(struct inode *dir, struct dentry *dentry,static int kernfs_iop_rmdir (struct inode *dir,struct dentry *dentry) {struct kernfs_node *kn =kernfs_dentry_node (dentry); -struct kernfs_syscall_ops *scops =kernfs_root (kn)->syscall_ops; +struct kernfs_syscall_ops *scops;int ret; -if (!scops || !scops->rmdir) -return -EPERM ; -if (!kernfs_get_active (kn))return -ENODEV ; + scops =kernfs_root (kn)->syscall_ops; +if (!scops || !scops->rmdir) +return -EPERM ; + ret = scops->rmdir (kn);kernfs_put_active (kn);
@@ -1154,18 +1155,19 @@ static int kernfs_iop_rename(struct inode *old_dir, struct dentry *old_dentry, {struct kernfs_node *kn =kernfs_dentry_node (old_dentry);struct kernfs_node *new_parent = new_dir->i_private; -struct kernfs_syscall_ops *scops =kernfs_root (kn)->syscall_ops; +struct kernfs_syscall_ops *scops;int ret;if (flags)return -EINVAL ; -if (!scops || !scops->rename) -return -EPERM ; -if (!kernfs_get_active (kn))return -ENODEV ; + scops =kernfs_root (kn)->syscall_ops; +if (!scops || !scops->rename) +return -EPERM ; +if (!kernfs_get_active (new_parent)) {kernfs_put_active (kn);return -ENODEV ;
Signature · 1 line
2.17.1
Greg Kroah-Hartman
maintainerQuoted 7 lines · youngjun
When dentry is negative, "
kernfs_dentry_node" returns NULL. In this case, "kernfs_root" dereferences NULL pointer.Signed-off-by youngjun <[email protected]>--- fs/kernfs/dir.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
And how can this be triggered on a kernfs filesystem?
thanks,
greg k-h