Skip to contentSkip to conversation

boot/uboot: switch to host-python3

PATCH New Francois Perrad 3 participants 3 messages Apr 26, 2020 – Apr 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boot/uboot: switch to host-python3

that fixes the following build failures with olimex_a20_olinuxino_lime*_defconfig:
https://gitlab.com/buildroot.org/buildroot/-/jobs/526035680
https://gitlab.com/buildroot.org/buildroot/-/jobs/526035682

---
 boot/uboot/uboot.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/uboot/uboot.mk +1 -1
index 2bfa50779..688cc17cc 100644
@@ -160,7 +160,7 @@ UBOOT_DEPENDENCIES += host-dtc
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
-UBOOT_DEPENDENCIES += host-python host-swig
+UBOOT_DEPENDENCIES += host-python3 host-swig
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS),y)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 boot/uboot: switch to host-python3

Fran?ois, All,

On 2020-04-26 16:03 +0200, Francois Perrad spake thusly:

Quoted 14 lines

that fixes the following build failures with olimex_a20_olinuxino_lime*_defconfig:
https://gitlab.com/buildroot.org/buildroot/-/jobs/526035680
https://gitlab.com/buildroot.org/buildroot/-/jobs/526035682

---
 boot/uboot/uboot.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
boot/uboot/uboot.mk +0 -0
index 2bfa50779..688cc17cc 100644

boot/uboot/uboot.mk UBOOT_DEPENDENCIES += host-dtc · line 163

Quoted 5 lines
boot/uboot/uboot.mk +1 -1
@@ -160,7 +160,7 @@ UBOOT_DEPENDENCIES += host-dtc
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
-UBOOT_DEPENDENCIES += host-python host-swig
+UBOOT_DEPENDENCIES += host-python3 host-swig

This is not correct, because it is possible to use older versions of uboot that still require python2, and this chagne would break them, as well as our 33 other defconfigs that are still using such an older uboot.

Another discussion was started on that topic:

    http://lists.busybox.net/pipermail/buildroot/2020-April/281309.html

Regards,
Yann E. MORIN.

Quoted 10 lines
boot/uboot/uboot.mk +0 -0
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS),y)
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 boot/uboot: switch to host-python3

In reply to Francois Perrad

boot/uboot/uboot.mk UBOOT_DEPENDENCIES += host-dtc · line 164

Quoted 4 lines · On Sun, 26 Apr 2020 16:03:30 +0200 Francois Perrad <[email protected]> wrote:

ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)

boot/uboot/uboot.mk +1 -1
-UBOOT_DEPENDENCIES += host-python host-swig
+UBOOT_DEPENDENCIES += host-python3 host-swig
 endif

No, this is going to break the build of older U-Boots that need Python
2. We are having a discussion about this in the thread at:

http://patchwork.ozlabs.org/project/buildroot/patch/20200425000629.2068191-1-heiko at sntech.de/

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com