Skip to contentSkip to conversation

package/libtasn1: fix build with gcc 4.8

PATCH New Fabrice Fontaine 2 participants 3 messages Apr 24, 2020 – Apr 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/libtasn1: fix build with gcc 4.8

Fixes:
- http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896

---
Changes v1 -> v2 (after review of Yann E. Morin):
- Set -std=gnu99 instead of patching source code

 package/libtasn1/libtasn1.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libtasn1/libtasn1.mk +2 -0
index 9b8260ab48..d5a6c69965 100644
@@ -17,4 +17,6 @@ LIBTASN1_AUTORECONF = YES
 # 'missing' fallback logic botched so disable it completely
 LIBTASN1_CONF_ENV = MAKEINFO="true"
 
+LIBTASN1_CONF_OPTS = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
+
 $(eval $(autotools-package))
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/1 package/libtasn1: fix build with gcc 4.8

Quoted 7 lines · On Fri, 24 Apr 2020 20:03:21 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896

---
Changes v1 -> v2 (after review of Yann E. Morin):
- Set -std=gnu99 instead of patching source code

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 package/libtasn1: fix build with gcc 4.8

In reply to Fabrice Fontaine
Quoted 16 lines · On Fri, 24 Apr 2020 20:03:21 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/0030c903abf6c964806a97067af94a99867a3896

---
Changes v1 -> v2 (after review of Yann E. Morin):
- Set -std=gnu99 instead of patching source code

 package/libtasn1/libtasn1.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libtasn1/libtasn1.mk +0 -0
index 9b8260ab48..d5a6c69965 100644

package/libtasn1/libtasn1.mk LIBTASN1_AUTORECONF = YES · line 20

Quoted 4 lines
package/libtasn1/libtasn1.mk +1 -0
@@ -17,4 +17,6 @@ LIBTASN1_AUTORECONF = YES
 # 'missing' fallback logic botched so disable it completely
 LIBTASN1_CONF_ENV = MAKEINFO="true"
 
+LIBTASN1_CONF_OPTS = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"

BTW: this should be fixed upstream by adding AC_PROG_CC_C99 in the configure.ac. Then we can drop adding -std=gnu99 manually.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com