Skip to contentSkip to conversation

package/mesa3d: add valgrind support

PATCH New James Hilliard 3 participants 7 messages Apr 28, 2020 – Jun 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mesa3d: add valgrind support

---
 package/mesa3d/mesa3d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
package/mesa3d/mesa3d.mk +8 -2
index 22eff24c56..ab10194a6a 100644
@@ -25,8 +25,7 @@ MESA3D_DEPENDENCIES = \
 
 MESA3D_CONF_OPTS = \
 	-Dgallium-omx=disabled \
-	-Dpower8=false \
-	-Dvalgrind=false
+	-Dpower8=false
 
 ifeq ($(BR2_PACKAGE_MESA3D_LLVM),y)
 MESA3D_DEPENDENCIES += host-llvm llvm
@@ -242,6 +241,13 @@ else
 MESA3D_CONF_OPTS += -Dgallium-xvmc=false
 endif
 
+ifeq ($(BR2_PACKAGE_VALGRIND),y)
+MESA3D_CONF_OPTS += -Dvalgrind=true
+MESA3D_DEPENDENCIES += valgrind
+else
+MESA3D_CONF_OPTS += -Dvalgrind=false
+endif
+
 ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
 MESA3D_CONF_OPTS += -Dlibunwind=true
 MESA3D_DEPENDENCIES += libunwind
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/mesa3d: add valgrind support

Quoted 4 lines · On Mon, 27 Apr 2020 23:22:25 -0600 James Hilliard <[email protected]>…
---
 package/mesa3d/mesa3d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/mesa3d: add valgrind support

In reply to James Hilliard
Quoted 4 lines · On Mon, 27 Apr 2020 23:22:25 -0600 James Hilliard <[email protected]>…
---
 package/mesa3d/mesa3d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Speaking of mesa3d/valgrind, we have this:

http://autobuild.buildroot.net/results/1b5/1b58d73ecbbe1af2c3e140563d696cf32d1c4a5a/build-end.log

Seems like mesa3d is trying to link with some static libraries from valgrind, which are not built with -fPIC. Have you looked into this?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/mesa3d: add valgrind support

Quoted 9 lines · Thomas Petazzoni
Quoted 4 lines · On Mon, 27 Apr 2020 23:22:25 -0600 James Hilliard <[email protected]>…
---
 package/mesa3d/mesa3d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Quoted 6 lines

Speaking of mesa3d/valgrind, we have this:

http://autobuild.buildroot.net/results/1b5/1b58d73ecbbe1af2c3e140563d696cf32d1c4a5a/build-end.log

Seems like mesa3d is trying to link with some static libraries from valgrind, which are not built with -fPIC. Have you looked into this?

Yeah, I had added this trying to fix that but it didn't seem to help.

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#4 lore raw

PATCH 1/1 package/mesa3d: add valgrind support

Hi James, Thomas,

Le 28/04/2020 ? 07:47, James Hilliard a ?crit?:

Quoted 11 lines
Quoted 9 lines · Thomas Petazzoni
Quoted 4 lines · On Mon, 27 Apr 2020 23:22:25 -0600 James Hilliard <[email protected]>…
---
 package/mesa3d/mesa3d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 6 lines

Speaking of mesa3d/valgrind, we have this:

http://autobuild.buildroot.net/results/1b5/1b58d73ecbbe1af2c3e140563d696cf32d1c4a5a/build-end.log

Seems like mesa3d is trying to link with some static libraries from valgrind, which are not built with -fPIC. Have you looked into this?

Yeah, I had added this trying to fix that but it didn't seem to help.

I spent some time investigating this issue but the problem is that mesa try to link with libcoregrind-<arch>-linux.a to build libgbm.so. But even by hacking the valgrind build system, the build is still failing.

I tried with several toolchain (glibc and uclibc).

Out of curiosity, what's your use case that require valgrind in mesa3d ?

Note: The valgrind support is enabled in archlinux and fedora

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/mesa

https://src.fedoraproject.org/rpms/valgrind/blob/master/f/valgrind.spec

But no problem on their side ?

Any idea ? otherwise we have to revert this patch because the build is still failing in the autobuilder.

Best regards,
Romain

Quoted 8 lines
Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#5 lore raw

PATCH 1/1 package/mesa3d: add valgrind support

Quoted 23 lines · Romain Naour

Hi James, Thomas,

Le 28/04/2020 ? 07:47, James Hilliard a ?crit :

Quoted 11 lines
Quoted 9 lines · Thomas Petazzoni
Quoted 4 lines · On Mon, 27 Apr 2020 23:22:25 -0600 James Hilliard <[email protected]>…
---
 package/mesa3d/mesa3d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 6 lines

Speaking of mesa3d/valgrind, we have this:

http://autobuild.buildroot.net/results/1b5/1b58d73ecbbe1af2c3e140563d696cf32d1c4a5a/build-end.log

Seems like mesa3d is trying to link with some static libraries from valgrind, which are not built with -fPIC. Have you looked into this?

Yeah, I had added this trying to fix that but it didn't seem to help.

Quoted 7 lines

I spent some time investigating this issue but the problem is that mesa try to link with libcoregrind-<arch>-linux.a to build libgbm.so. But even by hacking the valgrind build system, the build is still failing.

I tried with several toolchain (glibc and uclibc).

Out of curiosity, what's your use case that require valgrind in mesa3d ?

Well I sometimes use valgrind for tracing certain bugs, figured since mesa3d has a valgrind option we should use it when building valgrind.

Quoted 11 lines

Note: The valgrind support is enabled in archlinux and fedora

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/mesa

https://src.fedoraproject.org/rpms/valgrind/blob/master/f/valgrind.spec

But no problem on their side ?

Any idea ? otherwise we have to revert this patch because the build is still failing in the autobuilder.

The builds were failing before this patch so I don't see how reverting would help.

Quoted 14 lines

Best regards,
Romain

Quoted 8 lines
Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#6 lore raw

PATCH 1/1 package/mesa3d: add valgrind support

Hi James,

Le 10/06/2020 ? 17:45, James Hilliard a ?crit?:

Quoted 28 lines · Romain Naour
Quoted 27 lines

Hi James, Thomas,

Le 28/04/2020 ? 07:47, James Hilliard a ?crit :

Quoted 11 lines
Quoted 9 lines · Thomas Petazzoni
Quoted 4 lines · On Mon, 27 Apr 2020 23:22:25 -0600 James Hilliard <[email protected]>…
---
 package/mesa3d/mesa3d.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 6 lines

Speaking of mesa3d/valgrind, we have this:

http://autobuild.buildroot.net/results/1b5/1b58d73ecbbe1af2c3e140563d696cf32d1c4a5a/build-end.log

Seems like mesa3d is trying to link with some static libraries from valgrind, which are not built with -fPIC. Have you looked into this?

Yeah, I had added this trying to fix that but it didn't seem to help.

I spent some time investigating this issue but the problem is that mesa try to link with libcoregrind-<arch>-linux.a to build libgbm.so. But even by hacking the valgrind build system, the build is still failing.

Quoted 5 lines
Quoted 3 lines

I tried with several toolchain (glibc and uclibc).

Out of curiosity, what's your use case that require valgrind in mesa3d ?

Well I sometimes use valgrind for tracing certain bugs, figured since mesa3d has a valgrind option we should use it when building valgrind.

Ok

Quoted 5 lines
Quoted 5 lines

Note: The valgrind support is enabled in archlinux and fedora

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/mesa

Quoted 8 lines
Quoted 6 lines

https://src.fedoraproject.org/rpms/valgrind/blob/master/f/valgrind.spec

But no problem on their side ?

Any idea ? otherwise we have to revert this patch because the build is still failing in the autobuilder.

The builds were failing before this patch so I don't see how reverting would help.

Indeed it's not directly this patch, I thought that because it's a new issue related to valgrind... but it's more complicated than that. Actually It's a mesa/valgrind bug. mesa try to build the shared library libgbm.so using the valgrind static libraries. This should only be possible if valgrind static libraries are built with -fPIC.

As soon we have BR2_PACKAGE_VALGRIND=y and BR2_PACKAGE_MESA3D_GBM=y, the build issue should be reproducible.

I can reproduce it with the following defconfig:
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_VALGRIND=y
BR2_PACKAGE_VALGRIND_SGCHECK=y
BR2_PACKAGE_VALGRIND_BBV=y
BR2_PACKAGE_VALGRIND_LACKEY=y
BR2_PACKAGE_VALGRIND_NULGRIND=y
BR2_PACKAGE_MESA3D=y
BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y

Even before your patch, the problem can be reproduced due to libdrm built with valgrind support. Added long time ago [1].

Even if -Dvalgrind=false on meson command line to build mesa, the valgrind libraries come from pkg-config libdrm...

output/host/bin/pkg-config libdrm --libs --static -L[...]/sysroot/usr/lib -ldrm -lm -L[...]/sysroot/usr/lib/valgrind -lcoregrind-arm64-linux -lvex-arm64-linux -lgcc

... and break the build.

I tried to modify the valgrind build system to add -fPIC but the problem is still present.

I don't know how yet how to fix the problem.

[1]
https://git.buildroot.net/buildroot/commit/?id=da3805186a582fc42ec1b935da0ef87529284c6a

Best regards,
Romain

Quoted 14 lines
Quoted 14 lines

Best regards,
Romain

Quoted 8 lines
Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com