Skip to contentSkip to conversation

rtw88: fix sparse warnings for download firmware routine

PATCH In review [email protected] 2 participants 2 messages Apr 24, 2020 – Apr 28, 2020 Realtek wireless driver (rtw88)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtw88: fix sparse warnings for download firmware routine

From: Yan-Hsuan Chuang <[email protected]>

sparse warnings: (new ones prefixed by >>)

Quoted 1 line
Quoted 1 line

drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:

symbol '__rtw_download_firmware' was not declared. Should it be static?

Quoted 1 line
Quoted 1 line

drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:

symbol '__rtw_download_firmware_legacy' was not declared. Should it be static?

Fixes 15d2fcc6b2de ("rtw88: add legacy firmware download for 8723D devices")
---
 drivers/net/wireless/realtek/rtw88/mac.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/wireless/realtek/rtw88/mac.c +4 -2
index 645207a01525..6969379ba37e 100644
@@ -696,7 +696,8 @@ static void download_firmware_end_flow(struct rtw_dev *rtwdev)
 	rtw_write16(rtwdev, REG_MCUFW_CTRL, fw_ctrl);
 }
 
-int __rtw_download_firmware(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
+static int __rtw_download_firmware(struct rtw_dev *rtwdev,
+				   struct rtw_fw_state *fw)
 {
 	struct rtw_backup_info bckp[DLFW_RESTORE_REG_NUM];
 	const u8 *data = fw->firmware->data;
@@ -860,7 +861,8 @@ static int download_firmware_validate_legacy(struct rtw_dev *rtwdev)
 	return -EINVAL;
 }
 
-int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev, struct rtw_fw_state *fw)
+static int __rtw_download_firmware_legacy(struct rtw_dev *rtwdev,
+					  struct rtw_fw_state *fw)
 {
 	int ret = 0;
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · <[email protected]> wrote:

From: Yan-Hsuan Chuang <[email protected]>

sparse warnings: (new ones prefixed by >>)

Quoted 1 line
Quoted 1 line

drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:

Quoted 8 lines

symbol '__rtw_download_firmware' was not declared. Should it be static?

Quoted 1 line
Quoted 1 line

drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:

symbol '__rtw_download_firmware_legacy' was not declared. Should it be static?

Fixes 15d2fcc6b2de ("rtw88: add legacy firmware download for 8723D devices")

Patch applied to wireless-drivers-next.git, thanks.

3d8bf50860c7 rtw88: fix sparse warnings for download firmware routine

Signature · 3 lines
https://patchwork.kernel.org/patch/11507425/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches