Skip to contentSkip to conversation

ath11k: remove redundant dev_err call in ath11k_ahb_probe()

PATCH In review Wei Yongjun 2 participants 3 messages Apr 27, 2020 – Apr 28, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: remove redundant dev_err call in ath11k_ahb_probe()

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

---
 drivers/net/wireless/ath/ath11k/ahb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/wireless/ath/ath11k/ahb.c +1 -3
index e7e3e64c07aa..7d3d1cc6f39f 100644
@@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
 	}
 
 	mem = devm_ioremap_resource(&pdev->dev, mem_res);
-	if (IS_ERR(mem)) {
-		dev_err(&pdev->dev, "ioremap error\n");
+	if (IS_ERR(mem))
 		return PTR_ERR(mem);
-	}
 
 	ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
 	if (ret) {
#1 lore raw
Quoted 5 lines · Wei Yongjun

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

I don't see harm having two error messages and having an error message within ath11k makes it easier to find the exact location, so I'm dropping this.

Signature · 3 lines
https://patchwork.kernel.org/patch/11511845/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Wei Yongjun
Quoted 5 lines · Wei Yongjun

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

I don't see harm having two error messages and having an error message within ath11k makes it easier to find the exact location, so I'm dropping this.

Signature · 8 lines
https://patchwork.kernel.org/patch/11511845/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k