drm/i915: Remove dubious Valleyview PCI IDs
PATCH 1/1 drm/i915: Remove dubious Valleyview PCI IDs
0x0155 is rather Ivy Bridge PCI-E Root Port.0x0157 from the same commit ff049b6ce21d2814451afd4a116d001712e0116b is likely wrong too. Nowhere is it independetly confirmed or mentioned.
--- include/drm/i915_pciids.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
include/drm/i915_pciids.h +1 -3
@@ -258,9 +284,7 @@ Remove wrong and non-existent devicesINTEL_VGA_DEVICE (0x0f30 , info), \INTEL_VGA_DEVICE (0x0f31 , info), \INTEL_VGA_DEVICE (0x0f32 , info), \ - INTEL_VGA_DEVICE(0x0f33, info), \ - INTEL_VGA_DEVICE(0x0157, info), \ - INTEL_VGA_DEVICE(0x0155, info) + INTEL_VGA_DEVICE(0x0f33, info)#define INTEL_BDW_ULT_GT1_IDS (info) \ INTEL_VGA_DEVICE(0x1606, info),/* GT1 ULT */ \
--
2.26.2
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove dubious Valleyview PCI IDs
== Series Details ==
== Series Details ==
Series: drm/i915: Remove dubious Valleyview PCI IDs
URL : https://patchwork.freedesktop.org/series/76578/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2efbc6a316e7 drm/i915: Remove dubious Valleyview PCI IDs
-:7: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit ff049b6ce21d ("drm/i915: bind driver to ValleyView chipsets")'
#7:
0x0157 from the same commit ff049b6ce21d2814451afd4a116d001712e0116btotal: 1 errors, 0 warnings, 0 checks, 10 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove dubious Valleyview PCI IDs
In reply to Alexei Podtelezhnikov== Series Details ==
== Series Details ==
Series: drm/i915: Remove dubious Valleyview PCI IDs
URL : https://patchwork.freedesktop.org/series/76578/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8377 -> Patchwork_17488
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/index.html
Known issues
------------
Here are the changes found in Patchwork_17488 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@active:
- fi-apl-guc: [PASS][1] -> [DMESG-FAIL][2] ([i915#666])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/fi-apl-guc/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/fi-apl-guc/igt@i915_selftest@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [SKIP][3] ([fdo#109271]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/fi-kbl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/fi-kbl-guc/igt@[email protected]
* igt@i915_selftest@live@execlists:
- {fi-tgl-u}: [INCOMPLETE][5] -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/fi-tgl-u/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/fi-tgl-u/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][7] ([i915#62]) -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/fi-kbl-x1275/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#666]: https://gitlab.freedesktop.org/drm/intel/issues/666
Participating hosts (48 -> 44)
------------------------------
Additional (1): fi-kbl-7560u
Missing (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8377 -> Patchwork_17488
CI-20190529: 20190529
CI_DRM_8377: 1c73868f3851a83d78063da68c6e9b2c363b5f36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5612: c8dc1fd926a550308b971ca7d83fe0a927a38152 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17488: 2efbc6a316e7d46d01c8885b29e30c5772aec7cb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2efbc6a316e7 drm/i915: Remove dubious Valleyview PCI IDs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove dubious Valleyview PCI IDs
In reply to Alexei Podtelezhnikov== Series Details ==
== Series Details ==
Series: drm/i915: Remove dubious Valleyview PCI IDs
URL : https://patchwork.freedesktop.org/series/76578/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8377_full -> Patchwork_17488_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17488_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-kbl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-kbl1/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#52] / [i915#54]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-glk8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-glk7/igt@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][5] -> [FAIL][6] ([i915#1188])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-skl6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-skl8/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-apl8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-apl1/igt@[email protected]
- shard-skl: [PASS][9] -> [INCOMPLETE][10] ([i915#69])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-skl1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-skl7/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109441]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-iclb2/igt@kms_psr@psr2_basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-iclb6/igt@kms_psr@psr2_basic.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#31])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-apl7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-apl3/igt@[email protected]
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@bcs0}:
- shard-kbl: [DMESG-WARN][15] ([i915#180]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-kbl6/igt@gem_ctx_isolation@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-kbl6/igt@gem_ctx_isolation@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][17] ([i915#180]) -> [PASS][18] +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-apl6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-apl7/igt@[email protected]
* {igt@kms_flip@flip-vs-expired-vblank@b-dp1}:
- shard-kbl: [FAIL][19] ([i915#79]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-kbl4/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-kbl6/igt@kms_flip@[email protected]
* {igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1}:
- shard-skl: [FAIL][21] ([i915#34]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-skl10/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][23] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-kbl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-kbl3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [INCOMPLETE][25] ([i915#123] / [i915#69]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-skl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-skl2/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][27] ([i915#1188]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-skl7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][29] ([fdo#108145] / [i915#265]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-skl8/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-skl10/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][31] ([fdo#109642] / [fdo#111068]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-iclb8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][33] ([fdo#109441]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* {igt@sysfs_heartbeat_interval@mixed@rcs0}:
- shard-skl: [FAIL][35] ([i915#1731]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-skl4/igt@sysfs_heartbeat_interval@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-skl5/igt@sysfs_heartbeat_interval@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][37] ([i915#454]) -> [SKIP][38] ([i915#468])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-tglb7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-tglb2/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-snb: [SKIP][39] ([fdo#109271]) -> [INCOMPLETE][40] ([i915#82])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-snb6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-snb2/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][41] ([fdo#109642] / [fdo#111068]) -> [FAIL][42] ([i915#608])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8377/shard-iclb1/igt@kms_psr2_su@page_flip.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/shard-iclb2/igt@kms_psr2_su@page_flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 11)
------------------------------
Additional (1): pig-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8377 -> Patchwork_17488
CI-20190529: 20190529
CI_DRM_8377: 1c73868f3851a83d78063da68c6e9b2c363b5f36 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5612: c8dc1fd926a550308b971ca7d83fe0a927a38152 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17488: 2efbc6a316e7d46d01c8885b29e30c5772aec7cb @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17488/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Alexei Podtelezhnikov
0x0155is rather Ivy Bridge PCI-E Root Port.
A bit surprising we've not had any reports of the driver biding to the wrong device.
Quoted 2 lines
0x0157from the same commitff049b6ce21d2814451afd4a116d001712e0116bis likely wrong too. Nowhere is it independetly confirmed or mentioned.
Can' find these in the spec so they do seem bogus. Also can't remember ever seeing one of these.
Quoted 27 lines
Signed-off-by Alexei Podtelezhnikov <[email protected]>--- include/drm/i915_pciids.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)include/drm/i915_pciids.h +1
-4@@ -258,9 +284,7 @@ Remove wrong and non-existent devicesINTEL_VGA_DEVICE (0x0f30 , info), \INTEL_VGA_DEVICE (0x0f31 , info), \INTEL_VGA_DEVICE (0x0f32 , info), \ - INTEL_VGA_DEVICE(0x0f33, info), \ - INTEL_VGA_DEVICE(0x0157, info), \ - INTEL_VGA_DEVICE(0x0155, info) + INTEL_VGA_DEVICE(0x0f33, info)#define INTEL_BDW_ULT_GT1_IDS (info) \ INTEL_VGA_DEVICE(0x1606, info),/* GT1 ULT */ \ --2.26.2
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx