Skip to contentSkip to conversation

dpaa2-eth: Use proper division helper in dpaa2_dbg_ch_show

PATCH Applied Nathan Chancellor 3 participants 3 messages Apr 28, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dpaa2-eth: Use proper division helper in dpaa2_dbg_ch_show

When building arm32 allmodconfig:

ERROR: modpost: "__aeabi_uldivmod" [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined!

frames and cdan are both of type __u64 (unsigned long long) so we need to use div64_u64 to avoid this issues.

Fixes 460fd830dd9d ("dpaa2-eth: add channel stat to debugfs")
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c +1 -1
index 80291afff3ea..0a31e4268dfb 100644
@@ -139,7 +139,7 @@ static int dpaa2_dbg_ch_show(struct seq_file *file, void *offset)
 			   ch->stats.dequeue_portal_busy,
 			   ch->stats.frames,
 			   ch->stats.cdan,
-			   ch->stats.frames / ch->stats.cdan,
+			   div64_u64(ch->stats.frames, ch->stats.cdan),
 			   ch->buf_count);
 	}
 

base-commit: 0fd02a5d3eb7020a7e1801f8d7f01891071c85e4

Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Nathan Chancellor

When building arm32 allmodconfig:

ERROR: modpost: "__aeabi_uldivmod" [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined!

Quoted 6 lines

frames and cdan are both of type __u64 (unsigned long long) so we need to use div64_u64 to avoid this issues.

Fixes 460fd830dd9d ("dpaa2-eth: add channel stat to debugfs")

Don't forget reported by tags to show some love to our bots! Thanks for the patch.

Quoted 26 lines
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debugfs.c +1 -1
index 80291afff3ea..0a31e4268dfb 100644
@@ -139,7 +139,7 @@ static int dpaa2_dbg_ch_show(struct seq_file *file, void *offset)
                           ch->stats.dequeue_portal_busy,
                           ch->stats.frames,
                           ch->stats.cdan,
-                          ch->stats.frames / ch->stats.cdan,
+                          div64_u64(ch->stats.frames, ch->stats.cdan),
                           ch->buf_count);
        }
 

base-commit: 0fd02a5d3eb7020a7e1801f8d7f01891071c85e4 --
2.26.2

--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200428174221.2040849-1-natechancellor%40gmail.com.

Signature · 2 lines
Thanks,
~Nick Desaulniers
maintainer Applied
#2 lore raw

From: Nick Desaulniers <[email protected]>
Date: Tue, 28 Apr 2020 11:34:11 -0700

Quoted 11 lines
Quoted 9 lines · Nathan Chancellor

When building arm32 allmodconfig:

ERROR: modpost: "__aeabi_uldivmod" [drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-eth.ko] undefined!

frames and cdan are both of type __u64 (unsigned long long) so we need to use div64_u64 to avoid this issues.

Quoted 8 lines
Quoted 3 lines
Fixes 460fd830dd9d ("dpaa2-eth: add channel stat to debugfs")

Don't forget reported by tags to show some love to our bots! Thanks for the patch.

Applied to net-next, thanks.